fix comments following review

EternisAI · Nov 5, 2024 · fb52501 · fb52501
1 parent e8c4c20
commit fb52501
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 34 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/entries/Offscreen/Offscreen.tsx b/src/entries/Offscreen/Offscreen.tsx
@@ -231,8 +231,8 @@ async function createProof(options: {
   const prover: _Prover = await new Prover({
     id,
     serverDns: hostname,
-    maxSentData: 0,
-    maxRecvData: 0,
+    maxSentData: 0, //legacy fields from tlsn, to remove
+    maxRecvData: 0, //legacy fields from tlsn, to remove
   });
 
   await prover.setup(await notary.sessionUrl(0, 0));

diff --git a/src/pages/Options/index.tsx b/src/pages/Options/index.tsx
@@ -280,26 +280,28 @@ function NormalOptions(props: {
         <div className="input border bg-slate-100">{version}</div>
       </div> */}
 
-      <InputField
-        label="Your public key"
-        placeholder="Public key"
-        value={bigintToHex(identity?.commitment)}
-        type="text"
-        readOnly
-        multiline
-        LabelIcon={
-          <div
-            onClick={() => {
-              chrome.tabs.create({
-                url: 'https://eternis.ai/',
-              });
-            }}
-            className="cursor-pointer"
-          >
-            <InfoCircle />
-          </div>
-        }
-      />
+      {identity && (
+        <InputField
+          label="Your public key"
+          placeholder="Public key"
+          value={bigintToHex(identity?.commitment)}
+          type="text"
+          readOnly
+          multiline
+          LabelIcon={
+            <div
+              onClick={() => {
+                chrome.tabs.create({
+                  url: 'https://eternis.ai/',
+                });
+              }}
+              className="cursor-pointer"
+            >
+              <InfoCircle />
+            </div>
+          }
+        />
+      )}
 
       <InputField
         label="Notary API"

diff --git a/src/pages/ProofViewer/index.tsx b/src/pages/ProofViewer/index.tsx
@@ -23,11 +23,7 @@ export default function ProofViewer(props?: { proof?: any }): ReactElement {
   useEffect(() => {
     const AttributeAttestation = request?.proof;
     if (!AttributeAttestation) return;
-    if (AttributeAttestation) {
-      setAttributes(attributes);
-    } else {
-      //setSessionData(signedSessionDecoded.response);
-    }
+    else setAttributes(attributes);
   }, [request]);
 
   if (!request?.proof) return <></>;