Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev.ej/tweak publish #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dev.ej/tweak publish #598

wants to merge 1 commit into from

Conversation

joanise
Copy link
Member

@joanise joanise commented Nov 27, 2024

PR Goal?

Fix issues we noticed with the EV publication process yesterday:

  • the tag mismatch was not validated
  • the GitHub release step's name was too long and got truncated

Feedback sought?

regular validation

Priority?

low

Tests added?

no

How to test?

we'll see it in action when we next release

Confidence?

high: the tag validation is adapted from what we do in g2p, and the name is a trivial change.

Copy link

Review changes with  SemanticDiff

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (e3fe86a) to head (e03d7be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files          46       46           
  Lines        3452     3452           
  Branches      470      470           
=======================================
  Hits         2644     2644           
  Misses        706      706           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

CLI load time: 0:00.30
Pull Request HEAD: e03d7be17964c553c1009edd76d10f8ffac3a00a
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       258 |     109137 |   typer
import time:      6478 |     227064 | everyvoice.cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant