Inconsistent behaviour for applyeager concerning indices

[Evizero]

I just noticed sometimes that the fallback gets rid of arbitrary indices while some implementations do not (and instead return a OffsetArray). This should be streamlined

[johnnychen94]

we could add a plain_array to the result of applyeager so that we always get a plain Array. Since it's in eager mode, I believe this is acceptable.

Augmentor.jl/src/operation.jl

Lines 65 to 67 in 6055db7

	function applyeager(op::Operation, img::AbstractArray, param)
	maybe_copy(applylazy(op, img, param))
	end

function applyeager(op::Operation, img::AbstractArray, param) 
-     maybe_copy(applylazy(op, img, param))
+     plain_array(maybe_copy(applylazy(op, img, param)))
end 

[Evizero]

I considered this I am pretty sure. The issue is that the augment function is free to choose if an operation is applied eagerly or lazily. So the indices in eager should match the indices in lazy.

As I see it, propagating arbitrary indices are a feature and not a bug

[johnnychen94]

So the indices in eager should match the indices in lazy.

Cool, I see your point here.

[Evizero]

So the indices in eager should match the indices in lazy

That said. That statement is currently not true (if i remember correctly).
So technically your first label was appropriate for the issue 🐛
I just consider it a bug for a different reason 😅