From 9178bd200fd6e8ccd78ccd0c875a3179922cfb51 Mon Sep 17 00:00:00 2001 From: Carlos Martins <cmartins@expensify.com> Date: Fri, 15 Nov 2024 15:06:08 -0700 Subject: [PATCH] hide pay button --- src/libs/ReportUtils.ts | 6 +++--- src/libs/SearchUIUtils.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index 19cb8c993bc3..97d199374e57 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -54,7 +54,7 @@ import type {Status} from '@src/types/onyx/PersonalDetails'; import type {ConnectionName} from '@src/types/onyx/Policy'; import type {NotificationPreference, Participants, PendingChatMember, Participant as ReportParticipant} from '@src/types/onyx/Report'; import type {Message, OldDotReportAction, ReportActions} from '@src/types/onyx/ReportAction'; -import type {SearchPolicy, SearchReport} from '@src/types/onyx/SearchResults'; +import type {SearchPolicy, SearchReport, SearchTransaction} from '@src/types/onyx/SearchResults'; import type {Comment, TransactionChanges, WaypointCollection} from '@src/types/onyx/Transaction'; import {isEmptyObject} from '@src/types/utils/EmptyObject'; import type IconAsset from '@src/types/utils/IconAsset'; @@ -7746,8 +7746,8 @@ function hasHeldExpenses(iouReportID?: string): boolean { /** * Check if all expenses in the Report are on hold */ -function hasOnlyHeldExpenses(iouReportID: string): boolean { - const reportTransactions = reportsTransactions[iouReportID ?? ''] ?? []; +function hasOnlyHeldExpenses(iouReportID: string, allReportTransactions?: SearchTransaction[]): boolean { + const reportTransactions = allReportTransactions ?? reportsTransactions[iouReportID ?? ''] ?? []; return reportTransactions.length > 0 && !reportTransactions.some((transaction) => !TransactionUtils.isOnHold(transaction)); } diff --git a/src/libs/SearchUIUtils.ts b/src/libs/SearchUIUtils.ts index 70b4de84e775..50389f246a63 100644 --- a/src/libs/SearchUIUtils.ts +++ b/src/libs/SearchUIUtils.ts @@ -282,7 +282,7 @@ function getAction(data: OnyxTypes.SearchResults['data'], key: string): SearchTr ? Object.entries(data) .filter(([itemKey, value]) => isTransactionEntry(itemKey) && (value as SearchTransaction)?.reportID === report.reportID) .map((item) => item[1]) - : [] + : [transaction] ) as SearchTransaction[]; const chatReport = data[`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`] ?? {};