From 85a90be2a72f20f1cbd472a055d19c51409fb189 Mon Sep 17 00:00:00 2001 From: Jon Dubielzyk Date: Wed, 14 Feb 2024 19:42:16 +1000 Subject: [PATCH 1/3] Tweaking bubble icons and changing comment action menu --- assets/images/chatbubble-reply.svg | 13 +++++++++++++ assets/images/chatbubble-unread.svg | 13 ++++++++++++- src/components/Icon/Expensicons.ts | 2 ++ .../home/report/ContextMenu/ContextMenuActions.tsx | 2 +- 4 files changed, 28 insertions(+), 2 deletions(-) create mode 100644 assets/images/chatbubble-reply.svg diff --git a/assets/images/chatbubble-reply.svg b/assets/images/chatbubble-reply.svg new file mode 100644 index 000000000000..bbc2642baae0 --- /dev/null +++ b/assets/images/chatbubble-reply.svg @@ -0,0 +1,13 @@ + + + + + + diff --git a/assets/images/chatbubble-unread.svg b/assets/images/chatbubble-unread.svg index 492616cf2ab5..c0eec29ccedb 100644 --- a/assets/images/chatbubble-unread.svg +++ b/assets/images/chatbubble-unread.svg @@ -1 +1,12 @@ - \ No newline at end of file + + + + + + diff --git a/src/components/Icon/Expensicons.ts b/src/components/Icon/Expensicons.ts index 252d13259aea..405cde33b49c 100644 --- a/src/components/Icon/Expensicons.ts +++ b/src/components/Icon/Expensicons.ts @@ -29,6 +29,7 @@ import CardsAndDomains from '@assets/images/cards-and-domains.svg'; import Cash from '@assets/images/cash.svg'; import Chair from '@assets/images/chair.svg'; import ChatBubbleAdd from '@assets/images/chatbubble-add.svg'; +import ChatBubbleReply from '@assets/images/chatbubble-reply.svg'; import ChatBubbleUnread from '@assets/images/chatbubble-unread.svg'; import ChatBubble from '@assets/images/chatbubble.svg'; import ChatBubbles from '@assets/images/chatbubbles.svg'; @@ -280,4 +281,5 @@ export { Instagram, ChatBubbleAdd, ChatBubbleUnread, + ChatBubbleReply }; diff --git a/src/pages/home/report/ContextMenu/ContextMenuActions.tsx b/src/pages/home/report/ContextMenu/ContextMenuActions.tsx index 64a7d1813255..219cf6bc5e01 100644 --- a/src/pages/home/report/ContextMenu/ContextMenuActions.tsx +++ b/src/pages/home/report/ContextMenu/ContextMenuActions.tsx @@ -180,7 +180,7 @@ const ContextMenuActions: ContextMenuAction[] = [ { isAnonymousAction: false, textTranslateKey: 'reportActionContextMenu.replyInThread', - icon: Expensicons.ChatBubbleAdd, + icon: Expensicons.ChatBubbleReply, shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID) => { if (type !== CONST.CONTEXT_MENU_TYPES.REPORT_ACTION) { return false; From dc41d6a888bc1e4d9b000364be0bb4455fd99e2f Mon Sep 17 00:00:00 2001 From: Jon Dubielzyk Date: Wed, 14 Feb 2024 20:19:12 +1000 Subject: [PATCH 2/3] Tweak to icons --- assets/images/chatbubble-add.svg | 11 ++++++++++- assets/images/chatbubble-reply.svg | 15 ++++++--------- assets/images/chatbubble-unread.svg | 11 ++++------- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/assets/images/chatbubble-add.svg b/assets/images/chatbubble-add.svg index 48eebf863cc3..3e2c270d681c 100644 --- a/assets/images/chatbubble-add.svg +++ b/assets/images/chatbubble-add.svg @@ -1 +1,10 @@ - \ No newline at end of file + + + + + diff --git a/assets/images/chatbubble-reply.svg b/assets/images/chatbubble-reply.svg index bbc2642baae0..f8d53ebff807 100644 --- a/assets/images/chatbubble-reply.svg +++ b/assets/images/chatbubble-reply.svg @@ -1,13 +1,10 @@ - - + viewBox="0 0 20 20" enable-background="new 0 0 20 20" xml:space="preserve"> + diff --git a/assets/images/chatbubble-unread.svg b/assets/images/chatbubble-unread.svg index c0eec29ccedb..f5a27a74f5fe 100644 --- a/assets/images/chatbubble-unread.svg +++ b/assets/images/chatbubble-unread.svg @@ -1,12 +1,9 @@ - - + From dad5cd741f78409e2b0263c71b2c3e8b792d8a6a Mon Sep 17 00:00:00 2001 From: Jon Dubielzyk <145416827+dubielzyk-expensify@users.noreply.github.com> Date: Mon, 19 Feb 2024 12:14:37 +1000 Subject: [PATCH 3/3] Add comma for linting Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np> --- src/components/Icon/Expensicons.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Icon/Expensicons.ts b/src/components/Icon/Expensicons.ts index 405cde33b49c..8005e5f2daf0 100644 --- a/src/components/Icon/Expensicons.ts +++ b/src/components/Icon/Expensicons.ts @@ -281,5 +281,5 @@ export { Instagram, ChatBubbleAdd, ChatBubbleUnread, - ChatBubbleReply + ChatBubbleReply, };