Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-11-22] [$500] mWeb - Request Money- Missing cursor when requesting/split the money #10693

Closed
kavimuru opened this issue Aug 30, 2022 · 66 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@kavimuru
Copy link

kavimuru commented Aug 30, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing #10147

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Click FAB > Request Money
  4. Enter an amount
  5. Move cursor to the middle of the amount
    5.1. Enter a Digit
    5.2. Delete a digit
    5.3. Paste a couple of digits
    5.4. Cut a couple of digits

Expected Result:

Cursor should be present when requesting/split the money

Actual Result:

Missing cursor when requesting/split the money

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web (Android)

Version Number: 1.1.94.4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5710804_10147_Mweb.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@yuwenmemon yuwenmemon removed their assignment Aug 31, 2022
@yuwenmemon yuwenmemon added Weekly KSv2 Improvement Item broken or needs improvement. External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Aug 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2022

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 31, 2022
@adelekennedy
Copy link

internal
external

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2022

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title mWeb - Request Money- Missing cursor when requesting/split the money [$250] mWeb - Request Money- Missing cursor when requesting/split the money Aug 31, 2022
@AndrewGable
Copy link
Contributor

This is a regression from #6154 - I believe @eVoloshchak should fix this.

@rushatgabhane
Copy link
Member

rushatgabhane commented Aug 31, 2022

@AndrewGable not really. This issue was present before the PR

I looked into solving it during 6154 PR, and i believe a fix for it is out of scope of the PR

@trjExpensify
Copy link
Contributor

I'm also a bit confused by the steps in the OP versus the video. Something isn't clear, because I can see the cursor in the video? 😕

I also can't seem to reproduce it, if that's the problem as stated.

RPReplay_Final1661934698.MP4

@rushatgabhane
Copy link
Member

@trjExpensify I think this is a mWeb - Android only issue

@trjExpensify
Copy link
Contributor

Oh, I see. @kavimuru can you confirm that, please?

@adelekennedy
Copy link

my first checklist!

@rushatgabhane
Copy link
Member

The PR that introduced the bug has been identified

I believe the cursor always went away after pressing the IOU numpad. This bug was always present, and not a regression

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 15, 2022
@melvin-bot melvin-bot bot changed the title [$500] mWeb - Request Money- Missing cursor when requesting/split the money [HOLD for payment 2022-11-22] [$500] mWeb - Request Money- Missing cursor when requesting/split the money Nov 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 15, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.27-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-11-22. 🎊

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 25, 2022

@rushatgabhane, @thienlnam, @adelekennedy, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

@rushatgabhane, @thienlnam, @adelekennedy, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@thienlnam
Copy link
Contributor

thienlnam commented Nov 29, 2022

I added a link to the potential offending PR but it's from way back - #10147

cc @adelekennedy Are you able to take care of the other items on the checklist please? This looks ready to pay out as well #10693 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2022
@rushatgabhane
Copy link
Member

rushatgabhane commented Nov 29, 2022

@thienlnam the issue existed before #10147, this bug was always present

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2022
@adelekennedy
Copy link

Hired!

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2022
@aimane-chnaif
Copy link
Contributor

@thienlnam agreed timeline bonus (#12498 (comment))

@thienlnam thienlnam reopened this Dec 5, 2022
@thienlnam
Copy link
Contributor

Yeah, this PR should still be eligible for the 50% bonus - my bad should have clarified in this issue. Going to reopen so that can get taken care of

@aimane-chnaif
Copy link
Contributor

@adelekennedy I see you made 2 offers and closed old one after pay out.
I think you can use the new one hired last Friday for bonus.

@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2022

@rushatgabhane, @thienlnam, @adelekennedy, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2022
@thienlnam
Copy link
Contributor

cc @adelekennedy for adding the bonus payment

@melvin-bot melvin-bot bot removed the Overdue label Dec 8, 2022
@adelekennedy
Copy link

Bonuses paid out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests