Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecated set-output commands in GitHub Actions #11877

Closed
roryabraham opened this issue Oct 15, 2022 · 13 comments
Closed

Get rid of deprecated set-output commands in GitHub Actions #11877

roryabraham opened this issue Oct 15, 2022 · 13 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

Problem

GitHub deprecated the set-output command in workflows, and they will "soon be disabled".

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://github.com/Expensify/App/actions/runs/3252739822/jobs/5339300870

Why is this important?

These were deprecated for security reasons, and if we don't update our workflows then they will stop working soon.

Solution

Update to using the new environment files.

@roryabraham roryabraham added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task labels Oct 15, 2022
@roryabraham roryabraham self-assigned this Oct 15, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2022
@roryabraham
Copy link
Contributor Author

Got a PR up for most of our usages of set-output, but not necessarily all the usages in the community actions we're using.

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2022
@roryabraham roryabraham added the Reviewing Has a PR in review label Oct 18, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2022

@roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot closed this as completed Oct 25, 2022
@roryabraham roryabraham reopened this Nov 2, 2022
@roryabraham
Copy link
Contributor Author

Reopening to continue migrating community actions.

@roryabraham roryabraham added Weekly KSv2 and removed Reviewing Has a PR in review Daily KSv2 labels Nov 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 2, 2022

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

  • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
  • The PR that introduced the bug has been identified. Link to the PR:
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • Payment has been made to the issue reporter (if applicable)
  • Payment has been made to the contributor that fixed the issue (if applicable)
  • Payment has been made to the contributor+ that helped on the issue (if applicable)

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Nov 2, 2022

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

  • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
  • The PR that introduced the bug has been identified. Link to the PR:
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • Payment has been made to the issue reporter (if applicable)
  • Payment has been made to the contributor that fixed the issue (if applicable)
  • Payment has been made to the contributor+ that helped on the issue (if applicable)

@roryabraham
Copy link
Contributor Author

The Bug0 checklist is safe to ignore here I think. Was just doing a migration forced by GitHub

@laurenreidexpensify laurenreidexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 3, 2022
@miljakljajic
Copy link
Contributor

What action should I take here, sorry?

@roryabraham
Copy link
Contributor Author

This is not a bug, going to remove you and the bug label

@roryabraham roryabraham removed the Bug Something is broken. Auto assigns a BugZero manager. label Nov 9, 2022
@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Nov 9, 2022
@roryabraham
Copy link
Contributor Author

tspascoal/get-user-teams-membership is an outdated action I need to migrate. Probably will just replace it with the GH cli

@roryabraham
Copy link
Contributor Author

Anyone can continue working on this, but I'm not going to prioritize it right now. Adding it to the tracking issue and dropping it for now.

@fukawi2
Copy link
Contributor

fukawi2 commented Jun 1, 2023

Looks like this has all been done now:

phs ~/Expensidev [main !?] $ grep -RH ::set-output */.github
phs ~/Expensidev [main !?] $

@fukawi2
Copy link
Contributor

fukawi2 commented Jun 1, 2023

Reassigning to @roryabraham since he did most of the work by the look of it, so credit due.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants