[Hold #15212][$1000] Web - New marker does not go away when Report is automatically marked as read

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a chat with history;
2. Mark any message as unread;
3. Refresh the page OR switch the tab and come back;
4. On left, see that the report has been marked as read, but the New marker is still visible;
5. Repeat Step 3;
6. See that the New marker did go away the second time.

Expected Result:

The New marker should go away the first time.

Actual Result:

The New marker goes away the second time.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

marker_twice.mp4

Recording.3310.mp4

Expensify/Expensify Issue URL:
Issue reported by: @DanutGavrus
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687948133361189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0107af640eb3758e2b
• Upwork Job ID: 1675894728590426112
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New marker does not go away when Report is automatically marked as read

What is the root cause of that problem?

1. In ReportActionsView.js, if we switch the chrome tab and come back, or refresh the current tab, the report's lastReadTime updates to a new value;
2. In ReportUtils.js, the method isUnread does return lastReadTime < lastVisibleActionCreated, so it would retun false;
3. But, in ReportActionsView.js inside componentDidUpdate, we do not check if the report automatically became read in order to clear this.state.newMarkerReportActionID.

What changes do you think we should make in order to solve the problem?

We should add this logic:

if (!ReportUtils.isUnread(this.props.report) && this.state.newMarkerReportActionID != '') {
    this.setState({
        newMarkerReportActionID: '',
    });
}

inside componentDidUpdate in ReportActionsView.js.

[mollfpr]

@sonialiap please hold triaging this. I will try investigating this, maybe can be solved by #21557.

[mollfpr]

@sonialiap It's okay now to triage this. We have different root causes for the issue in the PR above. Thank you!

[sonialiap]

The unread line remains for me in both scenarios. Maybe it's some general delay with the page updating?

Screen.Recording.2023-07-03.at.5.48.05.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0107af640eb3758e2b

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

@sonialiap I think this should be hold for #15212

[hwakstar]

Hello
I checked your job description and I am sure that can solve it.
I hope that work with you.
Warm regards

[melvin-bot]

📣 @hwakstar! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[DanutGavrus]

@fedirjh Should we ask on Slack about holding this one for 15212?

I'm asking as 20759 was recently completed instead of also being held and seems related.

Thanks!

[coeur85]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/magdi

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[fedirjh]

I'm asking as #20759 was recently completed instead of also being held and seems related.

There is an tracker issue for all unread marker issue, and all related issues, should be added to it. It doesn’t make sense to proceed with solution while we are working on a refactor.

[DanutGavrus]

There is an tracker issue for all unread marker issue, and all related issues, should be added to it. It doesn’t make sense to proceed with solution while we are working on a refactor.

Ok, I understand, thanks!

[hwakstar]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0184d3368b71c2b81c

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[hwakstar]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0184d3368b71c2b81c

[sonialiap]

PR for #15212 is super close to being approved and merged, exciting! Hopefully soon we'll be able to re-test this one and either close or look for proposals

[sonialiap]

PR for #15212 is close but not yet merged. Waiting

[sonialiap]

Waiting for #25935 to test this again

[MonilBhavsar]

Expected Result: The New marker should go away the first time.

When marking the message as unread manually, the new marker should go second time.

That said, this issue should be fixed. We can retest and most probably close it

[fedirjh]

When marking the message as unread manually, the new marker should go second time.

@MonilBhavsar I just retested and found that :

• When refreshing the report, the New marker goes away the first time and the report is marked as read in LHN.
• When switching between tabs, the new marker is not dismissed and the report is still marked as unread in LHN (displayed as bold).

is that expected?

CleanShot.2023-11-21.at.18.51.32.mp4

[sonialiap]

@MonilBhavsar bumping Fedi's question, do you know the answer?

[MonilBhavsar]

Sorry, missed it

When marking the message as unread manually, the new marker should go second time.

@MonilBhavsar I just retested and found that :

• When refreshing the report, the New marker goes away the first time and the report is marked as read in LHN.
• When switching between tabs, the new marker is not dismissed and the report is still marked as unread in LHN (displayed as bold).

is that expected?

CleanShot.2023-11-21.at.18.51.32.mp4

I would say it is expected. When refreshing the page, the entire component is remounted losing the marker state. We do not store marker data in local storage or Onyx DB, and also OpenApp and OpenReport updates the lastReadTime. To persist unread data between refresh is out of scope and the losing of marker during refresh is expected

[sonialiap]

@fedirjh sounds like we still have an issue here and need proposals, is that correct?

[fedirjh]

sounds like we still have an issue here and need proposals, is that correct?

@sonialiap I think refreshing the report marks the report as unread , that's expected and that fine. Additionally, I would expect that switching between tabs should also mark the report as read. What are your thoughts @MonilBhavsar ?

If we should not mark the report as unread when switching between tabs (or when the app goes into the background), then I believe everything is working as expected, and we can consider closing this issue.

[MonilBhavsar]

As per the design, we should not remove marker when user switches the tab. For the refresh I think it is fine as the components are remounted.

[fedirjh]

That looks good , I think this can be closed.

[fedirjh]

In case a regression test is required :

Regression Test Proposal

1. Open a chat with history
2. Mark any message as unread
3. Refresh the page
4. Verify that the report has been marked as read on LHN and New marker did go away
5. Repeat Step 2
6. Switch the tab and come back
7. Verify that the report is still marked as unread on LHN and New marker is still visible inside the report

• Do we agree 👍 or 👎