Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-09] 🟡 Editing distance requests in App #22715

Closed
neil-marcellini opened this issue Jul 11, 2023 · 20 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Jul 11, 2023

- HELD on #22713

Please follow the plan in the design doc: Edit in App.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0136e127650fd78aa6
  • Upwork Job ID: 1712170898351742976
  • Last Price Increase: 2023-10-11
@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@arosiclair
Copy link
Contributor

Held on creating requests. I'll drop this to weekly for the time being.

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@arosiclair arosiclair added Weekly KSv2 and removed Daily KSv2 labels Jul 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@arosiclair
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 4, 2023
@arosiclair
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@arosiclair
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@tgolen tgolen changed the title [HOLD 22713] Editing distance requests in App Editing distance requests in App Aug 23, 2023
@tgolen
Copy link
Contributor

tgolen commented Aug 23, 2023

Off HOLD

@tgolen tgolen added Daily KSv2 and removed Weekly KSv2 labels Aug 23, 2023
@jasperhuangg
Copy link
Contributor

jasperhuangg commented Aug 25, 2023

It seems the front-end for this needs the changes from #25707 in order to be implemented

I will pull that branch and start a draft PR with it

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@jasperhuangg
Copy link
Contributor

Having some local changes for this that I'm looking to submit for review today!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 2, 2023
@melvin-bot melvin-bot bot changed the title 🟡 Editing distance requests in App [HOLD for payment 2023-10-09] 🟡 Editing distance requests in App Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 Daily KSv2 Overdue labels Oct 9, 2023
@tgolen tgolen added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Expensify Expensify deleted a comment from melvin-bot bot Oct 11, 2023
@tgolen
Copy link
Contributor

tgolen commented Oct 11, 2023

@trjExpensify Could you help me wrap up payment for this? I believe @fedirjh needs to be paid as a C+ for reviewing the PR.

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2023
@trjExpensify trjExpensify added the Internal Requires API changes or must be handled by Expensify staff label Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0136e127650fd78aa6

@melvin-bot

This comment was marked as resolved.

@trjExpensify trjExpensify assigned fedirjh and unassigned sobitneupane Oct 11, 2023
@trjExpensify
Copy link
Contributor

Cool, cool. @fedirjh I've sent you an offer for a flat $1k for the PR review. (Old bounty level, prior to the change at the start of Sept).

@fedirjh
Copy link
Contributor

fedirjh commented Oct 11, 2023

@trjExpensify Accepted! Thank you.

@trjExpensify
Copy link
Contributor

Paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

7 participants