[HOLD for payment 2023-11-01] [HOLD on PR #25935] [$1000] Two line markers appear for a second

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a task
2. Send two messages
3. Mark as Unread the second message
4. delete the first message

Expected Result:

The new line marker and the message separating the line align immediately

Actual Result:

Two line markers appear for a second

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.54-11
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T102_Twolinemarkers-1.mp4

Recording.370.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691459749715329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0110cb0187ff6d5cbd
• Upwork Job ID: 1692133559512989696
• Last Price Increase: 2023-08-17
• Automatic offers:
• dukenv0307 | Contributor | 26245331
• daveSeife | Reporter | 26245335

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Two line markers appear for a second

What is the root cause of that problem?

When we online, the reportAction with pendingAction as delete still keeps on sortedReportActions.

So when we delete the first comment, the sortedReportActions[sortedReportActions.length - 2] action still is this action. That makes shouldHideThreadDividerLine doesn't update to true and then two dividers appear until deleteComment API is complete.

App/src/pages/home/report/ReportActionsList.js

Line 128 in e043331

const shouldHideThreadDividerLine = sortedReportActions.length > 1 && sortedReportActions[sortedReportActions.length - 2].reportActionID === newMarkerReportActionID;

What changes do you think we should make in order to solve the problem?

We should get the firstVisibleAction that doesn't have pendingAction is delete to compare with newMarkerReportActionID

function getFirstVisibleAction(sortedReportActions, isOffline) {
    for (let i = sortedReportActions.length - 2; i >= 0; i--) {
        if ((sortedReportActions[i].pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) || isOffline) {
            return sortedReportActions[i];
        }
    }
    return null;
}

const firstVisibleAction = getFirstVisibleAction(sortedReportActions, props.network.isOffline);

const shouldHideThreadDividerLine = sortedReportActions.length > 1 && !!firstVisibleAction && firstVisibleAction.reportActionID === newMarkerReportActionID;

App/src/pages/home/report/ReportActionsList.js

Line 128 in e043331

const shouldHideThreadDividerLine = sortedReportActions.length > 1 && sortedReportActions[sortedReportActions.length - 2].reportActionID === newMarkerReportActionID;

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.17-08-2023.11.25.06.webm

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Two line markers appear for a second

What is the root cause of that problem?

When removing the message, this message isn't remove from sortedReportActions until the BE return new data. It caused that 2 divider lines are displayed at the same time.
But we can't see this issue on thread chat because in thread chat the new marker and divider line have the same position, the new marker line will overwrite the divider line
in the task report and money report view, we apply margin vertical 8px to divider line

App/src/styles/styles.js

Line 3537 in 0bdf183

...spacing.mv2,

It make the position of the new marker line and the divider line different.

What changes do you think we should make in order to solve the problem?

In the task report and money report view, I suggest that we should remove margin (as we did in thread chat) vertical or only use margin top in the divider line
This solution also make report action not flicker when mark as unread

Result

Screen.Recording.2023-08-17.at.17.17.26.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0110cb0187ff6d5cbd

[melvin-bot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[garrettmknight]

Reproduced on staging and prod.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Two line markers appear for a second

What is the root cause of that problem?

after deleting the first comment here its changed to sortedReportActions[sortedReportActions.length - 2].pendingAction = 'delete' until delete api finishes at the time reportActionID === newMarkerReportActionID also doesn't match that why showing the line at the time shouldDisplayNewMarker also true

App/src/pages/home/report/ReportActionsList.js

Line 128 in e043331

const shouldHideThreadDividerLine = sortedReportActions.length > 1 && sortedReportActions[sortedReportActions.length - 2].reportActionID === newMarkerReportActionID;

What changes do you think we should make in order to solve the problem?

    const findFirstSortedReportActions = () => {
        const sortedReportActionsFilter = sortedReportActions.filter(item => props.network.isOffline || item.pendingAction != 
           CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
        return  sortedReportActionsFilter.length > 1 && sortedReportActionsFilter[sortedReportActionsFilter.length - 2] || {};
    }
     const shouldHideThreadDividerLine = findFirstSortedReportActions().reportActionID === newMarkerReportActionID 

[parasharrajat]

@dukenv0307 Can you help me visualize the flow of the solution?

[dukenv0307]

@parasharrajat As the root cause I mentioned, because the action that has pendingAction is delete keep on sortedActions, so we should find the current first action that is visible in the screen to compare with newMarkerReportActionID. I also can update the check to get the first action to cover the case the action has childAction comment.

[pradeepmdk]

@parasharrajat, let me know what is the mistake I am done. updated to #24648 (comment)

[parasharrajat]

@pradeepmdk There is no mistake as such but your proposal matches one of the existing proposals.

[pradeepmdk]

@parasharrajat Sorry, I missed that before the help+wanted label posted the proposals. so I missed that.

[parasharrajat]

Ok, @dukenv0307 let's simplify your logic on the PR. But proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@garrettmknight, @yuwenmemon, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[garrettmknight]

@dukenv0307 do you need anything else from us to get the PR up?

[melvin-bot]

This issue has not been updated in over 15 days. @garrettmknight, @parasharrajat, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[garrettmknight]

@dukenv0307 I just tested this and it's performing a bit differently, with the line below the first message. Mind giving this one another look?

[dukenv0307]

@garrettmknight It comes from another PR. We still waiting for #25935 this PR is merged to continue this issue.

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @dukenv0307 got assigned: 2023-08-21 17:24:44 Z
• when the PR got merged: 2023-10-23 16:32:33 UTC
• days elapsed: 44

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Two line markers appear for a second #25554

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @dukenv0307 requires payment offer (Contributor)
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Summarizing payments for this issue:

• Urgency bonus: No
• Reveiwer: @parasharrajat $1000
• Contributor: @dukenv0307 $1000 paid via Upwork
• Reporter: @daveSeife $250 paid via Upwork

Upwork job: https://www.upwork.com/jobs/~0110cb0187ff6d5cbd

[garrettmknight]

@parasharrajat please submit payment once you've completed the checklist

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Fix: New tagline after marking as unread have overlapping line #19658
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/19658/files#r1379656462
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No, this wasn't caught in testing.
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Create a task
2. Send two messages on the task report.
3. Mark as Unread the second message
4. Delete the first message
5. Verify that only one marker (unread maker ) appear

Do you agree 👍 or 👎 ?

[parasharrajat]

Payment requested as per #24648 (comment)

[JmillsExpensify]

$1,000 payment approved for @parasharrajat based on summary above.

[garrettmknight]

Closing