Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'Localize' lib to TypeScript #24919

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 9 comments
Closed

[TS migration] Migrate 'Localize' lib to TypeScript #24919

melvin-bot bot opened this issue Aug 16, 2023 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/Localize/index.js 10
src/libs/Localize/LocaleListener/index.js 1
src/libs/Localize/LocaleListener/index.desktop.js 2
src/libs/Localize/LocaleListener/BaseLocaleListener.js 3
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link
Author

melvin-bot bot commented Nov 3, 2023

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link
Author

melvin-bot bot commented Nov 7, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
@getusha
Copy link
Contributor

getusha commented Nov 9, 2023

Can i get assigned on this one for payment?

@arosiclair arosiclair added Bug Something is broken. Auto assigns a BugZero manager. and removed Reviewing Has a PR in review labels Nov 9, 2023
Copy link
Author

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 9, 2023

This comment was marked as off-topic.

@arosiclair
Copy link
Contributor

@bfitzexpensify can you handle payment for @getusha's C+ review on this PR?

@bfitzexpensify
Copy link
Contributor

All done

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants