-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: Delay in removing 'New' marker After deleting newly sent message #25606
Comments
Triggered auto assignment to @stephanieelliott ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @hayata-suenaga ( |
on it now. Testing if this bug is already on production (i.e. checking if this is actually a deploy blocker). |
okay I cannot re-produce this on production. If this issue is present on staging, then this is a deploy blocker. Screen.Recording.2023-08-21.at.11.22.41.AM.mov |
you can reproduce it on DEV |
my dev env is not working well, but I gonna ask in #expensify-open-source channel to see if anyone made changes recently that might have caused this regression. |
asked here |
This PR might be related. Asked in that PR. |
not reproducible on staging, so not a deploy blocker. May be a deploy blocker tomorrow though, so leaving this as an hourly issue @hayata-suenaga |
yea that's only on dev. I was wondering if the issue should be deploy blocker if it only exists on dev (main). Thank you for letting me know |
this can be fixed by adding aditiional check |
I'm decreasing the priority here |
Hey I will be taking care of this, as part of our Unread Marker refactor The issue is, we were observing the I will be adding that case |
I assign you to this issue then @gedu |
Work ongoing in #23171 |
Still working in #23171 |
#23171 still open |
Still working in #23171 |
#23171 still ongoing |
Still working in #23171 |
#23171 still ongoing |
Still working in #23171 |
1 similar comment
Still working in #23171 |
I will review it too |
Can not reproduce it. Screen.Recording.2023-11-27.at.10.52.10.mp4 |
compared with the video in the original issue, the problem seems to have been fixed. We can close this. Do we need any payment @stephanieelliott ? |
Great! No payment due here as work was done by a Callstack expert contrib. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
New marker should be removed when deleting new sent message
Actual Result:
New marker not removed when deleting new sent message
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: Dev
Reproducible in staging?: Dev
Reproducible in production?: Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-recording-2023-08-18-at-20915-am_ByAuGnth.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692306828126859
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: