Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Delay in removing 'New' marker After deleting newly sent message #25606

Closed
1 of 6 tasks
kavimuru opened this issue Aug 21, 2023 · 30 comments
Closed
1 of 6 tasks

Dev: Delay in removing 'New' marker After deleting newly sent message #25606

kavimuru opened this issue Aug 21, 2023 · 30 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat 

  2. Send a message
  3. 
Click on “Mark as unread”
  4. Now delete the message

  5. Notice new marker not removed with message

Expected Result:

New marker should be removed when deleting new sent message

Actual Result:

New marker not removed when deleting new sent message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev
Reproducible in staging?: Dev
Reproducible in production?: Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-18-at-20915-am_ByAuGnth.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692306828126859

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Aug 21, 2023

on it now. Testing if this bug is already on production (i.e. checking if this is actually a deploy blocker).

@hayata-suenaga
Copy link
Contributor

okay I cannot re-produce this on production. If this issue is present on staging, then this is a deploy blocker.

Screen.Recording.2023-08-21.at.11.22.41.AM.mov

@ayazhussain79
Copy link
Contributor

you can reproduce it on DEV

@hayata-suenaga
Copy link
Contributor

my dev env is not working well, but I gonna ask in #expensify-open-source channel to see if anyone made changes recently that might have caused this regression.

@hayata-suenaga
Copy link
Contributor

asked here

@hayata-suenaga
Copy link
Contributor

This PR might be related. Asked in that PR.

@roryabraham
Copy link
Contributor

roryabraham commented Aug 21, 2023

not reproducible on staging, so not a deploy blocker. May be a deploy blocker tomorrow though, so leaving this as an hourly issue @hayata-suenaga

@hayata-suenaga
Copy link
Contributor

yea that's only on dev. I was wondering if the issue should be deploy blocker if it only exists on dev (main). Thank you for letting me know

@getusha
Copy link
Contributor

getusha commented Aug 21, 2023

this can be fixed by adding aditiional check reportAction.pendingActions !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) inside ReportActionList while passing shouldDisplayNewMarker or inside ReportActionItem alongside props.shouldDisplayNewMarker && but it's hard to tell why it was working previously since it's a refactor which changed the logic entirely with new approach.

@tgolen tgolen added Daily KSv2 and removed Hourly KSv2 labels Aug 22, 2023
@tgolen
Copy link
Contributor

tgolen commented Aug 22, 2023

I'm decreasing the priority here

@gedu
Copy link
Contributor

gedu commented Aug 22, 2023

Hey I will be taking care of this, as part of our Unread Marker refactor

The issue is, we were observing the reportActions size, when it changes we try to update the marker, but now deleting a reportAction don't reduce the size of the list, it marks the pendingActions to delete

I will be adding that case

@hayata-suenaga
Copy link
Contributor

I assign you to this issue then @gedu

@stephanieelliott
Copy link
Contributor

Thanks @gedu! I'm going to put a Weekly label on this in that case, anyone looking for more frequent updates can look to the master issue #23171

@stephanieelliott stephanieelliott added Weekly KSv2 and removed Daily KSv2 labels Aug 22, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 23, 2023
@stephanieelliott
Copy link
Contributor

Work ongoing in #23171

@stephanieelliott
Copy link
Contributor

Still working in #23171

@stephanieelliott
Copy link
Contributor

#23171 still open

@stephanieelliott
Copy link
Contributor

Still working in #23171

@stephanieelliott
Copy link
Contributor

#23171 still ongoing

@stephanieelliott
Copy link
Contributor

Still working in #23171

@stephanieelliott
Copy link
Contributor

#23171 still ongoing

@stephanieelliott
Copy link
Contributor

Still working in #23171

1 similar comment
@stephanieelliott
Copy link
Contributor

Still working in #23171

@gedu
Copy link
Contributor

gedu commented Nov 27, 2023

I will review it too

@gedu
Copy link
Contributor

gedu commented Nov 27, 2023

Can not reproduce it.
I'm seeing just an small delay but correspond with the re-render and the list sorting.

Screen.Recording.2023-11-27.at.10.52.10.mp4

@hayata-suenaga
Copy link
Contributor

compared with the video in the original issue, the problem seems to have been fixed. We can close this. Do we need any payment @stephanieelliott ?

@stephanieelliott
Copy link
Contributor

Great! No payment due here as work was done by a Callstack expert contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants