-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - New line marker on Task does not disappear when sending or receiving a message #25776
Comments
Triggered auto assignment to @kadiealexander ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @tgolen ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.New line marker on Task does not disappear when sending or receiving a message What is the root cause of that problem?Let's see the optimistic report here, we set App/src/libs/actions/Report.js Lines 259 to 265 in ebb6d33
That makes
What changes do you think we should make in order to solve the problem?We should update the Line 2466 in 5d1d5f1
What alternative solutions did you explore? (Optional) |
@dukenv0307 Thank you so much for looking into this. Were you by any chance able to find what caused this regression to happen? |
@tgolen I think this happens after we refactor unread marker here https://github.com/Expensify/App/pull/18637/files |
Before refactoring, if we add a comment we will clear the unread marker and scroll to bottom. |
Ah, yes. That looks to be it. I haven't been familiar with this code in a long time. I am concerned that the solution that you propose could have other potential side-effects that we don't know about. What is your gauge on how risky of a change it is to do I'm also considering that we should revert that refactoring PR as it seemed tied to several regressions. |
I think we should revert the PR |
Yeah, I mostly agree with you. It sounds like there have been a couple of follow-up PRs to fix other blockers from it that would also need to be reverted, so we are evaluating now what kind of a mess we are in and how best to get out of it. |
All right, we have decided to revert the original PR for now. It turned out there were no other post-fixes that needed reverting. |
Discussion was in slack |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
According to @MonilBhavsar, this is expected behavior, not a 🐛 Closing this out. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
New line marker should disappear when receiving a message or sending a message
Actual Result:
New line marker does not disappear when receiving a message or sending a message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.56-18
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
T121.Newlinemarker-1.mp4
Recording.1299.mp4
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692752785781209
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: