[HOLD for payment 2024-01-31] [$1000] Workspace - "You appear to be offline" page not showing after tap on "Continue with setup"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Pre-requisite: user must be logged in, initiated a bank account setup with Plaid using Wells Fargo credentials until the "Beneficial owners" step

1. Fill out the form for an additional beneficial owner
2. Disable the internet connection
3. Go back to LHN
4. Tap on profile avatar in top right corner
5. Tap on "Workspaces"
6. Tap on the same workspace the bank account setup was initiated
7. Tap on "Bank account".\
8. Tap on "Continue with setup"

Expected Result:

User should see a full page blocking view saying "You appear to be offline"

Actual Result:

The page view changes as if the setup process was restarted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6183203_Jitx1956_1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1c9b22a350eb5fe
• Upwork Job ID: 1698613293423120384
• Last Price Increase: 2023-10-03

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1c9b22a350eb5fe

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On offline mode, bank account form loses its data as if the setup process was restarted

What is the root cause of that problem?

When user leaves the bank account form page (or refresh), component removes the reimbursement account data from store:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 188 to 190 in 60576fe

	componentWillUnmount() {
	BankAccounts.clearReimbursementAccount();
	}

What changes do you think we should make in order to solve the problem?

If we want to keep the data intact even in offline mode, we should keep in the store by removing the componentWillUnmount life cycle.

    // Remove these lines
    // componentWillUnmount() {
    //     BankAccounts.clearReimbursementAccount();
    // }

This is because the form relies on the reimbursementAccount data as we can see from these lines:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 237 to 238 in 60576fe

	const achData = lodashGet(this.props.reimbursementAccount, 'achData', {});
	return achData.state === BankAccount.STATE.PENDING || _.contains([CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT, ''], this.getStepToOpenFromRouteParams());

What alternative solutions did you explore? (Optional)

N/A

[zukilover]

@situchan Please let me know if that above proposal works for you. Thanks.

[laurenreidexpensify]

bump @situchan for review

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@laurenreidexpensify, @situchan Eep! 4 days overdue now. Issues have feelings too...

[laurenreidexpensify]

@situchan bump ^

[laurenreidexpensify]

@situchan bump thanks

[situchan]

@zukilover thanks for the proposal. Can you please share 2 videos (before fix and after fix)?

Screen.Recording.2023-09-14.at.4.09.28.PM.mov

I am not able to reproduce though.

[zukilover]

Hi @situchan You need to follow the exact reproduction steps.
You need to select Connect with Plaid, until step 3, then set to offline.

Here's the before/after videos:

Before:
bank-account-setup-before.webm

After:
bank-account-setup-after.webm

[zukilover]

New findings on this bug:

When you're offline, clicking on the bank account may trigger the blocking offline view. But as soon as you click on the header back button, you can navigate through the steps without the offline blocking view.

See this video:
bank-account-step.webm

I think, we need to add offline blocking view to each of the steps for a consistent behavior.

[zukilover]

Proposal

Updated

[melvin-bot]

@laurenreidexpensify @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@laurenreidexpensify, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[bernhardoj]

PR is ready

cc: @situchan

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix bank account page shows the start page when pressing "Continue with setup" while offline #34124

If no regressions arise, payment will be issued on 2024-01-31. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment (Needs manual offer from BZ)
• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @bernhardoj paid $(AMOUNT) via Upwork (LINK)
• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@laurenreidexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1698613293423120384/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[situchan]

This is not a recent regression. I think the issue always existed from the beginning.
As this was reported by QA team, we can skip regression test.

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[laurenreidexpensify]

upwork.com/jobs/~01611d749111f4e5fe

@bernhardoj @situchan upwork job ^^

[laurenreidexpensify]

Offers sent to @bernhardoj and @situchan in Upwork

[laurenreidexpensify]

Payment Summary:

Contributor: $500 @bernhardoj paid in Upwork
C+ Review: $500 @situchan paid in Upwork

[situchan]

@laurenreidexpensify shouldn't this be 1k as stated in issue title? This is very old issue and accepted proposal was posted after price bump here

[laurenreidexpensify]

Payment Summary:

Further $500 each issued to @situchan and @bernhardoj in Upwork, as job bounty is $1000. Thank you