[HOLD for payment 2023-10-10] [$125] Task - When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Log in to User A's account.
2. Open User B's chat.
3. Navigate to the "Assign task" section.
4. Create a task by entering a title.
5. Open another browser and log in to User B's account.
6. Open User A's chat and open the task.

Expected Result:

When the receiver clicks on the task, "Hmm... it's not here" should not be displayed

Actual Result:

When the receiver clicks on the task, "Hmm... it's not here" is displayed briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-09-28-at-94712-pm_Ajx72u09.1.mp4

Screen.Recording.2023-09-28.at.9.49.08.PM.mov

Screen.Recording.2023-09-28.at.9.50.03.PM.mov

Screen.Recording.2023-09-28.at.9.52.22.PM.mov

20230929211406.mp4

Screen_Recording_20230929_121540_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695920292264359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f2fa932f5d6f4f9c
• Upwork Job ID: 1708867633313923072
• Last Price Increase: 2023-10-02
• Automatic offers:
• fedirjh | Reviewer | 26981978
• dukenv0307 | Contributor | 26981980

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[astrohunter62]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly.

What is the root cause of that problem?

In the ReportScreen, the report prop does not immediately update when the navigation changes. Consequently, when the recipient clicks on a task, report.reportID becomes undefined, causing shouldShowNotFoundPage to be true and displaying the 'Hmm... it's not here.

What changes do you think we should make in order to solve the problem?

We can use the currentReportID props.

For example:

const shouldShowNotFoundPage = useMemo(
  () =>
      (!firstRenderRef.current &&
          !_.isEmpty(report) &&
          !isDefaultReport &&
          !currentReportID &&    // report.reportID -> currentReportID 
          !isOptimisticDelete &&
          !report.isLoadingReportActions &&
          !isLoading &&
          !userLeavingStatus) ||
      shouldHideReport,
  [report, isDefaultReport, currentReportID, isOptimisticDelete, isLoading, userLeavingStatus, shouldHideReport],
);

Result:

28508.Chrome.webm

28508.Safari.webm

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly

What is the root cause of that problem?

We move isLoadingReportActions to reportMetaData and in openReport API, we set it as true in reportMetaData

App/src/libs/actions/Report.js

Lines 463 to 467 in 52f0e3c

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`,
	value: {
	isLoadingReportActions: true,

But here we use report.isLoadingReportActions to check whether the report action is loading or not. So the check is wrong and not found page is displayed briefly

App/src/pages/home/ReportScreen.js

Line 373 in 52f0e3c

!report.isLoadingReportActions &&

What changes do you think we should make in order to solve the problem?

We should replace report.isLoadingReportActions with reportMetaData.isLoadingReportActions to check whether the report action is loading or not

App/src/pages/home/ReportScreen.js

Line 373 in 52f0e3c

!report.isLoadingReportActions &&

We should set the default for isLoadingReportActions here as true because when we open the new report, reportMedata doesn't exist before it's merged in Onyx.

App/src/pages/home/ReportScreen.js

Lines 107 to 109 in 52f0e3c

	reportMetadata: {
	isLoadingReportActions: false,
	isLoadingMoreReportActions: false,

App/src/pages/home/ReportScreen.js

Line 489 in 52f0e3c

isLoadingReportActions: false,

And here, we should check the report exists in Onyx but reportActions is empty we will call openReport API to get the reportActions and update isLoadingReportActions to false

if (report.reportID && report.reportID === getReportID(route) && !_.isEmpty(reportActions)) {
    return;
}

App/src/pages/home/ReportScreen.js

Line 251 in 52f0e3c

if (report.reportID && report.reportID === getReportID(route)) {

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.30-09-2023.14.23.16.webm

[mountiny]

the proposal from @dukenv0307 sounds good to me! @ospfranco @fedirjh what do you think?

[fedirjh]

And here, we should check the report exists in Onyx but reportActions is empty we will call openReport API to get the reportActions and update isLoadingReportActions to false

Why this change is needed? is it possible that we have an existing report without report actions?

Edit: It's possible as openApp command doesn’t include all reports actions collection.

[mountiny]

We only return the report actions for parent threads with the parent report actions

[dukenv0307]

Why this change is needed? is it possible that we have an existing report without report actions?

@fedirjh Let's imagine this case that is after signing out and signing again, we open a report in LHN, the report data exists but doesn't have any report actions, and openReport API isn't called with this condition and then the page will load infinitely

App/src/pages/home/ReportScreen.js

Lines 251 to 252 in 52f0e3c

	if (report.reportID && report.reportID === getReportID(route)) {
	return;

It was not necessary before because in the past ReportActionView was rendered briefly and in this component, we always call openReport API when it's mounted. But with my proposal, the skeleton will be displayed until the openReport API is called in ReportScreen. So this check above is necessary.

App/src/pages/home/report/ReportActionsView.js

Lines 83 to 95 in 00933e1

	const openReportIfNecessary = () => {
	// If the report is optimistic (AKA not yet created) we don't need to call openReport again
	if (props.report.isOptimisticReport) {
	return;
	}
	Report.openReport(reportID);
	};
	useEffect(() => {
	openReportIfNecessary();
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, []);

[fedirjh]

Thanks @dukenv0307 that makes sense to me.

cc @mountiny the proposal looks good to me.

[ospfranco]

@dukenv0307 LGTM

[mountiny]

This will be $125 to @dukenv0307 for the solution proposal

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kevinksullivan]

@mountiny can you take a look at this?

[mountiny]

@fedirjh @dukenv0307 can you please complete the checklist above? Thanks!

[fedirjh]

BugZero Checklist:

• Link to the PR: Use initialValue in withOnyx and other optimizations for ReportScreen #26772
• Link to comment: Actually the author handled this issue
• Determine if we should create a regression test for this bug: 🟢

---

Regression Test Proposal

1. Log in to User A's account.
2. Open User B's chat.
3. Navigate to the "Assign task" section.
4. Create a task by entering a title.
5. Open another browser and log in to User B's account.
6. Open User A's chat and open the task.
7. Verify Skeleton is displayed briefly and "Hmm... it's not here" should not be displayed

• Do we agree 👍 or 👎

[mountiny]

Thanks created the regression test here https://github.com/Expensify/Expensify/issues/324653

[melvin-bot]

@ospfranco, @kevinksullivan, @mountiny, @fedirjh, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

@kevinksullivan can we please pay $50 to @ayazhussain79 and $125 to @dukenv0307 for the proposal

[melvin-bot]

@ospfranco, @kevinksullivan, @mountiny, @fedirjh, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

@trjExpensify could you please help me process the payments here #28508 (comment) thanks!

[trjExpensify]

as per here, confirming payments as follows:

$50 to @ayazhussain79 for the bug report and $125 to @dukenv0307 for the proposal.

@dukenv0307 has been paid. @ayazhussain79 i've sent you an offer.

[ayazhussain79]

@trjExpensify offer accepted, Thank you

[trjExpensify]

Paid.

[kevinksullivan]

Sorry for missing this one guys. And thanks @trjExpensify !