[HOLD 28358][$500] Edited currency Changes back to the previous currency

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Request money within Distance
2. Go to the IOU report page > Edit page
3. Click on the amount
4. Change currency and click save
5. Go back to the IOU report page then again to the Edit page

Expected Result:

Edited currency does not Change back to the previous currency

Actual Result:

Edited currency Changes back to the previous currency

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T153.Currency-1.mp4

T153mac.Currency-1.mp4

Recording.1613.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696209699900619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0111b151ad3cf8d7ec
• Upwork Job ID: 1708815265481723904
• Last Price Increase: 2023-10-02

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0111b151ad3cf8d7ec

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Edited currency changes back to previous currency

What is the root cause of that problem?

• PR - Allow Editing Distance Requests #26141, In this PR we added edit distance request feature

When we update the currency for distance money request,

App/src/pages/EditRequestPage.js

Lines 173 to 177 in 3e36d12

	// Temporarily disabling currency editing and it will be enabled as a quick follow up
	editMoneyRequest({
	amount,
	currency: defaultCurrency,
	});

We are passing default currency here.
But there is comment involving the current behaviour.

What changes do you think we should make in order to solve the problem?

We shall pass the currency from transactionChanges.

What alternative solutions did you explore? (Optional)

[shubham1206agra]

This is a deploy blocker so I think you need to link offending PR too

[mountiny]

But there is comment involving the current behaviour.

The comment is obsolete and should be removed, I forgot to remove it. The currency normally works fine and we get the currency from the route as we return back to the edit request page with currency in the url param

App/src/pages/EditRequestPage.js

Line 92 in 64b5073

const defaultCurrency = lodashGet(route, 'params.currency', '') || transactionCurrency;

[melvin-bot]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[mountiny]

This is not a deploy blocker as its a new feature. I have also confirmed the UpdateDistanceRequest API endpoint does not accept currency key: https://github.com/Expensify/Web-Expensify/blob/7cfa639d6459a9b100c179be98d8215ec0d12bbb/api.php#L3022-L3034

@arosiclair @neil-marcellini @jasperhuangg @tgolen Is this expected? I think there is a bit more logic involved when changing the amount as we also need to update the per mile instructions so its possible this is intentional but we should probs handle this better in the App, could you please take care of this? Adding this to the wave 5 project with no status, up to you

[alexpensify]

Thanks for sharing these feeedback points @mountiny!

[tgolen]

I'm going to unassign everyone from this. There is a lot of cleanup happening for distance requests and this should be covered as part of them. Primarily, #28358 is going to be splitting out the mega EditDistanceRequest API into an API for each field so that it matches the UX and a true 1:1:1 pattern. We'll need to revisit how the currency change will work along with that.

[neil-marcellini]

Closing as explained here