[Paid] [$500] Chat - Unread message green line marker remains after opening the new message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.1-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Navigate to staging.new.expensify.com.
2. [User A] Create a group chat with User B and User C.
3. [User B] Open the group chat.
4. [User B] Navigate to a different chat.
5. [User B] Return to the group chat.

Expected Result:

The unread message green line marker will disappear.

Actual Result:

The unread message green line marker remains.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6285403_1700568404354.20231121_125703.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a6c492f2a1b3468a
• Upwork Job ID: 1726945329577918464
• Last Price Increase: 2023-11-21
• Automatic offers:
• cubuspl42 | Reviewer | 27770767
• tienifr | Contributor | 27770769

Issue Owner

Current Issue Owner: @cubuspl42

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a6c492f2a1b3468a

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[izarutskaya]

Not reproducible on production

20231121_125944.mp4

[s-alves10]

#30696 (comment)
Let's apply this changes.

We have several issues related to new marker
#30485
#27456
#30485 (comment)

I think we need to refactor the logic of calculatiing new marker

cc @cubuspl42

[MonilBhavsar]

Might be because of #25935
Me and @gedu can help with this

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Unread message green line marker remains after opening the new message

What is the root cause of that problem?

After marking as unread, we try to cacheUnreadMarkers.set(report.reportID), and then delete it in

App/src/pages/home/report/ReportActionsList.js

Line 217 in 0cca90a

cacheUnreadMarkers.delete(report.reportID);

but at the first time users visit the new chat, report.lastReadTime is undefined that why this line can't be executed. -> Whenever we go to this chat, function markerInit always return stale value

What changes do you think we should make in order to solve the problem?

We should change this line to

        if (!messageManuallyMarkedUnread && (((lastReadTimeRef.current || '') < report.lastReadTime) || !report.lastReadTime)) {

to allow cacheUnreadMarkers.delete when report.lastReadTime is undefined

Result

Screen.Recording.2023-11-21.at.21.49.54.mp4

[MonilBhavsar]

I was also looking at that condition. Did you test other cases?
And are you able to prioritise this considering this is a blocker?

[tienifr]

@MonilBhavsar yes, I tested most of the cases and it works well. My solution just cover the case when report.lastReadTime is undefined, so I think it won't cause any regressions

[gedu]

sounds good to me

[Nathan-Mulugeta]

Hey team, I think this issue might have the same RCA with this one or maybe it might be better to resolve that issue on the same PR as here. What are your thoughts?

[MonilBhavsar]

That's expected behavior. I commented in that issue

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] fix: 31623 Unread message green line marker remains after opening the new message #31653

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

I think we're only missing the BZ checklist and payment here

[cubuspl42]

No payment for me, I wasn't involved in practice in this one. Should I still fill the checklist?

[anmurali]

I paid @tienifr and it doesn't look like there is an external issue reporter.

[melvin-bot]

@nkuoch, @cubuspl42, @anmurali, @luacmartins, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

It seems like all payments have been issued. I think we're good to close this one! Thanks everyone!