[HOLD for payment 2023-12-26] Room - Unable to leave public room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Click FAB > Start chat > Room
3. Create a public room
4. Go to the public room
5. Click 3-dot menu > Leave
   Note that user is unable to leave the room

Expected Result:

User is able to leave the room

Actual Result:

User is unable to leave the room. The room changes to Archived and back to normal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6312080_1702492440997.public_room.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hayata-suenaga]

This is the response for the LeaveRoom command.

This is the response for the LeaveRoom command on production

There seems no difference between the two responses, so the issue probably stem from the front end code change.

Let me if the action code has recently been changed -> https://expensify.slack.com/archives/C0593T50UHG/p1702500582444429

[ishpaul777]

this might be coming from to #28730, its a big PR so i am still trying to get to exact root cause

[hayata-suenaga]

Yes I already pinged @blazejkustra. Meanwhile if you find a root cause, please feel free to make a fix PR for this @ishpaul777.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is unable to leave the room. The room changes to Archived and back to normal

What is the root cause of that problem?

When we leave room, we don't set the reportName in optimistic data of report

App/src/libs/actions/Report.ts

Line 2069 in e81ed8f

reportID,

which makes reconnectToReport API is called and then the data of the report is restore.

App/src/libs/actions/Report.ts

Line 1066 in e81ed8f

if (report.reportID && report.reportName === undefined) {

What changes do you think we should make in order to solve the problem?

1. We should add reportName in the optimistic data of report here

App/src/libs/actions/Report.ts

Line 2069 in e81ed8f

reportID,

or we should use merge method, and only update statusNum and stateNum
2. To trigger navigating after leaving room, we should update statusNum, stateNum in successData

{
    ...Object.keys(report).reduce<Record<string, null>>((acc, key) => {
        acc[key] = null;
        return acc;
    }, {}),
    stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
    statusNum: CONST.REPORT.STATUS.CLOSED,
}

App/src/pages/home/ReportScreen.js

Line 316 in e81ed8f

(prevOnyxReportID &&

Or we should remove this check from the condition because reportID still present in optimisticData

App/src/pages/home/ReportScreen.js

Line 318 in e81ed8f

!onyxReportID &&

Or remove reportID from optimistic data here.

App/src/libs/actions/Report.ts

Line 2069 in e81ed8f

reportID,

What alternative solutions did you explore? (Optional)

For point 2 in my proposal, we can remove this case in ReportScreen and copy the navigate logic to leaveRoom function

App/src/libs/actions/Report.ts

Line 2111 in e81ed8f

if (isWorkspaceMemberLeavingWorkspaceRoom) {

[dukenv0307]

@hayata-suenaga What about my proposal?

[hayata-suenaga]

waiting for @blazejkustra

[Julesssss]

Okay, so we still need to fix this, but it's occuring on production 1.4.11-25 and not a blocker. checking it off the checklist:

screen-20231214-104607.mp4

[Julesssss]

Anyway, this PR seems to resolve the issue 👍

[blazejkustra]

@hayata-suenaga @Julesssss Sorry for late response I finished work yesterday, here is a PR that should fix it. As this is a regression that originated from my TS migration PR, I fixed it without a proposal. If needed I can post one with more details, just let me know.

[hayata-suenaga]

Because the PR has been merged, I'll close this issue

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix for - Unable to leave public room #33053

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR