[HOLD for payment 2024-01-26] Status - Tooltip Not Displayed Upon Clicking Chevron in the Status Section

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.18-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Sign in to staging Expensify
2, Navigate to Settings > Profile > Status
3, Hover over the message icon or down the chevron icon. Note the tooltip displaying "Emoji" pops up
4, Click the down chevron to open the emoji section
5, Click again to close the emoji section
6, Hover over the message icon or down chevron and observe that the tooltip is not displayed

Expected Result:

When the down chevron is clicked again to close the modal, the tooltip should be displayed upon hovering over the down chevron

Actual Result:

When we click the down chevron again to close the modal, the tooltip does not appear when hovering over the down chevron

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6327136_1703716328221.1.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Not worth blocking the deploy over.

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Status - Tooltip Not Displayed Upon Clicking Chevron in the Status Section

What is the root cause of that problem?

Offending PR - #33537

This is happening due to we are making wrong thing as null (instead of element, we are making whole ref as null) on closing the EmojiPicker, due to which we are not closing the EmojiPicker properly, and isOpen in PopoverContext remains true in this case.

What changes do you think we should make in order to solve the problem?

Use getEmojiPopoverAnchor().current = null; instead of emojiPopoverAnchorRef.current = null; in hideEmojiPicker method.

What alternative solutions did you explore? (Optional)

[bernhardoj]

As this is coming from my PR, I have opened a new PR to fix this. The issue explanation is here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix tooltip doesn't show after closing the emoji picker #33690

If no regressions arise, payment will be issued on 2024-01-26. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[peterdbarkerUK]

PR is deployed and rolling fine - as it is a fix to a previous PR that was also implemented by @bernhardoj and reviewed by @aimane-chnaif, I believe no payment is necessary here. Correct?

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aimane-chnaif]

Correct. Let's close this