[$500] DMs with a hidden notification preference show up in search twice, once with the email and once without

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @srikarparsi
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705731187838889

Action Performed:

1. Create a DM with another user that you have not previously DMed
2. Navigate to another chat so that the DM disappears from your LHN
3. Click search and see the DM that you have just created appears twice, once with email and once without email

Expected Result:

should be hiding these DMs from search entirely

Actual Result:

Only profile pics are shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1699.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019a3378b1028ed211
• Upwork Job ID: 1749471517916659712
• Last Price Increase: 2024-02-12
• Automatic offers:
• mollfpr | Reviewer | 0
• dukenv0307 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019a3378b1028ed211

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

DMs with a hidden notification preference show up in search without a name

What is the root cause of that problem?

As we open the chat after searching it is included in reports list and b/c We are not filtering out personal details without proper accountID (Nan) in Search Page it appears when we open search page.

What changes do you think we should make in order to solve the problem?

We should filter out those personal details with accountid of Nan from recent reports before display in search page
We can add this code before here ingetOptions

App/src/libs/OptionsListUtils.js

Lines 1530 to 1532 in 52adf77

	recentReportOptions.push(reportOption);

            if (!reportOption.login && !reportOption.accountID && !reportOption.ownerAccountID) {
                continue;
            }

or in here

App/src/libs/OptionsListUtils.js

Lines 1392 to 1395 in 52adf77

	if (!report) {
	return;
	}

if (!report.login && !report.accountID && !report.ownerAccountID) {
            return;
        }

or we can iterate and filter out from sections here

App/src/pages/SearchPage.js

Lines 135 to 136 in 52adf77

	return sections;
	};

or we should stop adding personal details without proper accountID in to recents list

What alternative solutions did you explore? (Optional)

---

If we want to filter out all empty chats we can add an additional condition of in here

App/src/libs/OptionsListUtils.js

Lines 1392 to 1395 in 52adf77

	if (!report) {
	return;
	}

        const lastVisibleMessage = ReportActionUtils.getLastVisibleMessage(report.reportID);
        const isEmptyChat = !report.lastMessageText && !report.lastMessageTranslationKey && !lastVisibleMessage.lastMessageText && !lastVisibleMessage.lastMessageTranslationKey;

        if (isEmptyChat && ReportUtils.isChatReport(report) && !ReportUtils.isChatRoom(report) && !ReportUtils.isPolicyExpenseChat(report)) {
            return;
        }

We can optionally use this logic too to decide if it is empty chat getting the report actions by ReportActionsUtils.getAllReportActions(report?.reportID)

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js

Line 130 in e791ecc

const isEmptyChat = useMemo(() => _.size(reportActions) === 1, [reportActions]);

We can also narrow down our filter using ReportUtils.isChatReport only filter out empty chat reports or also isDM or !ReportActionsUtils.isTransactionThread

---

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

should be hiding the empty DMs from search entirely

What is the root cause of that problem?

When the chat just created we do not have the accountID and the any chat message in the report. And Even when we send a message the accountID still NaN
And when we get list recentReports, we don't filter recentReports that don't have an accountID and alternateText is empty.

What changes do you think we should make in order to solve the problem?

I think with the show Hidden user and have a message we also can search for them
So we should filter recentReports with the condition accountID correct and alternateText is not empty

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only profile pics are shown

What is the root cause of that problem?

For reports where there's no account ids that should be visible (as in this case), visibleChatMemberAccountIDs here will be empty. But we still use that empty account ids list to calculate the option, leading to invalid options like can be seen in this issue.

What changes do you think we should make in order to solve the problem?

Early return here if the accountIDs list is empty (and optionally check the chat is a DM also).

What alternative solutions did you explore? (Optional)

This issue might happen in other chat cases like if the chat is a group chat as well, we can test for those scenarios and add relevant checks (instead of just checking the chat is a DM) along with the accountIDs list is empty check.

An alternative is to early return if accountIDs list is empty and the chat doesn't have multiple participants (with same condition as here), that means the participant in the chat are not visible and shouldn't be shown in search list.

Or in here we could fallback to using participantAccountIDs (as accountIDs) if the visibleChatMemberAccountIDs list is empty.

[abzokhattab]

I think this might be a backend issue because the backend returns the visibleChatMemberAccountIDs as an empty list when opening report with a new user, where it should be the same as the participantsLists

[FitseTLT]

Updated to add more detail and alternative approaches

[mollfpr]

@kavimuru I might need clarification on the expected result. Should we exclude all the empty chat reports on the recent list or those that only show the profile pic?

From the above screenshot, I see a bug showing the report with only the profile picture.

[mollfpr]

@srikarparsi Could you help clarify the above question? Thank you!

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we search for a user without internet, the recent search results do not show the users display name

What is the root cause of that problem?

The accountId never got resolved while offline. This results in a null accountId for the record.
Snapshot of the entity is here:

We return an empty displayName under this condition:
https://github.com/Expensify/App/blob/0efabc2b40fe845b13faa94ec508a6693167ede9/src/libs/ReportUtils.ts#L1608C1-L1611C6
Hence why we render null.

What changes do you think we should make in order to solve the problem?

We can update the displayName logic to fallback to option.text if it doesn't resolve the displayname here:

App/src/libs/ReportUtils.ts

Line 1645 in 0efabc2

const displayName = getDisplayNameForParticipant(accountID, isMultipleParticipantReport, shouldFallbackToHidden) || user?.login || '';

It already short-circuits to login, but in this error case it's also not present.

Note:
After the user refreshes the page or interacts with the User - it fixes the database and will show the correct displayName.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@mollfpr, @srikarparsi Huh... This is 4 days overdue. Who can take care of this?

[mollfpr]

Need clarification #34900 (comment)

cc @kavimuru @srikarparsi

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[srikarparsi]

In regard to this question, I believe we should exclude all empty chats. I think the search function should be optimized for existing chats, for empty chats it would be just as simple to "re-create" them.

[mollfpr]

Does anyone want to update their proposal according to the above expectations?

[FitseTLT]

Updated proposal in alternative solution considering the above expectation

[melvin-bot]

@mollfpr @srikarparsi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.

[dukenv0307]

@mollfpr PR #36816 is ready to review

[mollfpr]

@srikarparsi the issue missing label Awaiting Payment and the payment date, could you update it? Thank you!

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[srikarparsi]

Yup! Seems to be the case. Hey @muttmuure do you think you could help with payment for this PR after the regression period. Also, I don't believe the automation worked, do you know if there's a way to get around that?

[melvin-bot]

Current assignee @mollfpr is eligible for the External assigner, not assigning anyone new.

[muttmuure]

@mollfpr - $500 for C+
@dukenv0307 - $500 for C

[muttmuure]

All paid up, @mollfpr needs to request in NewDot using the summary above

[JmillsExpensify]

$500 approved for @mollfpr based on summary.