[TS migration] Migrate `SettingsProfileContacts` page to TypeScript #35305

tienifr · 2024-01-29T11:15:38Z

Details

Migrate SettingsProfileContacts page to TypeScript

Fixed Issues

$ #25218
PROPOSAL:

Tests

Open Settings >> Profile >> Contact methods
Add a new contact method
Enter wrong validation code
Verify error appears
Enter correct validation code
Verify it is added
Remove a contact method
Verify it is removed

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Open Settings >> Profile >> Contact methods
Add a new contact method
Enter wrong validation code
Verify error appears
Enter correct validation code
Verify it is added
Remove a contact method
Verify it is removed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-02-05.at.21.58.22-compressed.mov

Screen.Recording.2024-02-05.at.21.25.57-compressed.mov

Screen.Recording.2024-02-05.at.21.25.14-compressed.mov

Screen.Recording.2024-02-05.at.17.21.25-compressed.mov

MacOS: Desktop

Screen.Recording.2024-02-05.at.21.58.22-compressed.mov

Screen.Recording.2024-02-05.at.21.25.57-compressed.mov

Screen.Recording.2024-02-05.at.21.25.14-compressed.mov

Screen.Recording.2024-02-05.at.17.21.25-compressed.mov

…on/25218

melvin-bot · 2024-02-05T06:23:10Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…on/25218

kubabutkiewicz · 2024-02-12T12:51:41Z

src/components/MagicCodeInput.tsx

@@ -427,4 +427,5 @@ function MagicCodeInput(

 MagicCodeInput.displayName = 'MagicCodeInput';

+export type {MagicCodeInputHandle};


NAB: I would move it below export default ... to match other files

kubabutkiewicz · 2024-02-12T12:54:00Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

+
+type ContactMethodDetailsPageProps = ContactMethodDetailsPageOnyxProps & StackScreenProps<SettingsNavigatorParamList, typeof SCREENS.SETTINGS.PROFILE.CONTACT_METHOD_DETAILS>;
+
+function ContactMethodDetailsPage({loginList = {}, session = {}, myDomainSecurityGroups = {}, securityGroups, isLoadingReportData = true, route}: ContactMethodDetailsPageProps) {


Suggested change

function ContactMethodDetailsPage({loginList = {}, session = {}, myDomainSecurityGroups = {}, securityGroups, isLoadingReportData = true, route}: ContactMethodDetailsPageProps) {

function ContactMethodDetailsPage({loginList, session, myDomainSecurityGroups, securityGroups, isLoadingReportData = true, route}: ContactMethodDetailsPageProps) {

since we are using optional chaining its not needed to add default values

kubabutkiewicz · 2024-02-12T12:54:29Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

+    /**
+     * Gets the current contact method from the route params
+     */
+    const contactMethod = useMemo(() => {


Please add return type to this const

kubabutkiewicz · 2024-02-12T12:57:47Z

src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx


-function ContactMethodsPage(props) {
+function ContactMethodsPage({loginList = {}, session, route}: ContactMethodsPageProps) {


Same here , no need to add default value to loginList

kubabutkiewicz · 2024-02-12T12:58:43Z

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

    const phoneLogin = LoginUtils.getPhoneLogin(values.phoneOrEmail);
    const validateIfnumber = LoginUtils.validateNumber(phoneLogin);
    const submitDetail = (validateIfnumber || values.phoneOrEmail).trim().toLowerCase();

    User.addNewContactMethodAndNavigate(submitDetail);
 };

-function NewContactMethodPage(props) {
+function NewContactMethodPage({loginList = {}, route}: NewContactMethodPageProps) {


kubabutkiewicz · 2024-02-12T12:59:12Z

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

                style={[styles.flexGrow1, styles.mh5]}
                enabledWhenOffline
            >
-                <Text style={[styles.mb5]}>{props.translate('common.pleaseEnterEmailOrPhoneNumber')}</Text>
+                <Text style={[styles.mb5]}>{translate('common.pleaseEnterEmailOrPhoneNumber')}</Text>


Suggested change

<Text style={[styles.mb5]}>{translate('common.pleaseEnterEmailOrPhoneNumber')}</Text>

<Text style={styles.mb5}>{translate('common.pleaseEnterEmailOrPhoneNumber')}</Text>

kubabutkiewicz · 2024-02-12T13:00:12Z

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx

-        pendingFields: PropTypes.objectOf(PropTypes.objectOf(PropTypes.string)),
-    }).isRequired,
+    /** Specifies autocomplete hints for the system, so it can provide autofill */
+    autoComplete?: 'sms-otp' | 'one-time-code';


maybe worth creating a seperate type for that?

kubabutkiewicz · 2024-02-12T13:00:42Z

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx

    const validateLoginError = ErrorUtils.getEarliestErrorField(loginData, 'validateLogin');
-    const shouldDisableResendValidateCode = props.network.isOffline || props.account.isLoading;
-    const focusTimeoutRef = useRef(null);
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


please add explanation why this was added

fedirjh · 2024-02-11T19:28:14Z

src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

            indicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
        }

        // Default to using login key if we deleted login.partnerUserID optimistically
        // but still need to show the pending login being deleted while offline.
-        const partnerUserID = login.partnerUserID || loginName;
-        const menuItemTitle = Str.isSMSLogin(partnerUserID) ? props.formatPhoneNumber(partnerUserID) : partnerUserID;
+        const partnerUserID = login?.partnerUserID ?? loginName;


Suggested change

const partnerUserID = login?.partnerUserID ?? loginName;

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing

const partnerUserID = login?.partnerUserID || loginName;

partnerUserID is updated to empty string when the contact is deleted optimistically

fedirjh · 2024-02-11T19:30:41Z

src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

-        if (!login.partnerUserID && _.isEmpty(pendingAction)) {
+    const loginMenuItems = sortedLoginNames.map((loginName) => {
+        const login = loginList?.[loginName];
+        const pendingAction = login?.pendingFields?.deletedLogin ?? login?.pendingFields?.addedLogin;


Suggested change

const pendingAction = login?.pendingFields?.deletedLogin ?? login?.pendingFields?.addedLogin;

const pendingAction = login?.pendingFields?.deletedLogin ?? login?.pendingFields?.addedLogin ?? undefined;

Let's fallback to undefined

fedirjh · 2024-02-11T19:34:11Z

src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

+    const loginMenuItems = sortedLoginNames.map((loginName) => {
+        const login = loginList?.[loginName];
+        const pendingAction = login?.pendingFields?.deletedLogin ?? login?.pendingFields?.addedLogin;
+        if (!login?.partnerUserID && isEmptyObject(pendingAction)) {


Suggested change

if (!login?.partnerUserID && isEmptyObject(pendingAction)) {

if (!login?.partnerUserID && !pendingAction) {

pendingAction is not an object.

fedirjh · 2024-02-11T19:41:48Z

src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx


        return (
            <OfflineWithFeedback
-                pendingAction={pendingAction}
+                pendingAction={pendingAction ?? undefined}


Suggested change

pendingAction={pendingAction ?? undefined}

pendingAction={pendingAction}

fedirjh · 2024-02-11T19:42:58Z

src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

@@ -105,7 +82,7 @@ function ContactMethodsPage(props) {
                    brickRoadIndicator={indicator}
                    shouldShowBasicTitle
                    shouldShowRightIcon
-                    disabled={!_.isEmpty(pendingAction)}
+                    disabled={!isEmptyObject(pendingAction)}


Suggested change

disabled={!isEmptyObject(pendingAction)}

disabled={!!pendingAction}

fedirjh · 2024-02-12T14:35:22Z

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx

                name="validateCode"
                value={validateCode}
                onChangeText={onTextInput}
-                errorText={formError.validateCode ? props.translate(formError.validateCode) : ErrorUtils.getLatestErrorMessage(props.account)}
-                hasError={!_.isEmpty(validateLoginError)}
+                errorText={formError?.validateCode ? translate(formError?.validateCode as TranslationPaths) : ErrorUtils.getLatestErrorMessage(account ?? {})}


Let's avoid type casting: Let's create a new type for the formError

type ValidateCodeFormError = { validateCode?: TranslationPaths; };

fedirjh · 2024-02-12T14:38:41Z

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx

+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+    const shouldDisableResendValidateCode = isOffline || account?.isLoading;


Suggested change

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing

const shouldDisableResendValidateCode = isOffline || account?.isLoading;

const shouldDisableResendValidateCode = !!isOffline || account?.isLoading;

Why do we need this? isOffline is a boolen.

It could be null as well.

We can't use nullish coalescing here because it will fail when isOffline is false.

fedirjh · 2024-02-12T14:59:38Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

+
+    // Replacing spaces with "hard spaces" to prevent breaking the number
+    const formattedContactMethod = Str.isSMSLogin(contactMethod) ? formatPhoneNumber(contactMethod).replace(/ /g, '\u00A0') : contactMethod;
+    const hasMagicCodeBeenSent = loginList?.[contactMethod].validateCodeSent;


Suggested change

const hasMagicCodeBeenSent = loginList?.[contactMethod].validateCodeSent;

const hasMagicCodeBeenSent = !!loginData.validateCodeSent;

fedirjh · 2024-02-12T15:00:02Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

+
+                        <ValidateCodeForm
+                            contactMethod={contactMethod}
+                            hasMagicCodeBeenSent={!!hasMagicCodeBeenSent}


Suggested change

hasMagicCodeBeenSent={!!hasMagicCodeBeenSent}

hasMagicCodeBeenSent={hasMagicCodeBeenSent}

fedirjh · 2024-02-12T15:07:16Z

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx

                            messages={{0: 'resendValidationForm.linkHasBeenResent'}}
                        />
                    )}
                </View>
            </OfflineWithFeedback>
            <OfflineWithFeedback
-                pendingAction={lodashGet(loginData, 'pendingFields.validateLogin', null)}
+                pendingAction={loginData.pendingFields?.validateLogin ?? undefined}


Maybe we have to update PendingAction to accept null values.

tienifr · 2024-02-14T17:28:43Z

Resolved all comments.

…on/25218

fedirjh · 2024-02-19T01:31:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-02-19.at.02.43.06.mp4

Android: mWeb Chrome

CleanShot.2024-02-19.at.02.40.43.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-19.at.02.22.52.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-19.at.02.29.46.mp4

MacOS: Chrome / Safari

CleanShot.2024-02-19.at.02.12.10.mp4

MacOS: Desktop

CleanShot.2024-02-19.at.02.54.24.mp4

fedirjh

Looks good to me

melvin-bot · 2024-02-19T17:22:11Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25218 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

tienifr · 2024-02-21T08:10:49Z

@fedirjh @youssef-lr I did not see any internal engineer assigned here for approval.

youssef-lr · 2024-02-22T05:24:02Z

@kubabutkiewicz would you like to give this a final review?

kubabutkiewicz · 2024-02-22T06:43:39Z

Will do that today!

kubabutkiewicz

lgtm!

OSBotify · 2024-02-22T13:10:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:05:11Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:53:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 10 commits January 29, 2024 18:14

Migrate NewContactMethodPage to TS

f32ffa8

Migrate ContactMethodsPage to TS

70645b1

Migrate ValidateCodeForm to TS

af6ce14

Merge branch 'main' into ts-migration/25218

dafab10

fix lint

8efe4f2

fix lint

7077a43

Migrate ContactMethodDetailsPage to TS

21df678

Merge branch 'main' into ts-migration/25218

b6725d9

Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…

acc1e8f

…on/25218

reapply changes

21c82bf

tienifr marked this pull request as ready for review February 5, 2024 06:23

tienifr requested a review from a team as a code owner February 5, 2024 06:23

melvin-bot bot removed the request for review from a team February 5, 2024 06:23

melvin-bot bot requested a review from fedirjh February 5, 2024 06:23

tienifr added 4 commits February 5, 2024 17:16

Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…

41a25ff

…on/25218

add optional chaining

d66b416

fix sign out with default contact method

12a46b6

fix lint

74509dd

kubabutkiewicz reviewed Feb 12, 2024

View reviewed changes

fedirjh suggested changes Feb 12, 2024

View reviewed changes

tienifr added 3 commits February 14, 2024 22:59

Merge branch 'main' into ts-migration/25218

97a5cd2

Fix typecheck

cb40458

Resolve comments

a2004ff

tienifr added 2 commits February 15, 2024 00:33

Merge branch 'main' of https://github.com/tienifr/App into ts-migrati…

cffc6b0

…on/25218

fix lint

9a11ace

Merge branch 'main' into ts-migration/25218

9120124

fedirjh approved these changes Feb 19, 2024

View reviewed changes

fedirjh approved these changes Feb 21, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr February 21, 2024 13:21

Merge branch 'main' into ts-migration/25218

5a835eb

kubabutkiewicz approved these changes Feb 22, 2024

View reviewed changes

youssef-lr approved these changes Feb 22, 2024

View reviewed changes

youssef-lr merged commit 6adfbf2 into Expensify:main Feb 22, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate `SettingsProfileContacts` page to TypeScript #35305

[TS migration] Migrate `SettingsProfileContacts` page to TypeScript #35305

tienifr commented Jan 29, 2024 •

edited

Loading

melvin-bot bot commented Feb 5, 2024

kubabutkiewicz Feb 12, 2024

kubabutkiewicz Feb 12, 2024

kubabutkiewicz Feb 12, 2024

kubabutkiewicz Feb 12, 2024

kubabutkiewicz Feb 12, 2024

kubabutkiewicz Feb 12, 2024

kubabutkiewicz Feb 12, 2024

kubabutkiewicz Feb 12, 2024

fedirjh Feb 11, 2024

fedirjh Feb 11, 2024

fedirjh Feb 11, 2024

fedirjh Feb 11, 2024

fedirjh Feb 11, 2024

fedirjh Feb 12, 2024

fedirjh Feb 12, 2024

tienifr Feb 14, 2024

fedirjh Feb 14, 2024

fedirjh Feb 14, 2024 •

edited

Loading

fedirjh Feb 12, 2024

fedirjh Feb 12, 2024

fedirjh Feb 12, 2024

tienifr commented Feb 14, 2024

fedirjh commented Feb 19, 2024 •

edited

Loading

fedirjh left a comment

melvin-bot bot commented Feb 19, 2024

tienifr commented Feb 21, 2024

youssef-lr commented Feb 22, 2024

kubabutkiewicz commented Feb 22, 2024

kubabutkiewicz left a comment

OSBotify commented Feb 22, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

		@@ -427,4 +427,5 @@ function MagicCodeInput(

		MagicCodeInput.displayName = 'MagicCodeInput';

		export type {MagicCodeInputHandle};


		type ContactMethodDetailsPageProps = ContactMethodDetailsPageOnyxProps & StackScreenProps<SettingsNavigatorParamList, typeof SCREENS.SETTINGS.PROFILE.CONTACT_METHOD_DETAILS>;

		function ContactMethodDetailsPage({loginList = {}, session = {}, myDomainSecurityGroups = {}, securityGroups, isLoadingReportData = true, route}: ContactMethodDetailsPageProps) {


		function ContactMethodsPage(props) {
		function ContactMethodsPage({loginList = {}, session, route}: ContactMethodsPageProps) {

	<Text style={[styles.mb5]}>{translate('common.pleaseEnterEmailOrPhoneNumber')}</Text>
	<Text style={styles.mb5}>{translate('common.pleaseEnterEmailOrPhoneNumber')}</Text>

	const partnerUserID = login?.partnerUserID ?? loginName;
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	const partnerUserID = login?.partnerUserID \|\| loginName;

	const pendingAction = login?.pendingFields?.deletedLogin ?? login?.pendingFields?.addedLogin;
	const pendingAction = login?.pendingFields?.deletedLogin ?? login?.pendingFields?.addedLogin ?? undefined;

	if (!login?.partnerUserID && isEmptyObject(pendingAction)) {
	if (!login?.partnerUserID && !pendingAction) {

	pendingAction={pendingAction ?? undefined}
	pendingAction={pendingAction}

	disabled={!isEmptyObject(pendingAction)}
	disabled={!!pendingAction}

		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
		const shouldDisableResendValidateCode = isOffline \|\| account?.isLoading;

	const hasMagicCodeBeenSent = loginList?.[contactMethod].validateCodeSent;
	const hasMagicCodeBeenSent = !!loginData.validateCodeSent;

	hasMagicCodeBeenSent={!!hasMagicCodeBeenSent}
	hasMagicCodeBeenSent={hasMagicCodeBeenSent}

[TS migration] Migrate SettingsProfileContacts page to TypeScript #35305

[TS migration] Migrate SettingsProfileContacts page to TypeScript #35305

Conversation

tienifr commented Jan 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedirjh Feb 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tienifr commented Feb 14, 2024

fedirjh commented Feb 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 19, 2024

tienifr commented Feb 21, 2024

youssef-lr commented Feb 22, 2024

kubabutkiewicz commented Feb 22, 2024

kubabutkiewicz left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 22, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

[TS migration] Migrate `SettingsProfileContacts` page to TypeScript #35305

[TS migration] Migrate `SettingsProfileContacts` page to TypeScript #35305

tienifr commented Jan 29, 2024 •

edited

Loading

fedirjh Feb 14, 2024 •

edited

Loading

fedirjh commented Feb 19, 2024 •

edited

Loading