Deploy Checklist: New Expensify 2024-01-29

[github-actions]

Release Version: 1.4.33-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• feat: append whitespace after inserting emoji #30955
• Feat: drop user to last chat after leaving a room #31097
• TextInput numberOfLines/maxNumberOfLines workaround (manually calculating maxHeight of TextInput #31483
• [TS migration] Migrate 'OptionsListUtils.js' lib to TypeScript #32470
• Fix Black Screen Transition Issue by Reusing didScreenTransitionEnd in MoneyRequestParticipantsSelector #32665
• Use set method when creating policy for payment #32959
• [TS migration] Migrate 'Form' component to TypeScript #32992
• Fix cannot open search page by shortcut if delete receipt confirm modal is visible #33203
• fix: Green dot does not appear in LHN when the request is created in workspace chat #33398
• Extract gesture logic from MultiGestureCanvas to hooks and improve code #33756
• [TS migration] Migrate 'ValidateLogin' page to TypeScript #33839
• Fix: Duplicate phone number can be invited #33928
• [TS migration] Migrate 'ReportActionItemFragment.js' and related components to TypeScript #33958
• fix: Drop domain name in mentions if chat members are on the same domain #34013
• remove extra padding below emoji skin tone selection when keyboard is up #34105
• [TS migration] Migrate 'ImageView' component to TypeScript #34202
• perf: reduce APK size with ProGuard enabled #34218
• Fix custom name for tag in tag edit message reverts to "tag" after relogin #34482
• Fix scroll behavior when single item is selected #34485
• Fix - Mark the chat as "read" immediately upon switching to the tab #34537
• [TS migration] Create centralized types for API params #34542
• [TS migration] Migrate 'SettingsAbout' page to TypeScript #34597
• Add filtering to the reports data in the Focus mode switch logic #34624
• Disable reply in thread for report preview when delete IOU report in offline #34635
• [NoQA] Reassure performance tests improvements #34641
• Fix reimbursed message is not copied #34713
• [No QA] Update Budgets.md #34731
• [No QA] use a better approach for useResponsiveLayout hook #34743
• Fix Overflow menu from keyboard and show left-out options only #34754
• Fix overriden CFBundleVersion and CFBundleShortVersionString #34760
• clear distance when save waypoint #34779
• fix logic clear status and save status #34780
• Fix money request amount input is partially visible after going back from currency selection page #34787
• fix: check visibility as well to show another login message #34791
• dev: removed API mocks and use actual account  #34792
• Updated placement of the user status icon #34795
• fix: check if the default workspace is a public workspace #34796
• Bump onyx to fix replay effect (after revert) #34801
• Add TS types for new participants object format #34844
• fix: Open offline notes from deeplink #34860
• Fix Settlement button total #34909
• Fix: Amount text input is hard to paste #34941
• Remove MoneyRequestConfirmPage #34947
• Fix list on some page doesn't show scroll bar #34953
• Added the ability to paste Google Docs images / charts into the Composer chat for web based platforms #34971
• fix: call signOutAndRedirectToSignIn with no parameter #34975
• Delete docs/articles/expensify-classic/getting-started/Plan-Types.md #35005
• Update CONTRIBUTING.md #35015
• clean tag for old money confirmation list #35054
• Delete docs/articles/expensify-classic/getting-started/approved-accou… #35078
• Delete docs/articles/expensify-classic/getting-started/approved-accou… #35082
• Handle API errors to trigger force upgrades of the app #35114
• [No QA] Make redirects work for help and use dot #35116
• Don't persist error after reconnecting with plaid #35117
• Fix selection handle hidden in mobile chrome #35119
• Fix/30884: Fix dependency cycle #35127
• fix: show parent action message or deleted message #35128
• Fix highlighted user in new chat page is covered by referral view #35129
• Fix unable to close bank account page #35130
• fix: Set category & tag optimistically for the scan split requests #35135
• Fix hidden name is search #35142
• fix scan capture button overlap with iOS navigation bar #35151
• [NoQA] Perf test workflow improvement #35152
• fix: disable tab key event in Money Request page #35154
• Updated Out of Pocket Text Updated (English and Spanish) #35162
• Log if we received push event in old format #35165
• Update policy type #35181
• fixes typescript mistake with type assertion in ReportActionItemMessage #35204
• Add numbering to concierge intro instructions #35206
• Fix/33990: Not here page appear when refreshing #35210
• [No QA] Fix onLayout type error on main #35216
• fix: Use isValidPersonName for teachers name validation #35229
• Change receipt address style #35231
• Update redirects.csv #35260
• remove join room from list of roomchangelog actions #35267
• [No QA] Update README.md to include instructions on installing Xcode tools #35271
• [No QA] Bump node to 20.10.0 #35272
• Revert "Fix money request amount input is partially visible after going back from currency selection page" #35273
• Update Expenses.md #35282
• Fix money request amount input is partially visible after going back from currency selection page #35297
• Fix crash when searching and missing translation when adding attachment on iOS #35300
• Remove cancel request where isDarkMode=true #35034 #35301
• [CP Staging] Revert "Fix: Duplicate phone number can be invited" #35335
• Add missing CFBundleExecutable key and value in Info.plist #35336
• [CP Staging] Revert "Remove MoneyRequestConfirmPage" #35348
• [CP Staging] Revert #34485 #35386
• [CP Staging] fix crash on tapping enable wallet in android #35440

Deploy Blockers:

• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] Send Money - Send option doesn't work, can't choose a receiver, an error in the console #35337
• Room - Room does not disappear from LHN after leaving the room #35338
• Web - Chat - Emoji is entered twice when entering via Windows OS keyboard #35339
• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] [$500] Android - Wallet - App crashes on tapping enable wallet. #35344
• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] [$500] Personal details - First item in the list is not highlighted when searching for country #35374
• [HOLD for payment 2024-06-20] [$500] Status - Emoji in custom status holder is not centered #35389
• Send money - Unexpected error when sending money to a Hidden contact #35394
• Split - List does not scroll up after selecting a split participant #35395
• IOU - Other currency is highlighted instead of the first after clearing search #35396
• [HOLD for payment 2024-02-14] [$500] Thread - Messages have a "Leave thread" option #35397
• Collect admin - New invited user appears four times in workspace chat member list #35407
• Tags - Numbers are not alphabetically ordered #35421
• [$500] Tag - Extra padding above Recent section in Tag list #35423
• Tag - Inconsistency in tag custom name for "Missing tag" and "Tag no longer valid" #35425

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.33-0 🚀

[francoisl]

• Add missing CFBundleExecutable key and value in Info.plist #35336 and [CP Staging] Revert "Fix: Duplicate phone number can be invited" #35335 were tested internally, checking them
• [CP Staging] Revert "Remove MoneyRequestConfirmPage" #35348 and [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] Send Money - Send option doesn't work, can't choose a receiver, an error in the console #35337 tested internally as well

[kavimuru]

Regression is at 69%. We still have PRs to validate in all the environments. Many testers does not have test build version in iOS.

#30955 failing with #35339 in web
#32959 failing with #35366 repro in PROD checking it off

[kbecciv]

Regression is 15% left

#30955 is failing with #35339 in web
#31097 - pending validation
#32959 is failing with #35366 repro in PROD, checking it off
#32992 - pending validation
#33203 - pending validation
#33398 - pending validation
#33928 - pending validation
#33958 - pending validation
#34013 - pending validation
#34105 - pending validation
#34202 - pending validation
#34482 - pending validation
#34537 - pending validation
#34624 - pending validation
#34713 - pending validation
#34754 - pending validation
#34779 - pending validation
#34780 - pending validation
#34791 is failing with #34567, repro in PROD, checking it off
#34801 - pending validation
#34860 - pending validation
#34909 - pending validation
#34953 - pending validation
#34971 - pending validation
#34975 is blocked on Desktop with #25790 (comment), checking off
#35119 - pending validation
#35129 - pending validation
#35130 is failing on Android with #35344
#35135 - pending validation
#35162 - checking off per comment #35162 (comment)
#35210 - pending validation
#35267 - pending validation
#35297 - pending validation
#35300 - pending validation

Deploy Blockers:
#35344
#35374
#35389
#35394
#35395
#35396
#35397

[francoisl]

• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] [$500] Personal details - First item in the list is not highlighted when searching for country #35374 fixed and tested, checking off
• Split - List does not scroll up after selecting a split participant #35395 was due to the same issue, fixed as well
• Tags - Numbers are not alphabetically ordered #35421 - not a bug, same behavior as on prod and OldDot
• [$500] Tag - Extra padding above Recent section in Tag list #35423: demoted, minor non-breaking issue
• Send money - Unexpected error when sending money to a Hidden contact #35394: backend fix
• Tag - Inconsistency in tag custom name for "Missing tag" and "Tag no longer valid" #35425: expected behavior according to Yuwen
• Collect admin - New invited user appears four times in workspace chat member list #35407: demoted - neither AndrewR nor I can reproduce, and not breaking anything major anyway
• [HOLD for payment 2024-02-14] [$500] Thread - Messages have a "Leave thread" option #35397: demoted - same is on production.

Working on the remaining blockers, will update this comment.

[mountiny]

Demoted #35389

[kbecciv]

TR is completed!

#30955 is failing with #35339 in web
#31097 is failing with #30778
#33398 is failing with #33544, repro in prod, checking Off
#33958 is failing #35337
#34013 - pending validation
#34105 is failing in IOS with #35403, repro in prod, checking off
#34482 is failing with #35401, repro in prod, checking Off
#34537 is failing with #33680
#34624 - pending validation
#34780 is failing with #34886, repro in prod, checking Off
#34791 is failing with #34567, repro in PROD, checking it off
#34801 - pending validation
#34953 - pending validation in IOS
#34971 is failing with #34306
#34975 is blocked on Desktop with #25790 (comment), checking off
#35130 is failing on Android with #35344
#35135 - pending validation

Deploy Blocker
#35344

[mvtglobally]

Latest Unchecked PRs

#34013 - pending validation. Can you validate internally? #34013 (comment)
#34801 - is failing with #34801 (comment). We are not able to repro consistently. Can you double check this one internally as well?
#34953 - is failing on IOS for 1 tester only. Not able to repro consistently. #34953 (comment).
#34971 is failing with #34306
#35130 is failing on Android with #35344
#35135 - is failing #35433. repro in PROD. checking off

[francoisl]

#34801: left a comment in the PR, I experienced the flashing effect too. I don't think it's worth blocking on this, checking it
#34013: checked internally
#34953: can't repro the crash
#34971: noted - left a comment in the PR to double-check after the deploy
#35344: CP tested internally, all good

[francoisl]

Checklist is clear, going to deploy. There's one fresh crash report in Crashlytics, though I'm pretty sure it's the one we fixed with #35440.

https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues/e9d92dfee0a1b8347102bfce26614cf7?time=last-seven-days&types=crash&sessionEventKey=65B939D003DC00021B15DE028257AD6D_1908399042781465902

[francoisl]