Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-01-31 #35524

Closed
37 tasks done
github-actions bot opened this issue Jan 31, 2024 · 11 comments
Closed
37 tasks done

Deploy Checklist: New Expensify 2024-01-31 #35524

github-actions bot opened this issue Jan 31, 2024 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024

Release Version: 1.4.35-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@francoisl francoisl self-assigned this Jan 31, 2024
@kbecciv kbecciv added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 31, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.35-0 🚀

@MonilBhavsar
Copy link
Contributor

Checking off #32927 (comment) cc @mvtglobally

@roryabraham
Copy link
Contributor

Demoting #35560 and #35570 as non-blockers

@kbecciv
Copy link

kbecciv commented Feb 1, 2024

TR is 55% completed

#30168 is failing on Android #26347
#34505 - pending validation
#35246 - pending validation

Deploy Blockers:
#35559
#35561
#35562
#35580
#35574
#35579
#35569

@mvtglobally
Copy link

Regression is 20% left

Validating CPs
#35563
#35598

Blockers
#35574
#35579
#35580
#35590
#35591
#35593
#35597

@francoisl
Copy link
Contributor

francoisl commented Feb 2, 2024

Checking off #35574 and #35597, fix tested on staging.
Checking off #35593 and #35591, fix tested on staging

@francoisl
Copy link
Contributor

We're down to 3 blockers, I'll be back online later to check on them.

@francoisl
Copy link
Contributor

Fix for #35579 tested on staging, checking off

@mountiny
Copy link
Contributor

mountiny commented Feb 2, 2024

Created an issue for the Android crash to be investigated #35655

@mountiny
Copy link
Contributor

mountiny commented Feb 2, 2024

Noting this switch report on android being up
image
but those spikes has been seen before on Android so wont block on it

All clear! 🎉

@mountiny
Copy link
Contributor

mountiny commented Feb 2, 2024

:shipit:

@mountiny mountiny closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants