[TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #35774

neonbhai · 2024-02-04T15:19:33Z

Details

We migrate the MoneyRequestAmountForm here.
Rest of the pages in the original issue are being removed in #29107

Fixed Issues

$ #32004
PROPOSAL: #32004 (comment)

Tests

Click on FAB
Click on Request Money
Click on Manual
Verify that the Amount input is working.
Verify text can be selected.
Verify a request can be created with the correct Amount

Verify that no errors appear in the JS console

Offline tests

Same as Tests step.

QA Steps

Same as Tests step

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mWeb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

Safari.mp4

MacOS: Chrome / Safari

Web.mp4

MacOS: Desktop

Desktop.mp4

This was resulting in the wrong calculation of isTaxAmountInvalid

Julesssss

@neonbhai I see a couple of lint issues

ishpaul777 · 2024-02-05T11:26:50Z

@neonbhai is this PR only migrates the Amount form, i know other pages are removed/renamed just confirming if this has been discussed i couldn't find any conversation on the issue.

cc @Julesssss

Julesssss · 2024-02-05T11:39:15Z

@neonbhai is this PR only migrates the Amount form, i know other pages are removed/renamed just confirming if this has been discussed i couldn't find any conversation on the issue.

Ah right, yeah the original issue names many files. I'm also confused.

@neonbhai was there any discussion about which files to migrate?

neonbhai · 2024-02-05T11:51:44Z

@Julesssss hi, I had started working on these before realizing the pages I had migrated were being removed. Since the PR was delayed by some time, I had raised this PR and mentioned the situation in the PR description.

I apologize for not communicating the same on the issue 🙇

cc: @ishpaul777

Julesssss · 2024-02-05T12:04:00Z

Ah no problem. So MoneyRequestAmountForm.tsx is the final file that needs to be converted?

ishpaul777 · 2024-02-05T12:10:34Z

MoneyRequestAmountForm.tsx is a independent component, so i think we are good to push this one forward, but we might need to create a new issue (or not close this one) for migrating the rest after the clean up tasks are completed.

neonbhai · 2024-02-05T12:13:35Z

Yes, MoneyRequestAmountForm is in use in the new request page and edit request page. The rest of the pages in the old flow have been deprecated with the money request refactor.

Julesssss · 2024-02-05T12:20:32Z

Alright sounds good. Lets continue with this PR.

ishpaul777 · 2024-02-07T09:26:51Z

Hii @neonbhai, do you an ETA for resolving the type issues in this PR, it's one of the blocking component in #32002 (comment)

neonbhai · 2024-02-10T00:41:41Z

~~Finishing this PR by tomorrow,~~ sorry for the delay

blazejkustra

Still a lot of type errors, other than that looks good 👍

Julesssss

Thanks @neonbhai. Let us know if you need any help with these type issues: https://github.com/Expensify/App/actions/runs/7775010274/job/21200474461?pr=35774

ishpaul777 · 2024-02-15T22:38:14Z

gentle bump @neonbhai, hope you are well

…tion-money-request-pages

We want display the request amount with currency symbol. This necessitates the param type to be in string

…tion-money-request-pages

src/languages/types.ts

neonbhai · 2024-02-17T01:54:15Z

PR ready for review!

ishpaul777

overall looks good 👍, just some minor comments

src/pages/iou/steps/MoneyRequestAmountForm.tsx

Co-authored-by: Ishpaul Singh <[email protected]>

neonbhai · 2024-02-18T15:27:39Z

ready for review! @ishpaul777

ishpaul777 · 2024-02-20T12:33:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-21.at.1.59.52.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-20.at.6.47.31.PM-1.mov

iOS: Native

Screen.Recording.2024-02-20.at.6.22.54.PM-1.mov

iOS: mWeb Safari

Screen.Recording.2024-02-20.at.6.33.57.PM-1.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-20.at.6.19.10.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-21.at.1.47.06.AM.mov

ishpaul777 · 2024-02-20T12:33:16Z

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-21.at.1.59.52.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-20.at.6.47.31.PM-1.mov

iOS: Native

Screen.Recording.2024-02-20.at.6.22.54.PM-1.mov

iOS: mWeb Safari

Screen.Recording.2024-02-20.at.6.33.57.PM-1.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-20.at.6.19.10.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-21.at.1.47.06.AM.mov

ishpaul777

looks good to me!

All yours @Julesssss

OSBotify · 2024-02-21T10:13:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

src/pages/iou/steps/MoneyRequestAmountForm.tsx

OSBotify · 2024-02-26T21:05:50Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:54:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

neonbhai added 9 commits February 1, 2024 20:39

Migrate MoneyRequestAmountForm to typescript

b58badf

Add type for onSelectionChange

8ff4bb2

Update types

2a907cd

Add forwardedRef type

cca5a4a

Prettier

31579a5

Convert underscorejs function to native logic

2e417e6

Fix: Parse currentAmount from string to number

57c2be3

This was resulting in the wrong calculation of isTaxAmountInvalid

Convert isEmpty function to native js logic

81bcb05

Remove underscorejs contains

57a844a

neonbhai requested a review from a team as a code owner February 4, 2024 15:19

melvin-bot bot requested review from eVoloshchak and removed request for a team February 4, 2024 15:19

Julesssss assigned neonbhai Feb 5, 2024

Julesssss removed the request for review from eVoloshchak February 5, 2024 09:46

Expensify deleted a comment from melvin-bot bot Feb 5, 2024

Julesssss requested a review from ishpaul777 February 5, 2024 09:47

Julesssss reviewed Feb 5, 2024

View reviewed changes

ishpaul777 mentioned this pull request Feb 7, 2024

[HOLD] [$250] [TS migration] Migrate 'IOUEditRequest' page to TypeScript #32002

Closed

blazejkustra suggested changes Feb 12, 2024

View reviewed changes

Julesssss reviewed Feb 12, 2024

View reviewed changes

neonbhai added 9 commits February 16, 2024 19:11

Merge branch 'main' of https://github.com/Expensify/App into ts-migra…

53fcc55

…tion-money-request-pages

Update type for formError variable

3147fa6

Add prop for TextInputWithCurrencySymbol

afb6cfe

Update event type for textInputKeyPress

627c2a0

Update text input ref type

5640314

Add type assertion on target element for onMouseDown

89b44e3

Fix imports

a800247

Fix RequestAmountParams type

9d59da8

We want display the request amount with currency symbol. This necessitates the param type to be in string

Merge branch 'main' of https://github.com/Expensify/App into ts-migra…

236afd2

…tion-money-request-pages

neonbhai commented Feb 17, 2024

View reviewed changes

src/languages/types.ts Show resolved Hide resolved

ishpaul777 reviewed Feb 17, 2024

View reviewed changes

src/pages/iou/steps/MoneyRequestAmountForm.tsx Outdated Show resolved Hide resolved

src/pages/iou/steps/MoneyRequestAmountForm.tsx Outdated Show resolved Hide resolved

neonbhai and others added 2 commits February 18, 2024 20:46

Update src/pages/iou/steps/MoneyRequestAmountForm.tsx

3304bce

Co-authored-by: Ishpaul Singh <[email protected]>

Update src/pages/iou/steps/MoneyRequestAmountForm.tsx

cd39fe3

Co-authored-by: Ishpaul Singh <[email protected]>

ishpaul777 approved these changes Feb 20, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss February 20, 2024 20:34

Julesssss approved these changes Feb 21, 2024

View reviewed changes

Julesssss merged commit 302010a into Expensify:main Feb 21, 2024
16 of 17 checks passed

Krishna2323 mentioned this pull request Feb 21, 2024

[HOLD for payment 2024-04-25] [$500] [LOW] Request money - When amount is highlighted, clicking on the page does not deselect the text #36862

Closed

6 tasks

ishpaul777 reviewed Feb 21, 2024

View reviewed changes

src/pages/iou/steps/MoneyRequestAmountForm.tsx Show resolved Hide resolved

neonbhai mentioned this pull request Feb 21, 2024

Amount selection fix #37041

Merged

49 tasks

ishpaul777 mentioned this pull request Feb 21, 2024

Payment issue for E/App PR#37041 #37046

Closed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #35774

[TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #35774

neonbhai commented Feb 4, 2024 •

edited

Loading

Julesssss left a comment

ishpaul777 commented Feb 5, 2024

Julesssss commented Feb 5, 2024

neonbhai commented Feb 5, 2024

Julesssss commented Feb 5, 2024

ishpaul777 commented Feb 5, 2024

neonbhai commented Feb 5, 2024

Julesssss commented Feb 5, 2024

ishpaul777 commented Feb 7, 2024

neonbhai commented Feb 10, 2024 •

edited

Loading

blazejkustra left a comment

Julesssss left a comment

ishpaul777 commented Feb 15, 2024

neonbhai commented Feb 17, 2024

ishpaul777 left a comment

neonbhai commented Feb 18, 2024

ishpaul777 commented Feb 20, 2024 •

edited

Loading

ishpaul777 commented Feb 20, 2024 •

edited

Loading

ishpaul777 left a comment

OSBotify commented Feb 21, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

[TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #35774

[TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #35774

Conversation

neonbhai commented Feb 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Julesssss left a comment

Choose a reason for hiding this comment

ishpaul777 commented Feb 5, 2024

Julesssss commented Feb 5, 2024

neonbhai commented Feb 5, 2024

Julesssss commented Feb 5, 2024

ishpaul777 commented Feb 5, 2024

neonbhai commented Feb 5, 2024

Julesssss commented Feb 5, 2024

ishpaul777 commented Feb 7, 2024

neonbhai commented Feb 10, 2024 • edited Loading

blazejkustra left a comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

ishpaul777 commented Feb 15, 2024

neonbhai commented Feb 17, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

neonbhai commented Feb 18, 2024

ishpaul777 commented Feb 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Feb 20, 2024 • edited Loading

Screenshots/Videos

ishpaul777 left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 21, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

neonbhai commented Feb 4, 2024 •

edited

Loading

neonbhai commented Feb 10, 2024 •

edited

Loading

ishpaul777 commented Feb 20, 2024 •

edited

Loading

ishpaul777 commented Feb 20, 2024 •

edited

Loading