fix: [35383] zoomed large image disappears from preview if triple tap on the bottom of the screen #35931

andreasnw · 2024-02-06T17:52:57Z

Details

Remove offsetY animation, since we only need zoom animation for reset function.

Fixed Issues

$ #35383
PROPOSAL: #35383 (comment)

Tests

Go to https://staging.new.expensify.com/
On a conversation, click on the + button in the compose box
Upload this long image to a conversation
Tap on the preview
Double tap image > Scroll down > Triple tap on the bottom

Verify that no errors appear in the JS console

Offline tests

Go to https://staging.new.expensify.com/
On a conversation, click on the + button in the compose box
Upload this long image to a conversation
Tap on the preview
Double tap image > Scroll down > Triple tap on the bottom

QA Steps

Go to https://staging.new.expensify.com/
On a conversation, click on the + button in the compose box
Upload this long image to a conversation
Tap on the preview
Double tap image > Scroll down > Triple tap on the bottom

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-recording.mp4

Android: mWeb Chrome

mweb.android.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.14.-.2024-02-06.at.23.06.20.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.14.-.2024-02-07.at.00.35.49.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-06.at.23.51.21.mov

MacOS: Desktop

Screen.Recording.2024-02-07.at.00.11.45.mov

melvin-bot · 2024-02-06T17:53:03Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-02-06T17:53:11Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

andreasnw · 2024-02-06T17:55:32Z

I have read the CLA Document and I hereby sign the CLA

eVoloshchak · 2024-02-09T08:50:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

24-02-21-21-22-55_092558.mp4

Android: mWeb Chrome

Screen.Recording.2024-02-21.at.21.30.34.mov

iOS: Native

Screen.Recording.2024-02-21.at.21.37.58.mov

iOS: mWeb Safari

Screen.Recording.2024-02-21.at.21.36.01.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-21.at.21.35.07.mov

MacOS: Desktop

Screen.Recording.2024-02-21.at.21.34.12.mov

eVoloshchak · 2024-02-09T09:10:29Z

src/components/MultiGestureCanvas/index.tsx

@@ -130,7 +130,7 @@ function MultiGestureCanvas({

        if (animated) {
            offsetX.value = withSpring(0, SPRING_CONFIG);
-            offsetY.value = withSpring(0, SPRING_CONFIG);
+            offsetY.value = 0;


The accepted proposal contained a different fix
offsetY.value = withSpring(0, {...SPRING_CONFIG, duration: 0});
Is there a reason you've decided to use offsetY.value = 0?
(Just want to understand this better, this does work fine)

hi @eVoloshchak, my apologies for modifying the approved proposal.

The withSpring(0, {...SPRING_CONFIG, duration: 0}) function is causing a typing error. Given that withSpring is designed for generating animated effects, specifying duration: 0 essentially eliminates the animation entirely.

I've made changes to directly set offsetY.value = 0 instead, which promptly reduces the value to 0 with the same outcome (no animation).

eVoloshchak · 2024-02-13T18:33:48Z

@andreasnw, found this bug is still reproducible when using a different image (https://upload.wikimedia.org/wikipedia/commons/3/3f/Fronalpstock_big.jpg)

Double-tap on the image
Scroll the image completely to the right
Triple tap

Screen.Recording.2024-02-13.at.19.31.28.mov

andreasnw · 2024-02-14T03:33:44Z

hi @eVoloshchak, great catch! to fix those horizontal image cases, we can remove the animation from offsetX.value. i've gone ahead and made that update in the PR. thanks for bringing it up!

simulator-screen-recording-iphone-14-2024-02-14-at-102920_QMKmWeC4.mp4

eVoloshchak · 2024-02-19T20:38:35Z

Not entirely sure we have the best approach, still testing this, will post a review tomorrow

andreasnw · 2024-02-21T04:33:48Z

@eVoloshchak do you have any updates regarding this pull request? Could you provide additional context explaining why it might not be the optimal approach? Would you like to explore an alternative solution?

eVoloshchak

Tests well!

github-actions · 2024-02-22T17:31:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35931/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/35931/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35931/NewExpensify.dmg	https://35931.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rlinoz · 2024-02-22T18:00:14Z

Hey @andreasnw apparently your commits are not signed, could you go over this section in our contribution guide and then retro sign your commits please?

You can try this slack post to retro sign.

remove animation from offestX.value to handle horizontal image cases

andreasnw · 2024-02-23T02:31:54Z

thanks for letting me know, @rlinoz ! i've reviewed the contribution guide and signed my pending pull requests.

OSBotify · 2024-02-23T13:34:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:06:05Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:54:41Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

andreasnw requested a review from a team as a code owner February 6, 2024 17:52

melvin-bot bot requested review from eVoloshchak and removed request for a team February 6, 2024 17:53

andreasnw mentioned this pull request Feb 6, 2024

[$500] [MEDIUM] Zoomed large image disappears from preview if triple tap on the bottom of the screen #35383

Closed

6 tasks

eVoloshchak reviewed Feb 9, 2024

View reviewed changes

andreasnw force-pushed the fix/35383-zoomed_large_image_dissapears_from_preview branch 2 times, most recently from cded1ba to 0691e5d Compare February 14, 2024 12:13

eVoloshchak approved these changes Feb 21, 2024

View reviewed changes

melvin-bot bot requested a review from rlinoz February 21, 2024 20:39

rlinoz added the Ready To Build label Feb 22, 2024

rlinoz approved these changes Feb 22, 2024

View reviewed changes

andreasnw force-pushed the fix/35383-zoomed_large_image_dissapears_from_preview branch from 0691e5d to 0222836 Compare February 23, 2024 02:26

andreasnw added 2 commits February 23, 2024 09:29

fix: remove animation for offsetY.value

9964278

fix: horizontal image cases

6cb78bb

remove animation from offestX.value to handle horizontal image cases

andreasnw force-pushed the fix/35383-zoomed_large_image_dissapears_from_preview branch from 0222836 to 6cb78bb Compare February 23, 2024 02:29

rlinoz merged commit 8d6c699 into Expensify:main Feb 23, 2024
14 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

youssef-lr mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-03-14] [$250] iOS - Image - Maximum zoom is applied after zooming out #37248

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: [35383] zoomed large image disappears from preview if triple tap on the bottom of the screen #35931

fix: [35383] zoomed large image disappears from preview if triple tap on the bottom of the screen #35931

andreasnw commented Feb 6, 2024

melvin-bot bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024 •

edited

Loading

andreasnw commented Feb 6, 2024

eVoloshchak commented Feb 9, 2024 •

edited

Loading

eVoloshchak Feb 9, 2024

andreasnw Feb 9, 2024

eVoloshchak commented Feb 13, 2024

andreasnw commented Feb 14, 2024 •

edited

Loading

eVoloshchak commented Feb 19, 2024

andreasnw commented Feb 21, 2024

eVoloshchak left a comment

github-actions bot commented Feb 22, 2024

rlinoz commented Feb 22, 2024

andreasnw commented Feb 23, 2024

OSBotify commented Feb 23, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

fix: [35383] zoomed large image disappears from preview if triple tap on the bottom of the screen #35931

fix: [35383] zoomed large image disappears from preview if triple tap on the bottom of the screen #35931

Conversation

andreasnw commented Feb 6, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024 • edited Loading

andreasnw commented Feb 6, 2024

eVoloshchak commented Feb 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak Feb 9, 2024

Choose a reason for hiding this comment

andreasnw Feb 9, 2024

Choose a reason for hiding this comment

eVoloshchak commented Feb 13, 2024

andreasnw commented Feb 14, 2024 • edited Loading

eVoloshchak commented Feb 19, 2024

andreasnw commented Feb 21, 2024

eVoloshchak left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 22, 2024

rlinoz commented Feb 22, 2024

andreasnw commented Feb 23, 2024

OSBotify commented Feb 23, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

github-actions bot commented Feb 6, 2024 •

edited

Loading

eVoloshchak commented Feb 9, 2024 •

edited

Loading

andreasnw commented Feb 14, 2024 •

edited

Loading