Deploy Checklist: New Expensify 2024-02-12

[github-actions]

Release Version: 1.4.40-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix: Missing translation for server errors #30073
• Added limit exceed error message with new limit #33601
• [TS migration] Migrate 'SettingsWalletPhysicalCard' page to TypeScript #33641
• [TS migration] Migrate 'CommunicationsLink.js' component to TypeScript #33933
• Load parent report action from withOnyx in report action HOC #34113
• Client-side violations for money request updates #34402
• Migrate the next steps to client side #34450
• Fix form submit behavior #34471
• [TS Migration] Migrate LogOutPreviousUserPage to TS #34777
• Add formatted amount to pay elsewhere #34854
• add testID to chat title for applause automation #34858
• Fix: Duplicated waypoints after dragging #34869
• Wrap the login page background image in a new container to fix it moving #34958
• [Violations] Update tagOutOfPolicy and taxOutOfPolicy  #35048
• [TS migration] Migrate 'WorkspaceInvite' page to TypeScript #35080
• [No QA] [TS migration] Migrate 'ReportDetails' page to TypeScript #35153
• fix: incorrect error message appear when enter Cyrillic letters into Zip field #35230
• [TS migration] Migrate 'App.js' file to TypeScript #35242
• Fix clearing read push notifications on Android (#33568) #35304
• Update logic to display pay button in paid policies #35347
• [TS migration] Migrate 'ConnectBankAccountButton.js' component to TypeScript #35412
• [NO QA][TS migration] Migrate 'react-native-image-picker.js' mock to TypeScript #35416
• [TS migration] Migrate HTMLRenderers components #35462
• [No QA] [TS migration] Migrate 'react-native-pdf.js' mock to TypeScript #35465
• [TS migration] Migrate 'Setup' files to TypeScript #35473
• [No QA][TS migration] Migrate 'react-native-blob-util.js' mock to TypeScript #35476
• fix: EReceipt icon via props no state #35499
• [No QA] [TS migration] Migrate 'netinfo.js' mock to TypeScript #35552
• fix for invalid task title in lhn #35585
• Fix: Room-Invited room avatar looks different #35630
• Add caret icon next to currency select button #35637
• [TS migration] Delete react-native-reanimated mock #35648
• [Snyk] Security upgrade electron from 25.9.4 to 26.6.8 #35656
• Update redirects.csv #35696
• feat: Show "Join/Leave Thread" option for comment actions only #35769
• Add tooltip and change background color of subscription icon #35795
• [TS migration] Migrate react-native-localize mock #35799
• Fix bug with Chat – Message draft disappears after refresh #35805
• [No QA][TS migration] Migrate 'react-native-device-info.js' mock to TypeScript #35811
• fix: Create an optimistic "Renamed" report action #35826
• [Wave 8] [Ideal Nav] Fix iPad navigation #35845
• Fix 0 member format when leaving a room and revisit #35868
• (Desktop) Add left and right arrow key shortcut for back and forward #35874
• Fix context menu still shows on a offline deleted message #35878
• Fix required fields error message shows only after pressing the split button the 2nd time #35881
• [NO QA] ReportSceen perf test refactor #35882
• [No QA][TS migration] Migrate 'fileMock.js' mock to TypeScript #35899
• Refactor OptionRowLHNData to remove deprecated getLinkedTransaction() method #35975
• [TS migration] Changed all the scripts to use ts-node instead of node #36000
• Fix: Bank account icon on transfer balance page does not have rounded corners #36028
• disable downloading EReceipt #36030
• [NoQA] fix broken e2e open search test #36031
• feat: enable report fields on paid workspaces only #36044
• [Task] Fix Assignee MenuItem when Offline #36048
• [Wave 8] [Ideal Nav] goBack update fallback route #36050
• Only get GPS coordinates for scanned receipts #36062
• Show the "Approved" description in request details page #36063
• Fix subscriptions and cards menu doesn't show copy to clipboard option #36110
• Fix avatar error message styling #36111
• Share Code page update #36120
• Update workspace naming from Overview to Profile #36148
• Fix crash on category page when category is out of policy #36157
• [No QA] Add connection types to policy object #36181
• [TS migration] Migrate CardUtilsTest to Typescript #36211
• Fix #36098 Camera doesn't load when trying to smartscan a receipt #36213
• [No QA] remove deprecated patches #36277
• Check for new shouldShowPushNotification flag #36279
• [ImgBot] Optimize images #36291
• [NO QA] Revert a fix for IOU Description Edits - will readd this after, so we can CP just this to staging #36327
• [CP Staging] [Fix] User mention is shown as Hidden #36358
• [CP Staging] Revert typescript migration change #36360
• [CP Staging] Fix listener in options selector #36396
• [CP Staging] Revert "Fix: Duplicated waypoints after dragging" #36405
• [CP Staging] Revert "Update logic to display pay button in paid policies" #36424

Deploy Blockers:

• [HOLD for payment 2024-02-20] Login - Welcome modal is not dismissed after selecting an option #36265
• [HOLD for payment 2024-02-20] [$500] Task – User with the custom name is shown as Hidden in task assignee field #36341
• [HOLD App 35455][$500] Send money - Not here page opens when opening Description in Send money flow #36342
• [HOLD #368997] [$500] Web - New Dot tab reloads every time user switches to another tab #36343
• [$500] Domain name is not dropped when sending text with user mention from same domain #36347
• [HOLD for payment 2024-02-20] [$250] Text with single backtick code block is not rendered correctly #36348
• [HOLD for payment 2024-03-06] [$250] Strikethrough line is white on links and emails #36349
• [HOLD for payment 2024-03-11] Distance - App refreshes when hitting Enter on empty waypoint editor #36363
• [HOLD for payment 2024-02-20] Distance - Unable to change distance by dragging one over another in offline mode #36366
• Room – @Hidden is shown in system message when invite to the Room user with current account #36367
• [HOLD for payment 2024-02-20] [$500] The "Enter" key does not work when editing the "Description" and "Merchant" fields #36370
• [HOLD for payment 2024-02-20] Distance - Distance sequence changes to A-B-B-B when changing the order of distance A-B-A-B #36375
• [HOLD for payment 2024-02-20] [$500] Expense - Pay elsewhere button does not show up for admin after approving the report #36398

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Beamanator]

locking list even though regression tests haven't started, just b/c the list is decently long

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.40-0 🚀

[francoisl]

Demoted 36349, checking it off.

[blimpich]

Demoting 36363.

[kbecciv]

Regression is 25% left

#33601 is pending validation
#34402 is pending validation
#34450 is pending validation
#35048 is failing #36380, repro in Prod, checking Off
#35347 is pending validation
#35412 is pending validation
#35462 is pending validation
#35499 is pending validation
#35585 is pending validation
#35630 is pending validation
#35769 is pending validation
#35881 is pending validation
#36028 asked if can be verified Internally #36028 (comment)
#36030 is pending validation
#36044 is pending validation
#36050 is pending validation
#36062 is pending validation
#36213 is pending validation
#36358 is pending validation
#36360 is pending validation

[bondydaa]

just noting here as well, this blocker is ready for a re-test #36341 (comment)

[francoisl]

Demoting 36366 as edge case, checking it off.

[kavimuru]

Regression is 7% left

#33601 is pending validation in mweb, android and iOS
#34402 is pending validation
#34450 is pending validation
#35347 is pending validation in Desktop, android and iOS
#35412 is pending validation in iOS
#35462 is pending validation in mweb, android and iOS
#35499 is pending validation
#35585 is pending validation in Desktop
#35630 is pending validation in Desktop
#35769 is pending validation in Desktop
#35881 is pending validation in Desktop
#36030 is pending validation
#36044 is pending validation in Desktop
#36050 is pending validation in web desktop and iOS
#36062 is pending validation in Desktop
#36213 is pending validation in Desktop

[Beamanator]

3% regression test left! 🚀 I'll start reviewing blockers very soon

[Beamanator]

Checking off #36342 since it's reproducible in prod

Checking off #36265 b/c its fix got to prod yesterday

Checking off #36341 b/c its fix got to staging and was tested

Checking off #36343 b/c not reproducible in latest staging

Checking off #36375 b/c the fix is now in staging

Checking off #36370 b/c the fix is now in staging

Checking off #36348 b/c the fix is now in staging

Checking off #36367 b/c the fix is now in staging

[kavimuru]

@Beamanator We are confused and QA team is struggling with these 2 PRs #34402 , #34450. It would be great if you can validate these internally. Thanks!

[kbecciv]

TR is completed!
#33601 is failing #36342 and #36352, repro in Prod, checking off
#34402 is pending validation, can you verify internally?
#34450 is pending validation, can you verify internally?
#35048 is failing #36380, checking off, repro in prod
#35347 is failing #34878 in Desktop and Android app, repro in prod, checking off
#35462 is failing #36348 and #36347
#36028 asked to verify internally #36028 (comment)

[mountiny]

#36347 demoted

[mountiny]

checking #34450 off, its adding optimistic next steps, this will get tested by internal submitters overtime

[mountiny]

Same for #34402

[mountiny]

Asked for validating #36028 from someone but checked it off as its minor

[mountiny]

Created new issue for crash on android #36428

[mountiny]

Graphs are good

[mountiny]