update sign in page structure #36803

suneox · 2024-02-19T15:47:02Z

Details

Fixed Issues

$ #36515
PROPOSAL: #36515 (comment)

Tests

On the log in screen, tap on the email field so the keyboards opens
Swipe to the bottom of the page
Swipe to the top of the page
Repeat steps 2 and 3 until the issue appears

Verify user can swipe to the bottom without problems.

Verify that no errors appear in the JS console

Offline tests

QA Steps

On the log in screen, tap on the email field so the keyboards opens
Swipe to the bottom of the page
Swipe to the top of the page
Repeat steps 2 and 3 until the issue appears

Verify user can swipe to the bottom without problems.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-19.at.22.35.20.mov

Android: mWeb Chrome

Screen.Recording.2024-02-19.at.22.04.06.mov

Screen.Recording.2024-02-19.at.22.43.43.mov

iOS: Native

Screen.Recording.2024-02-19.at.22.35.58.mov

iOS: mWeb Safari

Screen.Recording.2024-02-19.at.22.00.07.mov

Screen.Recording.2024-02-19.at.22.42.05.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-19.at.21.58.31.mov

Screen.Recording.2024-02-19.at.22.38.14.mov

MacOS: Desktop

Screen.Recording.2024-02-19.at.22.05.25.mov

melvin-bot · 2024-02-19T15:47:07Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…n-page-structure

jjcoffee · 2024-02-20T14:06:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2024-02-20_15.20.52.mp4

Android: mWeb Chrome

android-chrome-2024-02-20_15.23.28.mp4

iOS: Native

ios-native-2024-02-20_16.17.39.mp4

iOS: mWeb Safari

ios-safari-2024-02-20_15.59.58.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-02-20_15.10.45.mp4

MacOS: Desktop

desktop-app-2024-02-20_15.12.19.mp4

jjcoffee · 2024-02-20T14:08:45Z

src/pages/signin/SignInPage.tsx

@@ -124,7 +126,7 @@ function getRenderOptions({
    };
 }

-function SignInPageInner({credentials, account, activeClients = [], preferredLocale}: SignInPageInnerProps) {
+function SignInPageInner({credentials, account, activeClients = [], preferredLocale, shouldEnableMaxHeight = true}: SignInPageInnerProps) {


Thinking about this, I can't see a good reason to introduce shouldEnableMaxHeight as a prop as SignInPage isn't being used from anywhere else, so we could just set it to false here. Or am I missing something? 😄

@suneox Friendly bump on this question 🙇

Due to SignInPage use default at Router, and re-use at SignInModal so we should set default for a use case Router render

Did you test for that case? I think it would also want the same fix applied, no?

I have test and also provide screenshot in Screenshots/Videos

I meant have you tested for the case where the SignInModal is used in Router? I don't think I agree that it should have a different value for shouldEnableMaxHeight.

I meant have you tested for the case where the SignInModal is used in Router

Yes i have tested both cases using SignInModal at

App/src/libs/Navigation/AppNavigator/PublicScreens.tsx

Lines 21 to 25 in 52b6d70

<RootStack.Screen

name={NAVIGATORS.BOTTOM_TAB_NAVIGATOR}

options={defaultScreenOptions}

component={SignInPage}

/>

and

App/src/pages/signin/SignInModal.tsx

Lines 22 to 30 in 52b6d70

<ScreenWrapper

style={[StyleUtils.getBackgroundColorStyle(theme.PAGE_THEMES[SCREENS.RIGHT_MODAL.SIGN_IN].backgroundColor)]}

includeSafeAreaPaddingBottom={false}

shouldEnableMaxHeight

testID={SignInModal.displayName}

>

<HeaderWithBackButton onBackButtonPress={() => Navigation.goBack()} />

<SignInPage />

</ScreenWrapper>

I don't think I agree that it should have a different value for shouldEnableMaxHeight.

@jjcoffee
We have a different value for SignInPage due to at SignInModal has a HeaderWithBackButton and already set shouldEnableMaxHeight

so when SignInModal reuses a SignInPage as a component we should disable shouldEnableMaxHeight on SignInPage to avoid a double scroll bar (due to shouldEnableMaxHeight will get the screen height + HeaderWithBackButton).

jjcoffee · 2024-02-21T10:00:38Z

@suneox You have conflicts, can you merge main and sort them? 🙏

…n-page-structure

suneox · 2024-02-21T17:28:51Z

@suneox You have conflicts, can you merge main and sort them? 🙏

@jjcoffee thank you for your reminder I have updated

jjcoffee

LGTM! Thanks for the clarifications! 🙇

srikarparsi

lgtm

OSBotify · 2024-02-24T23:05:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:08:50Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:57:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update SignInPage structure

d37d2ad

suneox requested a review from a team as a code owner February 19, 2024 15:47

melvin-bot bot requested review from jjcoffee and removed request for a team February 19, 2024 15:47

suneox mentioned this pull request Feb 19, 2024

[Hold for payment][$500] mWeb - Login - Sometimes I can't reach the bottom of the page #36515

Closed

6 tasks

suneox added 3 commits February 19, 2024 23:02

fix sign page typecheck

4deab03

Merge remote-tracking branch 'upstream/main' into 36515-update-sign-i…

76b746c

…n-page-structure

fix prettier

a4fab45

jjcoffee reviewed Feb 20, 2024

View reviewed changes

suneox added 2 commits February 21, 2024 17:45

Merge remote-tracking branch 'upstream/main' into 36515-update-sign-i…

e469805

…n-page-structure

fix prettier

80863fe

jjcoffee approved these changes Feb 23, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi February 23, 2024 09:09

srikarparsi approved these changes Feb 24, 2024

View reviewed changes

srikarparsi merged commit 5eed632 into Expensify:main Feb 24, 2024
20 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

dukenv0307 mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-03-11] [$500] Login - Two offline indicators in login screen #37336

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update sign in page structure #36803

update sign in page structure #36803

suneox commented Feb 19, 2024

melvin-bot bot commented Feb 19, 2024

jjcoffee commented Feb 20, 2024 •

edited

Loading

jjcoffee Feb 20, 2024

jjcoffee Feb 21, 2024

suneox Feb 21, 2024

jjcoffee Feb 22, 2024

suneox Feb 22, 2024

jjcoffee Feb 22, 2024

suneox Feb 22, 2024

jjcoffee commented Feb 21, 2024

suneox commented Feb 21, 2024

jjcoffee left a comment

srikarparsi left a comment

OSBotify commented Feb 24, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

	<RootStack.Screen
	name={NAVIGATORS.BOTTOM_TAB_NAVIGATOR}
	options={defaultScreenOptions}
	component={SignInPage}
	/>

	<ScreenWrapper
	style={[StyleUtils.getBackgroundColorStyle(theme.PAGE_THEMES[SCREENS.RIGHT_MODAL.SIGN_IN].backgroundColor)]}
	includeSafeAreaPaddingBottom={false}
	shouldEnableMaxHeight
	testID={SignInModal.displayName}
	>
	<HeaderWithBackButton onBackButtonPress={() => Navigation.goBack()} />
	<SignInPage />
	</ScreenWrapper>

update sign in page structure #36803

update sign in page structure #36803

Conversation

suneox commented Feb 19, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 19, 2024

jjcoffee commented Feb 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee Feb 20, 2024

Choose a reason for hiding this comment

jjcoffee Feb 21, 2024

Choose a reason for hiding this comment

suneox Feb 21, 2024

Choose a reason for hiding this comment

jjcoffee Feb 22, 2024

Choose a reason for hiding this comment

suneox Feb 22, 2024

Choose a reason for hiding this comment

jjcoffee Feb 22, 2024

Choose a reason for hiding this comment

suneox Feb 22, 2024

Choose a reason for hiding this comment

jjcoffee commented Feb 21, 2024

suneox commented Feb 21, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 24, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

jjcoffee commented Feb 20, 2024 •

edited

Loading