Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P Distance] Implement bottom up flow rate updates in Auth #36968

Closed
neil-marcellini opened this issue Feb 20, 2024 · 21 comments
Closed

[P2P Distance] Implement bottom up flow rate updates in Auth #36968

neil-marcellini opened this issue Feb 20, 2024 · 21 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Feb 20, 2024

Implement the bottom up flow rate updates in Auth following this plan

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01827ce4ed3e5a3729
  • Upwork Job ID: 1760074243121115136
  • Last Price Increase: 2024-02-20
@neil-marcellini neil-marcellini added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Feb 20, 2024
@neil-marcellini neil-marcellini self-assigned this Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01827ce4ed3e5a3729

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

@neil-marcellini neil-marcellini changed the title [P2P Distance] Implement bottom up flow rate updates in Auth [HOLD 36966][P2P Distance] Implement bottom up flow rate updates in Auth Feb 21, 2024
@neil-marcellini neil-marcellini changed the title [HOLD 36966][P2P Distance] Implement bottom up flow rate updates in Auth [HOLD 36986][P2P Distance] Implement bottom up flow rate updates in Auth Feb 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

@neil-marcellini, @getusha Eep! 4 days overdue now. Issues have feelings too...

@neil-marcellini neil-marcellini added Weekly KSv2 and removed Daily KSv2 labels Feb 26, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2024
@neil-marcellini
Copy link
Contributor Author

Still on hold for a while

@neil-marcellini
Copy link
Contributor Author

On hold

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@neil-marcellini
Copy link
Contributor Author

Still not a priority

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@melvin-bot melvin-bot bot added the Overdue label May 17, 2024
@neil-marcellini
Copy link
Contributor Author

Kicking this one down the road still given that we haven't fully implemented the UpdateMoneyRequestDistanceRate command yet. I'm still not putting it on HOLD because someone could pick this up and work on it if they want.

@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@melvin-bot melvin-bot bot added the Overdue label May 29, 2024
@neil-marcellini
Copy link
Contributor Author

Still haven't had time for this, probably won't for a while 🫤

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@neil-marcellini
Copy link
Contributor Author

Still waiting

@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 18, 2024
@neil-marcellini
Copy link
Contributor Author

Still on hold. I plan to finish distance splits for this project, then check if the team is cool with slowly chipping away at the remaining work to finish it or if it should be paused indefinitely.

@neil-marcellini
Copy link
Contributor Author

Distance splits is almost done, going to pick this up next.

@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 9, 2024
@neil-marcellini
Copy link
Contributor Author

I'm still focused on splits, but plan to jump on this right after, hopefully in the next week or two.

@melvin-bot melvin-bot bot removed the Overdue label Jul 9, 2024
@neil-marcellini
Copy link
Contributor Author

I got a little start on this. It's feeling pretty achievable.

@neil-marcellini
Copy link
Contributor Author

Hey @paultsimura, I've finished the backend PR for this and I went to start implementing the frontend part, then I saw that we still need to make the rate field editor with this issue [$500][P2P Distance] Create UpdateMoneyRequestDistanceRate in App. Would you be interested in adding support for violations following this plan after that issue is done?

I'll get the backend piece deployed and then hold this issue on the rate editor issue.

@neil-marcellini neil-marcellini added the Reviewing Has a PR in review label Jul 17, 2024
@paultsimura
Copy link
Contributor

Hi @neil-marcellini, thanks for the offer.
It depends on the timeframe, because I'm planning to be OOO for one week starting next Tuesday. If the violations can wait for when I'm back, I would be interested in working on it.

@neil-marcellini neil-marcellini removed the Reviewing Has a PR in review label Aug 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2024
@neil-marcellini
Copy link
Contributor Author

I'm going to close this issue since it's for the backend side of things, which are now done. I have created a new issue for the frontend part and assigned it to you [$250] [P2P Distance] Add RBR logic for the bottom up flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants