[HOLD 36985][$500] [P2P Distance] Implement bottom up flow violations in App

[neil-marcellini]

Implement bottom up flow violations following this plan. Please be sure to read and understand the relevant sections of the entire plan as well.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e3e6076dcf3ac3bb
• Upwork Job ID: 1760136030900682752
• Last Price Increase: 2024-03-06
• Automatic offers:
• alitoshmatov | Reviewer | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e3e6076dcf3ac3bb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Implement bottom up flow violations following this plan.

What is the root cause of that problem?

This is part of a new feature.

What changes do you think we should make in order to solve the problem?

This is dependent on #36985, so we should ideally start implementing this issue after the barebone from #36985 (with the rate field in MoneyRequestView) is ready.

1. If the rate is out of workspace - show the error message “Rate not valid for this workspace”

• Define the translations for the error message in the the translation files (Suggested translation - ES: Tasa inválida para este espacio de trabajo)
• Add the translation for the violation to the getViolationTranslation function (This particular violation has name ‘customUnitOutOfPolicy’)

2. Add the violation logic to the Rate field in MoneyRequestView

• Prerequisite: This Rate field should already been built as part of [HOLD for payment 2024-05-02] CRITICAL: [P2P Distance] [$500] Create a new Rate field #36985
• Associate the violation name customUnitOutOfPolicy to the rate field here
• Add the errors to the Rate field by defining the brickRoadIndicator and error of the MenuItemWithTopDescription of the rate, just like we did for other fields like Category here
• Clear the violation optimistically after the user selects a new correct rate. We should add logic to optimistically update transactionViolation error, using getViolationsOnyxData, so if we have customUnitOutOfPolicy violations, and the rate/custom unit now exists, and it's in the policy, we should clear (aka reject) the violation. We can do it similar to what we did with the categoryOutOfPolicy violation here

Those should be the main changes, other minor adjustments can be made during the PR phase.

What alternative solutions did you explore? (Optional)

NA

[koko57]

Commenting to help with the review.

[neil-marcellini]

Thanks for the proposal @dukenv0307, but I'm going to ask @waterim from Callstack to take this one.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[waterim]

Hello, Im Artem from Callstack and I would like to help with this one

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

Hi @waterim! Sorry for the delay, as I was OoO last week. Assigning you now!

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[CortneyOfstad]

@waterim can you provide an update on the ETA here? Do you think you'll have a PR or even a draft by EOD, EOW, etc? Thanks!

[waterim]

Hello @CortneyOfstad, as far as I know this one was on hold for some backend changes, is it off hold now?
if yes, I will prepare a PR during first half if the next week!

[CortneyOfstad]

@neil-marcellini can you confirm if this is the on-hold issue — #36985? This doesn't appear to be BE related, so just wanted to get this clarified 👍

[neil-marcellini]

Yes it should be on hold for #36985. I will update the title. @waterim if you want to collaborate with @koko57 to get started early, you could branch off of her draft PR.

[CortneyOfstad]

PR was linked in on-hold issue here 👍

[CortneyOfstad]

PR is still being reviewed, so no update on this side yet 👍

[CortneyOfstad]

PR is still open and being reviewed — will continue to keep an eye on this 👍

[CortneyOfstad]

Deployed to production 14 hours ago!

[CortneyOfstad]

This can be closed as the on-hold issue finished the 7-day hold for production yesterday! 🎉