[HOLD for payment 2024-03-13] [Wave8] [Simplified Collect] [Workflows] Create Approval page

[lakchote]

We've recently merged the main workflows page.

The task here is to create the Approval page present under the main worfklows page.

It will appear when we click on the > icon under the Add approval menu item:

Expected mockup below:

Technical details can be found here.

[melvin-bot]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[lakchote]

@rushatgabhane will be doing the implementation.

Assigning @allroundexperts as the reviewer.

For context please see discussion here

[trjExpensify]

Wahoo! Let's do it.

[rushatgabhane]

Discussion here for real time - https://expensify.slack.com/archives/C02NK2DQWUX/p1709028046898869?thread_ts=1709017652.394349&cid=C02NK2DQWUX

[luacmartins]

PR is in staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Simplified Collect][Workflows] Select workspace approver #37391

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[allroundexperts]

I feel like this should have double the bounty since this was a feature that took much more time than what a normal bug would take to fix. What do you think @rushatgabhane?

[luacmartins]

Sure, I think that's fair in this case. cc @trjExpensify

[rushatgabhane]

I'm happy with $500 because the implementation was straightforward. But ofcourse, double pay would make me very happy 😆

[luacmartins]

We discussed this internally with the team and we'll keep the bounty at $500 for this one. We understand that there'll inevitably be differences between the level of effort required for each issue, but we think that the current bounty is pretty generous across the board. We appreciate you both working on high value items like this one.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $500 via NewDot
• Reviewer: @allroundexperts owed $500 via NewDot

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

Confirming the payment summary is correct. Both of you can go ahead and request on NewDot. Closing!

[JmillsExpensify]

$500 approved for @allroundexperts

[JmillsExpensify]

$500 approved for @rushatgabhane