Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Invite members - blank row is displayed when removing user in offline mode #37235

Closed
4 of 6 tasks
kbecciv opened this issue Feb 26, 2024 · 7 comments
Closed
4 of 6 tasks
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to 'Invite members' page of a workspace
  2. Invite a user
  3. Apply offline mode
  4. Removed the user

Expected Result:

There shouldn't be any blank rows

Actual Result:

There is a blank row after removing the user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393370_1708984795561.Screen_Recording_2024-02-27_at_12.21.52_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b21db9a428272553
  • Upwork Job ID: 1762247192499994624
  • Last Price Increase: 2024-02-26
@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 26, 2024
@melvin-bot melvin-bot bot changed the title Invite members - blank row is displayed when removing user in offline mode [$500] Invite members - blank row is displayed when removing user in offline mode Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b21db9a428272553

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 26, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 26, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 26, 2024

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 26, 2024

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Feb 26, 2024

I think it's dupe and should be fixed in one PR
Different actual result
But we expect the same result
#37109

@luacmartins luacmartins self-assigned this Feb 26, 2024
@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Feb 26, 2024
@luacmartins
Copy link
Contributor

This is a dupe of #37109. Gonna close since it's known and we're working on fixing it when we implement the remove functionality in Simplified Collect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants