Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Scan - Expense report and transaction report are no longer hidden in LHN when scanning fails #37296

Closed
6 tasks done
kbecciv opened this issue Feb 27, 2024 · 43 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal team

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to workspace chat.
  3. Create a scan request with an invalid receipt that will fail the scanning.
  4. Wait for the request to fail.

Expected Result:

Workspace expense report and transaction report will be hidden in LHN when the scanning fails. (production behavior)

Actual Result:

Workspace expense report and transaction report appear in LHN when the scanning fails.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393871_1709032856428.bandicam_2024-02-27_11-00-21-065__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014b135358baed37a2
  • Upwork Job ID: 1762481990262865920
  • Last Price Increase: 2024-03-26
  • Automatic offers:
    • DylanDylann | Reviewer | 0
    • tienifr | Contributor | 0
@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 27, 2024
@melvin-bot melvin-bot bot changed the title Scan - Expense report and transaction report are no longer hidden in LHN when scanning fails [$500] Scan - Expense report and transaction report are no longer hidden in LHN when scanning fails Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014b135358baed37a2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Feb 27, 2024

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@danieldoglas
Copy link
Contributor

@kbecciv I think this change is intended per testing instructions on https://github.com/Expensify/App/pull/35449/files

@danieldoglas
Copy link
Contributor

Removing the deploy blocker and waiting for QA team to confirm if this was intended or not based on the changes

@DylanDylann
Copy link
Contributor

@danieldoglas Could you help ping the QA team to verify this issue?

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@danieldoglas danieldoglas added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Mar 4, 2024
@danieldoglas
Copy link
Contributor

Added label to retest

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@danieldoglas
Copy link
Contributor

cc @kbecciv

Copy link

melvin-bot bot commented Mar 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@kbecciv
Copy link
Author

kbecciv commented Mar 5, 2024

@danieldoglas Checking

@DylanDylann
Copy link
Contributor

I also can reproduce this bug. Sorry for my mistake here. Waiting for proposal

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@DylanDylann
Copy link
Contributor

@tienifr This PR moved the logic that caused this bug to getOrderedReportIDs function and didn't fix this bug. I checked again and saw that your proposal still be valid. Solution 1 in your proposal looks good to me. Please update the proposal to point out the correct place that caused this bug

@tienifr
Copy link
Contributor

tienifr commented Apr 1, 2024

@DylanDylann
Copy link
Contributor

@tienifr #38656 moved the logic that caused this bug to getOrderedReportIDs function and didn't fix this bug. I checked again and saw that your proposal still be valid. Solution 1 in your proposal looks good to me. Please update the proposal to point out the correct place that caused this bug

As mentioned above. @tienifr's proposal looks good to me

🎀 👀 🎀 C+ reviewed

Copy link

melvin-bot bot commented Apr 1, 2024

Current assignee @danieldoglas is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 1, 2024
@danieldoglas danieldoglas removed the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Apr 1, 2024
Copy link

melvin-bot bot commented Apr 1, 2024

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@danieldoglas danieldoglas added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 1, 2024
Copy link

melvin-bot bot commented Apr 1, 2024

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@danieldoglas danieldoglas removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 1, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

This issue has not been updated in over 15 days. @danieldoglas, @tienifr, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@DylanDylann
Copy link
Contributor

@danieldoglas Could you help to handle the payment for this issue?

@danieldoglas danieldoglas added the Bug Something is broken. Auto assigns a BugZero manager. label May 4, 2024
Copy link

melvin-bot bot commented May 4, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels May 4, 2024
@danieldoglas
Copy link
Contributor

Sorry @DylanDylann, forgot to add the bug label. @MitchExpensify can you please help us out on paying this one? Thanks!

@MitchExpensify
Copy link
Contributor

Payment summary

C $500 @tienifr
C+ $500 @DylanDylann

@MitchExpensify
Copy link
Contributor

Paid and contract ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants