Call OpenPolicyCategoriesPage #37457

luacmartins · 2024-02-28T22:32:59Z

Details

Calls OpenPolicyCategoriesPage to load policy categories

Fixed Issues

$ #36801

Tests

Pre-requisite: an admin account with a policyExpenseChat enabled Collect policy and another workspace.

In OldDot, make sure that the other workspace is set as default
Log into NewDot, and navigate to Workspace > Settings and select the collect policy.
Select the Categories page
Verify that you see the loading spinner
Verify that the categories load and you can see the list of tags

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

web.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

luacmartins · 2024-02-28T23:03:17Z

cc @Expensify/design

melvin-bot · 2024-02-28T23:40:49Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-02-28T23:41:38Z

@s77rt the API commands are still not deployed, so you might have issues testing that part of this PR.

s77rt · 2024-02-29T05:05:45Z

If you are offline you shouldn't see the loading indicator
After getting online a OpenPolicyCategoriesPage request should be made

shawnborton · 2024-02-29T12:32:44Z

Looks good to me!

luacmartins · 2024-03-01T20:30:55Z

Nice catch @s77rt! Updated!

s77rt

NAB comments

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

luacmartins · 2024-03-01T23:09:21Z

Done!

s77rt

Code looks code. Minor requested changes

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

luacmartins · 2024-03-04T15:04:23Z

Updated!

s77rt · 2024-03-04T16:38:50Z

Code looks good! Let me know when the backend PRs are merged so I can test

luacmartins · 2024-03-05T14:17:11Z

The API should be available in staging.

s77rt · 2024-03-05T16:47:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2024-03-05T16:51:11Z

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

+    useEffect(() => {
+        fetchCategories();
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);


Suggested change

useEffect(() => {

fetchCategories();

// eslint-disable-next-line react-hooks/exhaustive-deps

}, []);

useEffect(

fetchCategories,

// eslint-disable-next-line react-hooks/exhaustive-deps

[],

);

NAB. No need to create an anonymous function

melvin-bot · 2024-03-05T16:52:35Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-03-05T20:04:09Z

API is in production. Removing hold and merging.

melvin-bot · 2024-03-05T20:05:51Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-03-05T20:09:49Z

all tests passed

OSBotify · 2024-03-05T20:10:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-06T22:05:36Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-07T23:51:36Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

call method

9c0f565

luacmartins self-assigned this Feb 28, 2024

luacmartins changed the title ~~Call OpenPolicyCategoriesPage~~ [HOLD Web-E #41065 and Auth #10050] Call OpenPolicyCategoriesPage Feb 28, 2024

add loading indicator

fedb40d

luacmartins added the Design label Feb 28, 2024

luacmartins added 3 commits February 28, 2024 16:04

use ActivityIndicator

f3faf18

fix lint

208efe2

refactor code

cf27c93

luacmartins marked this pull request as ready for review February 28, 2024 23:40

luacmartins requested a review from a team as a code owner February 28, 2024 23:40

melvin-bot bot removed the request for review from a team February 28, 2024 23:40

melvin-bot bot requested a review from s77rt February 28, 2024 23:40

luacmartins added 3 commits March 1, 2024 13:16

Merge branch 'main' into cmartins-loadCategories

f67f764

add offline behavior

5d03fbc

fix style

2ee1dfe

s77rt suggested changes Mar 1, 2024

View reviewed changes

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx Outdated Show resolved Hide resolved

use const

54943cb

luacmartins requested a review from s77rt March 1, 2024 23:09

s77rt suggested changes Mar 2, 2024

View reviewed changes

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx Outdated Show resolved Hide resolved

luacmartins added 2 commits March 4, 2024 08:02

Merge branch 'main' into cmartins-loadCategories

1385ed6

simplify conditions/

2c0afdc

luacmartins requested a review from s77rt March 4, 2024 15:03

luacmartins changed the title ~~[HOLD Web-E #41065 and Auth #10050] Call OpenPolicyCategoriesPage~~ [HOLD Web-E #41065] Call OpenPolicyCategoriesPage Mar 5, 2024

s77rt approved these changes Mar 5, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg March 5, 2024 16:52

jasperhuangg approved these changes Mar 5, 2024

View reviewed changes

luacmartins changed the title ~~[HOLD Web-E #41065] Call OpenPolicyCategoriesPage~~ Call OpenPolicyCategoriesPage Mar 5, 2024

luacmartins merged commit 7a56d16 into main Mar 5, 2024
19 checks passed

luacmartins deleted the cmartins-loadCategories branch March 5, 2024 20:04

melvin-bot bot added the Emergency label Mar 5, 2024

luacmartins removed the Emergency label Mar 5, 2024

github-actions bot mentioned this pull request Mar 6, 2024

Deploy Checklist: New Expensify 2024-03-06 #37845

Closed

63 tasks

izarutskaya mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner #37904

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-14] [Wave8] [Simplified Collect] Fetch collect workspace data when opening settings #36801

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Call OpenPolicyCategoriesPage #37457

Call OpenPolicyCategoriesPage #37457

luacmartins commented Feb 28, 2024 •

edited

Loading

luacmartins commented Feb 28, 2024

melvin-bot bot commented Feb 28, 2024

luacmartins commented Feb 28, 2024

s77rt commented Feb 29, 2024

shawnborton commented Feb 29, 2024

luacmartins commented Mar 1, 2024

s77rt left a comment

luacmartins commented Mar 1, 2024

s77rt left a comment

luacmartins commented Mar 4, 2024

s77rt commented Mar 4, 2024

luacmartins commented Mar 5, 2024

s77rt commented Mar 5, 2024

s77rt Mar 5, 2024

melvin-bot bot commented Mar 5, 2024

luacmartins commented Mar 5, 2024

melvin-bot bot commented Mar 5, 2024

luacmartins commented Mar 5, 2024

OSBotify commented Mar 5, 2024

OSBotify commented Mar 6, 2024

OSBotify commented Mar 7, 2024

Call OpenPolicyCategoriesPage #37457

Call OpenPolicyCategoriesPage #37457

Conversation

luacmartins commented Feb 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

luacmartins commented Feb 28, 2024

melvin-bot bot commented Feb 28, 2024

luacmartins commented Feb 28, 2024

s77rt commented Feb 29, 2024

shawnborton commented Feb 29, 2024

luacmartins commented Mar 1, 2024

s77rt left a comment

Choose a reason for hiding this comment

luacmartins commented Mar 1, 2024

s77rt left a comment

Choose a reason for hiding this comment

luacmartins commented Mar 4, 2024

s77rt commented Mar 4, 2024

luacmartins commented Mar 5, 2024

s77rt commented Mar 5, 2024

Reviewer Checklist

Screenshots/Videos

s77rt Mar 5, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Mar 5, 2024

luacmartins commented Mar 5, 2024

melvin-bot bot commented Mar 5, 2024

luacmartins commented Mar 5, 2024

OSBotify commented Mar 5, 2024

OSBotify commented Mar 6, 2024

OSBotify commented Mar 7, 2024

luacmartins commented Feb 28, 2024 •

edited

Loading