[HOLD for payment 2024-03-14] Chat - Console error shows up when sending message with mention or text

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.45-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Send a message with mention or emoji.

Expected Result:

No console error will show up.

Actual Result:

Console error shows up.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6396439_1709169118643.bandicam_2024-02-29_08-17-23-655.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

We (Applause) this bug might be related to #vip-vsb
cc @quinthar

[m-natarajan]

@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[MonilBhavsar]

Discussing it here
https://expensify.slack.com/archives/C01GTK53T8Q/p1709208081154149

[MonilBhavsar]

Most probably not a blocker.
To fix the issue we have two options -

1. Degrade react-native-reanimated that was updated here [New Architecture] Upgrade react-native-reanimated #36404
2. Fix the issue in react-native-reanimated. If node.children is not an array, we break https://github.com/software-mansion/react-native-reanimated/blob/06231465a93e7650f0c4c66035f48dcadbe2467a/src/reanimated2/layoutReanimation/web/domUtils.ts#L170

[MonilBhavsar]

Not a blocker, just a console error

[MonilBhavsar]

Upstream PR is merged. We can update our version of react-native-reanimated once the fix is released

[tomekzaw]

The fix has been released in Reanimated 3.7.2, we will submit a PR with the bump.

[MonilBhavsar]

@tomekzaw happy to assign an engineer to the issue who will be submitting the PR

[filip-solecki]

Hi @MonilBhavsar! I am Filip from SWM and I will work on this!

[MonilBhavsar]

Thanks Filip! Assigned you to issue

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade react-native-reanimated to 3.7.2 #37679

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@filip-solecki] Determine if we should create a regression test for this bug.
• [@filip-solecki] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MonilBhavsar]

I think we can close this as no payment is required. Thanks all!

[mkhutornyi]

@MonilBhavsar I reviewed PR fixing this issue.

[MonilBhavsar]

Ah okay! Given a version bump, I think $125 is a fair amount. Do you agree?

[mkhutornyi]

Not sure if this is special case but I am seeing that flatten internal review fee applied in other issues.
i.e. #35999 (comment) for svg version bump
Though, I am happy with whatever team decides.

[mkhutornyi]

Another instance: #36187 (comment)
This is also reanimated version bump and even same as our case.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[anmurali]

@MonilBhavsar what do you think here? I believe I need to create a manual Upwork offer to pay @mkhutornyi based on the final amount you decide!

[MonilBhavsar]

Given recent discussion on bounties https://expensify.slack.com/archives/CC7NECV4L/p1709812877445629
I think this was a minor version bump and testing the console error on sending a message. I feel like $250 is a fair bounty.
Other than previous occurrences, if there is other reason for the bounty, we would be happy to evaluate and double it.

[anmurali]

https://www.upwork.com/nx/wm/offer/101507041
@mkhutornyi can you accept and then DM me on slack so I can pay it. Gonna close the issue now.