[HOLD for payment 2024-03-19] [HOLD for payment 2024-03-18] By clicking on highlighted WS user, the checkbox is not selected or opening the details of the member

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.49-0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Access staging.new.expensify.com
2. Sign into an account
3. Create a workspace
4. Go to WS settings and add members
5. Tap on the users highlighted name

Expected Result:

User expects the checkbox to highlight when the user selects the name, or a redirect

Actual Result:

The checkbox does not highlight when the user clicks on the members name, clicking on the name "highlights" as if something should happen, but nothing does.
NOTE : In production checkbox getting selected

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6406307_1709857752247.WS_user_does_not_highlight.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kavimuru]

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[ahmedGaber93]

I think it is related to #37715 and will fix in a follow up issue #37927.
to fix this we need to navigate to user profile on item click and keep select by checkbox only by add Navigation.navigate(ROUTES.PROFILE.getRoute(item.accountID)); before return here

[marcaaron]

cc @luacmartins @burczu

[marcaaron]

@ahmedGaber93 I don't see this issue in that list so assuming this is a blocker unless @luacmartins says otherwise.

[ahmedGaber93]

@marcaaron
I think it is the No. 1

Navigate to global profile if not an admin of paid policy. We shouldn't just early return here, instead let's navigate the admin of a free policy to the global profile, like we do above.

[luacmartins]

Yes, that's the first issue. The policy in the test video is a free policy (we can tell by the pages that are visible), so we just have an early return there. I can work on a quick fix.

[luacmartins]

PR is merged

[luacmartins]

Tested in staging, it's a pass!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.49-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix free policy member selection #37948

If no regressions arise, payment will be issued on 2024-03-18. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: #35715 workspace member details page #37715
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: we were aware of the issue, but since this a new feature we're still building part of the functionality, which is the case here.
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug. N/A
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix free policy member selection #37948

If no regressions arise, payment will be issued on 2024-03-19. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

This feature is still a WIP so I don't think we need to worry about the checklist above now. We're addressing all these issues in follow ups.