Deploy Checklist: New Expensify 2024-03-13

[github-actions]

Release Version: 1.4.52-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Delay in removing 'New' marker After deleting newly sent message #25771
• [TS migration] Migrate 'GrowlNotification' component to TypeScript #32942
• Allow accessing the members page in a thread #34993
• Migrate 'SettingsProfile' page to TypeScript #35446
• fix: Approved expense preview does not show GBR when submitter needs to add a bank account #35486
• [HelpDot] add bottom margin to info box #36721
• [TS migration] Migrate 'NewTask' page to TypeScript #36886
• LHN list re-render #36927
• [TS migration] Migrate 'AddPlaidBankAccount.js' component to TypeScript #37034
• [NoQA] [TS migration] Migrate checkDeployBlockersTest to Typescript #37035
• [TS migration] Migrate VideoPlayerContexts component files to TypeScript #37134
• Ideal nav v2 workspaces #37421
• fix: Selected category is not ticked when it appears in the search result #37479
• [No QA] [TS migration] Migrate 'GooglePlacesUtils.perf-test.js' , 'merge.js' , 'adbTypeText.js' , adbBackspace.js' , 'removeInvisibleCharacters.js' test to TypeScript #37676
• Feat/categories bulk actions #37734
• Fix cross platform concern of the improve flagging feature #37754
• [TS migration] Migrate 'Composer.stories.js', 'DragAndDrop.stories.js', 'Form.stories.js' and 'RadioButtonWithLabel.stories.js' stories to TypeScript #37820
• [Simplified Collect][Taxes] Create WorkspaceTaxesPage #37870
• Refactor HeaderView to access parentReportAction from props #37913
• Updated button specification with Icon #37966
• Scroll highlight feature for workspace member page #38036
• FIX: Performance and heat issues on the 'Troubleshoot' page #38093
• Add avatarUrl to the Report TS type definitions #38108
• Fix/37289: Incorrect tag in split bill view #38111
• Fix: Misaligned vertical metrics ExpensifyNewKansas font on OS/2 #38116
• Fix: App switches to Expensify when create room under the same workspace #38120
• Fix missing emojis in suggestion after changing skin color #38134
• Integrate OpenPolicyMoreFeaturesPage command #38135
• Add "Create Tag" page #38158
• [No QA] Add Jon to provisioning profile #38193
• fix: expensify billing page #38204
• fixes enter click to select the authorized payer #38221
• Add new Policy prop type for avatarURL #38223
• [NoQA] Update the Avatar Edit icon border colour #38227
• [NO QA] Update SSO documentation for dev env #38236
• [CP Staging] Fix icons after regression #38275
• [CP Staging] Fix contact method back navigation #38308
• [CP Staging] Fix: Not here page shows up after deleting workspace #38321
• [CP Staging] fix profile screen OfflineIndicator has extra margin ios #38343
• [CP Staging] Fix share somewhere title #38348
• [CP Staging] fix(38362): add optional chain for stopasync video ref #38364

Deploy Blockers:

• [HOLD for payment 2024-03-22] [HOLD for payment 2024-03-20] [$500] Thread - Thread header shows "Unavailable workspace" #38171
• Split scan - Empty tax row in split confirmation page which leads to crash #38260
• [$250] [HOLD for payment 2024-03-29] Newly added tag is not arranged in alphabetical order #38261
• [HOLD for payment 2024-04-05] [$250] [Categories] - Category row is not grayed out entirely when disabled offline #38262
• [HOLD for payment 2024-03-25] Profile avatar is not aligned within highlighted circle #38263
• [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] Web - Chat - When hovering over a message, reply, edit and menu icons are displayed smaller #38264
• [$250] [Tags] Newly added tag status is disabled and refreshing the page changes to enabled #38265
• [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] IOU - Add stop button is not aligned in the center #38266
• [HOLD for payment 2024-03-26] [Wave Collect] [Ideal Nav] Chats - Only deleted workspace chats are shown in Chats after deleting the workspace #38277
• [Ideal Nav] WS switcher - Delayed transition of breadcrumbs from Workspace / Chat to Expensify / Chat #38281
• [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] Profile Pic or WS Pic - Rotate button is cut off and very small #38284
• [$500] Workspace - App does not open WS chat after creating a new workspace and returning to Chats #38286
• [HOLD for payment 2024-03-26] IOU - BNP buttons are smaller and narrower #38287
• [HOLD for payment 2024-03-25] [Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline #38289
• [Wave Collect] [Workflows] Authorized payer - Admin list is blank if Members tab is not visited before #38290
• [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] Bank account - "Connect online with Plaid" is less indented than "Connect manually" #38291
• [HOLD for payment 2024-04-05] [$250] Tooltips - Tooltips on Desktop overlap with App window "dots" #38292
• [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$500] Email Replaces Workspace Room Title When Selecting Admin or Announcement in "Share Somewhere" #38294
• [HOLD for payment 2024-03-22] [$250] Settings - Back button looped when navigated on Contact Methods page several #38296
• [HOLD for payment 2024-04-05] [$250] Chats - Expensify / Chats is not aligned on the same line #38298
• Distance - Distance rate changes to personal expense distance rate after editing distance #38299
• Android - Not here page shows up after deleting workspace #38301
• [HOLD for payment 2024-03-25] Invite - Selected contacts with names disappeared from the invite listing page #38324
• [HOLD for payment 2024-04-02] [$500] IOS- Extra margin below offline indicator in Profile page #38328
• Profile - Copy button next to email is smaller than the current button on production #38333
• [Awaiting checklist and C+ payment][$500] Android - Sign-in page flickers after using autofill #38347
• Split - Split button is smaller than the split button on production #38351
• [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$500] App crashes when navigating to another report while playing a video #38362
• Settings - The share code and status icons are too close to the browser address bar #38366
• Chat - New chat isn't showing in the LHN nor in the search #38367

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.52-0 🚀

[kavimuru]

Regression is 68% progress.
#35446 failing with #38296

[luacmartins]

Checking off #38261. Demoted to NAB

[luacmartins]

Checking off #38262. Demoted to NAB

[luacmartins]

Checking off #38281. Demoted to NAB.

[luacmartins]

Checking off #38286. Demoted to NAB

[luacmartins]

Checking off #38284. Fixed in staging.

[luacmartins]

Checking off #38296. Fixed in staging.

[rlinoz]

Demoting #38324

[marcaaron]

Demoting #38347

[kavimuru]

Regression is 12% left in the TR

#35446 failing with #38296
#32942 failing with #38350 repro in PROD checking it off
#34993 failing with #38324
#36721 production pr checking it off
#37754 failing with #37332 repro in PROD checking it off
#37820 failing with #38331
#38135 failing with #38309 repro in PROD checking it off
#36721 production pr - checking it off
#37035 Seems no QA required (unit test) , checked it off.

The following are yet to be validated.
#37134
#37421
#37734
#37754

[luacmartins]

Checking off #38294. Fixed in staging

[luacmartins]

Checking off #35446. We fixed #38296 in staging.

[luacmartins]

Checking off #34993. The issue exists in another flow, just not this one because we're introducing the feature in this release - see https://expensify.slack.com/archives/C01GTK53T8Q/p1710442015732539?thread_ts=1710440897.718239&cid=C01GTK53T8Q

[luacmartins]

Checking off #37820. It only migrates Storybook components and we have an issue to fix that.

[luacmartins]

Checking off #38328. Fixed in staging.

[luacmartins]

Checking off #38301. Demoted to NAB.

[kavimuru]

Regression is at 95%.
unchecked PRs:
#35446 failing with #38296
#34993 failing with #38324
#37754 failing with #37332 and #38359 repro in PROD checking it off
#37820 failing with #38331
#37134 failing with #38207 repro in PROD checking it off
#37421 failing with #38298, #38263
#37734 failing with #38262

[luacmartins]

Checking off #37421. The reported issues are minor and will be worked on individually.

[luacmartins]

Checking off #37734. We have a PR to fix the small issue.

[luacmartins]

Checking off #38321. It didn't fully resolve the issue, but we kept the issue open to investigate.

[luacmartins]

Checking off #38362. Fixed in staging.

[luacmartins]

@kavimuru is regression done?

[mvtglobally]

Regression is Completed

Open Blocker
#38367

[Beamanator]

Checking off Chat - New chat isn't showing in the LHN nor in the search b/c we couldn't reproduce on latest staging

[Beamanator]