[PAID] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38355

tgolen · 2024-03-14T20:14:34Z

This is coming from #27262. You can read the issue description there to get context behind the problem being solved and the mess being cleaned up.

Problem

ReportUtils.getIOUReportActionDisplayMessage() is called from a view component. It contains logic which calls const transaction = TransactionUtils.getTransaction(originalMessage.IOUTransactionID ?? ''); (a deprecated method).

Why this is important to fix

It maintains more pure and exact flow of data through the react application. If the view is using transaction data, then it needs to subscribe to the transaction in Onyx so that it's assured that the transaction object will never be stale or out-of-date.

Solution

Pass transaction as a parameter to getIOUReportActionDisplayMessage() and get the parameter from withOnyx() in the view component.
Remove the deprecated method completely

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cae110240999840b
Upwork Job ID: 1768370164615811072
Last Price Increase: 2024-03-14
Automatic offers:

hoangzinh | Reviewer | 0
FitseTLT | Contributor | 0

Issue Owner

Current Issue Owner: @strepanier03

The text was updated successfully, but these errors were encountered:

melvin-bot · 2024-03-14T20:14:39Z

Job added to Upwork: https://www.upwork.com/jobs/~01cae110240999840b

melvin-bot · 2024-03-14T20:14:44Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

melvin-bot · 2024-03-14T20:14:47Z

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

FitseTLT · 2024-03-14T20:21:44Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter

What is the root cause of that problem?

Enhancement

What changes do you think we should make in order to solve the problem?

Update getIOUReportActionDisplayMessage to accept transaction as a parameter instead of this

App/src/libs/ReportUtils.ts

Lines 4958 to 4959 in 02e8025

    
           const transaction = TransactionUtils.getTransaction(originalMessage.IOUTransactionID ?? ''); 
        
           const transactionDetails = getTransactionDetails(!isEmptyObject(transaction) ? transaction : null);

and pass transaction from withOnyx (using transactionID action.originalMessage.IOUTransactionID) for REportactionItem here

And for context menu action we will subscribe to transaction in here

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 280 to 284 in 02e8025

    
           }, 
        
           reportActions: { 
        
               key: ({originalReportID}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, 
        
               canEvict: false, 
        
           },

we will pass reportActions and reportActionID to the key and we will subscribe to transaction with transactionID we get from the report action's originalMessage.IOUTransactionID and pass the transaction to onPress in the payload when the context menu item is copy to clipboard ( textTranslateKey=='reportActionContextMenu.copyToClipboard') here

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 264 to 265 in 02e8025

    
           onPress={(event) => interceptAnonymousUser(() => contextAction.onPress?.(closePopup, {...payload, event}), contextAction.isAnonymousAction)} 
        
           description={contextAction.getDescription?.(selection) ?? ''}

and we will pass the transaction when we call getIOUReportActionDisplayMessage

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 366 to 367 in 02e8025

    
           const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction); 
        
           Clipboard.setString(displayMessage);

What alternative solutions did you explore? (Optional)

for the context menu ,of course we can omit the transaction parameter and continue the current method of fetching transaction as we are currently doing because we don't have stale data worry for it as the function will be executed when the user presses copy to clipboard not when context menu component is first rendered 👍

allgandalf · 2024-03-14T20:25:30Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter

What is the root cause of that problem?

We want to update getIOUReportActionDisplayMessage as getTransaction is depricated

App/src/libs/ReportUtils.ts

Line 4928 in aca0f8c

    
           function getIOUReportActionDisplayMessage(reportAction: OnyxEntry<ReportAction>): string {

What changes do you think we should make in order to solve the problem?

First we need to update getIOUReportActionDisplayMessage to accept one additional prop :

function getIOUReportActionDisplayMessage( transaction OnyxEntry<Transaction>): string {

Then remove the reportAction references as we get it from component:

App/src/libs/ReportUtils.ts

Lines 4958 to 4959 in aca0f8c

    
           const transaction = TransactionUtils.getTransaction(originalMessage.IOUTransactionID ?? ''); 
        
           const transactionDetails = getTransactionDetails(!isEmptyObject(transaction) ? transaction : null);

Finally we need to get transaction parameter with withOnyx in each component and pass it, currently we use getIOUReportActionDisplayMessage in :

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 61 in aca0f8c

iouMessage = ReportUtils.getIOUReportActionDisplayMessage(action);

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 366 in aca0f8c

    
           const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction);

What alternative solutions did you explore? (Optional)

N/A

Krishna2323 · 2024-03-14T20:26:37Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter

What is the root cause of that problem?

Enhancement

What changes do you think we should make in order to solve the problem?

We need to pass transaction from these two places, in ReportActionItemMessage we can use withOnyx & in ContextMenuActions we need to use Onyx.connect.
We will use reportAction.originalMessage.IOUTransactionID to get the data fro Onyx.

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 61 in 2737e44

iouMessage = ReportUtils.getIOUReportActionDisplayMessage(action);

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 366 in 2737e44

    
           const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction);

Here we need to accept transaction prop and remove the line.

App/src/libs/ReportUtils.ts

Lines 4925 to 4928 in 2737e44

    
           /** 
        
            * Return iou report action display message 
        
            */ 
        
           function getIOUReportActionDisplayMessage(reportAction: OnyxEntry<ReportAction>): string {

App/src/libs/ReportUtils.ts

Line 4958 in 2737e44

    
           const transaction = TransactionUtils.getTransaction(originalMessage.IOUTransactionID ?? '');

Result

Alternative

Instead of adding additional prop, we can utilize the transactions we have in ReportUtils, we have already connected to Onyx for transactions. We can use it like

allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${iouMessage?.IOUTransactionID}`] ?? ({} as Transaction)

App/src/libs/ReportUtils.ts

Lines 499 to 509 in 2737e44

    
           let allTransactions: OnyxCollection<Transaction> = {}; 
        
           Onyx.connect({ 
        
               key: ONYXKEYS.COLLECTION.TRANSACTION, 
        
               waitForCollectionCallback: true, 
        
               callback: (value) => { 
        
                   if (!value) { 
        
                       return; 
        
                   } 
        
                   allTransactions = Object.fromEntries(Object.entries(value).filter(([, transaction]) => transaction)); 
        
               }, 
        
           });

allgandalf · 2024-03-14T20:28:23Z

Updated Proposal

Removed the reference of reportAction from the new function in my proposal

Krishna2323 · 2024-03-14T20:33:02Z

Proposal Update

Added minor detail.
We will use reportAction.originalMessage.IOUTransactionID to get the data fro Onyx.

tgolen · 2024-03-14T20:37:52Z

@Krishna2323 Why do you suggest using Onyx.connect() in ContextMenuActions.tsx instead of withOnyx?

FitseTLT · 2024-03-14T20:42:29Z

In context menu action the funtion is called when the user press copy to clipboard and the transaction we get with getTransaction is the uptodated one why do we even need connect don't get it we should make the transaction parameter optional and whenever we access it from components we pass it from withOnyx and for others like context menu action we just fetch the transaction as we are using it currently @tgolen

tgolen · 2024-03-14T20:47:40Z

@FitseTLT I think it's better to connect the context menu to onyx to get the data it needs:

This is how data is supposed to flow through a react application (from the top-down, passed via components), so it is following standard practices
It presents a good pattern in our code for others to follow (engineers will ironically only choose bad patterns to follow. eg. ReportUtils.getPolicy() is the next one to clean up).
Even if the transacation is technically up-to-date in that instance, it's still not promoting proper patterns, so I'd rather do it correctly

All of this results in higher-quality, easier to maintain, easier to debug code across the app.

FitseTLT · 2024-03-14T21:00:49Z

Update based on #38355 (comment)

Krishna2323 · 2024-03-14T21:19:50Z

@tgolen, I think we can simply use the transactions from Onyx which we already have in ReportUtils to get the transaction.
We are already using it in two places like that in ReportUtils

App/src/libs/ReportUtils.ts

Line 2267 in 2faffcd

    
           const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${iouMessage?.IOUTransactionID}`] ?? ({} as Transaction);

App/src/libs/ReportUtils.ts

Line 5072 in 2faffcd

    
           const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`] ?? {};

I have updated my proposal

nkdengineer · 2024-03-15T05:44:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update getIOUReportActionDisplayMessage to accept the transaction as a parameter

What is the root cause of that problem?

We should pass transacation as parameter and get it via withOnyx to the component re-render when the transaction is changed

What changes do you think we should make in order to solve the problem?

In getIOUReportActionDisplayMessage function, add an extra param transaction

function getIOUReportActionDisplayMessage(reportAction: OnyxEntry<ReportAction>, transaction: OnyxEntry<Transaction>): string {

and then we can remove this line

App/src/libs/ReportUtils.ts

Line 4983 in 4e599b2

const transaction = getTransaction(originalMessage.IOUTransactionID ?? '');

Get transaction via withOnyx in ReportActionItemMessage

export default withOnyx<ReportActionItemMessageProps, ReportActionItemMessageOnyxProps>({
    transaction: {
        key: ({action}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${(action.originalMessage as IOUMessage).IOUTransactionID ?? '0'}`,
    },
})(ReportActionItemMessage);

Add transaction in ContextMenuActionPayload type

transaction?: OnyxEntry<Transaction>;

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 66 in 4e599b2

type ContextMenuActionPayload = {

Get transaction via withOnyx in BaseReportActionContextMenu

withOnyx<BaseReportActionContextMenuProps, BaseReportActionContextMenuTransactionOnyxProps>({
    transaction: {
        key: ({reportActions, reportActionID}) => {
            const reportAction = reportActions?.[reportActionID];
            return `${ONYXKEYS.COLLECTION.TRANSACTION}${(reportAction?.originalMessage as IOUMessage)?.IOUTransactionID}`;
        },
    },
})(

And then add transaction into payload here

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Line 230 in 4e599b2

const payload: ContextMenuActionPayload = {

Update the test for getIOUReportActionDisplayMessage function by creating a random transaction and pass it into getIOUReportActionDisplayMessage function

const transaction = createRandomTransaction(1);

await waitForBatchedUpdates();
await measureFunction(() => ReportUtils.getIOUReportActionDisplayMessage(reportAction, transaction));

https://github.com/nkdengineer/App/blob/4e599b2cd6061b52d3964dc69e7575e210f0581d/tests/perf-test/ReportUtils.perf-test.ts#L202

Test branch: https://github.com/nkdengineer/App/tree/fix/38355

What alternative solutions did you explore? (Optional)

NA

hoangzinh · 2024-03-15T10:05:12Z

@FitseTLT @Krishna2323 @GandalfGwaihir. Thanks for the proposals, everyone. There are a few things that don't look good to me in your proposals:

@FitseTLT your proposal overall looks good. But the way you pass transactions in BaseReportActionContextMenu doesn't look good to me. I prefer passing it in the context action payload as described in @nkdengineer here
@Krishna2323 your proposal hasn't satisfied the requirements where we should avoid using Onyx.connect here.
@GandalfGwaihir your proposal is not correct because ContextMenuActions is not a component, so we can't "we need to get transaction parameter with withOnyx in each component and pass it" as you mentioned

hoangzinh · 2024-03-15T10:08:15Z

I'm inclined to @nkdengineer's proposal here #38355 (comment):

It satisfies the requirements in the description.
It's correct to me.
It's detailed

🎀👀🎀 C+ reviewed

melvin-bot · 2024-03-15T10:08:24Z

Current assignee @tgolen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

FitseTLT · 2024-03-15T11:29:28Z

But the way you pass transactions in BaseReportActionContextMenu doesn't look good to me. I prefer passing it in the context action payload as described in @nkdengineer #38355 (comment)

Really don't get it @hoangzinh I think you misunderstood me I am proposing same as the selected proposal and I did propose to pass the transaction in the payload of onPress callback here is the a text from my proposal

pass the transaction to onPress in the payload when the context menu item is copy to clipboard ( textTranslateKey=='reportActionContextMenu.copyToClipboard') here

I really think you should give my proposal a second look. I have stated what should be done in detail same as the selected proposal and giving code snippet is not a must when a contributor provides what should be done in detail as I did
This what I said

we will pass reportActions and reportActionID to the key and we will subscribe to transaction with transactionID we get from the report action's originalMessage.IOUTransactionID and pass the transaction to onPress in the payload when the context menu item is copy to clipboard ( textTranslateKey=='reportActionContextMenu.copyToClipboard') here

cc: @tgolen

hoangzinh · 2024-03-15T14:52:06Z

Hi @FitseTLT just wanna confirm that, in your proposal, you mentioned that you would pass transaction in this line

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Line 264 in 02e8025

    
           onPress={(event) => interceptAnonymousUser(() => contextAction.onPress?.(closePopup, {...payload, event}), contextAction.isAnonymousAction)}

And only pass transaction if it's a copyToClipboard, isn't it?

FitseTLT · 2024-03-15T15:00:21Z

Hi @FitseTLT just wanna confirm that, in your proposal, you mentioned that you would pass transaction in this line

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Line 264 in 02e8025

onPress={(event) => interceptAnonymousUser(() => contextAction.onPress?.(closePopup, {...payload, event}), contextAction.isAnonymousAction)}

And only pass transaction if it's a copyToClipboard, isn't it?

Yes. filteredContextMenuActions contains the different menu items in the context menu and we only need transaction parameter for onPress (payload) for copy to clipboard ( textTranslateKey=='reportActionContextMenu.copyToClipboard')

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 332 to 333 in e9c112a

    
           textTranslateKey: 'reportActionContextMenu.copyToClipboard', 
        
           icon: Expensicons.Copy,

That's why I said 👍

tgolen · 2024-03-15T16:36:46Z

I discussed this with @hoangzinh and we agreed to go with the proposal from @FitseTLT.

It was the most complete and it was posted earlier than the proposal from nkdengineer.

strepanier03 · 2024-03-21T20:10:14Z

@davidcardoza - Because it seemed like the best fit based on this doc.

I originally thought VSB but it says anything related to IOU and bills are "elsewhere".

Then under VIP-bills it says "Anything related to bills and invoicing as part of an IOU request".

davidcardoza · 2024-04-02T14:31:40Z

That makes sense, thanks for explaining.

melvin-bot · 2024-04-08T10:57:10Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-04-08T10:57:13Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix - Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38882

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment automatic offer (Reviewer)
@FitseTLT requires payment automatic offer (Contributor)

strepanier03 · 2024-04-16T21:58:01Z

@hoangzinh - Please complete the checklist as soon as you can and then I'll handle your payment.

@FitseTLT - I've paid your contract and closed it in Upwork, thanks!

hoangzinh · 2024-04-17T10:29:39Z

Hi @strepanier03 we don't have a checklist for this issue because it's not a bug fix but a technical improvement.

hoangzinh · 2024-04-17T10:31:21Z

oh @tgolen @FitseTLT we still have another follow-up task here #38882 (comment)

tgolen · 2024-04-17T14:35:18Z

Yeah, I've got that follow-up issue assigned to me: #39408 I'll take a look at the logs today and see what I find.

…

On Wed, Apr 17, 2024 at 4:31 AM Vinh Hoang ***@***.***> wrote: oh @tgolen <https://github.com/tgolen> @FitseTLT <https://github.com/FitseTLT> we still have another follow-up task here #38882 (comment) <#38882 (comment)> — Reply to this email directly, view it on GitHub <#38355 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB7LY6SXWEYW35LJJ43Y5ZFQ7AVCNFSM6AAAAABEWY4LNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQHE2DGOJRGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

strepanier03 · 2024-04-17T21:12:30Z

Thanks @hoangzinh for clarification 🙌.

strepanier03 · 2024-04-17T21:17:13Z

Okay, this is all paid out and contracts are closed. Thank you both, @hoangzinh and @FitseTLT, for your work on this.

tgolen added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 14, 2024

tgolen self-assigned this Mar 14, 2024

melvin-bot bot changed the title ~~Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter~~ [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter Mar 14, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 14, 2024

melvin-bot bot assigned hoangzinh Mar 14, 2024

melvin-bot bot assigned strepanier03 Mar 14, 2024

tgolen mentioned this issue Mar 14, 2024

Remove ReportActionsUtils.getParentReportAction(), ReportUtils.getParentReport(), TransactionUtils.getLinkedTransaction(), ReportUtils.getPolicy(), and TransactionUtils.getTransaction() #27262

Closed

25 tasks

melvin-bot bot added the Overdue label Mar 21, 2024

melvin-bot bot removed the Overdue label Mar 21, 2024

FitseTLT mentioned this issue Mar 23, 2024

Fix - Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38882

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 23, 2024

davidcardoza moved this to Low in [#whatsnext] #billpay Apr 1, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 8, 2024

melvin-bot bot changed the title ~~[$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter~~ [HOLD for payment 2024-04-15] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter Apr 8, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024

This comment was marked as resolved.

Sign in to view

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 14, 2024

melvin-bot bot removed the Overdue label Apr 16, 2024

strepanier03 changed the title ~~[HOLD for payment 2024-04-15] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter~~ [PAID] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter Apr 17, 2024

strepanier03 closed this as completed Apr 17, 2024

github-project-automation bot moved this from Low to Done in [#whatsnext] #billpay Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAID] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38355

[PAID] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38355

tgolen commented Mar 14, 2024 •

edited

Loading

melvin-bot bot commented Mar 14, 2024

melvin-bot bot commented Mar 14, 2024

melvin-bot bot commented Mar 14, 2024

FitseTLT commented Mar 14, 2024 •

edited

Loading

allgandalf commented Mar 14, 2024 •

edited

Loading

Krishna2323 commented Mar 14, 2024 •

edited

Loading

allgandalf commented Mar 14, 2024

Krishna2323 commented Mar 14, 2024

tgolen commented Mar 14, 2024

FitseTLT commented Mar 14, 2024

tgolen commented Mar 14, 2024

FitseTLT commented Mar 14, 2024

Krishna2323 commented Mar 14, 2024

nkdengineer commented Mar 15, 2024 •

edited

Loading

hoangzinh commented Mar 15, 2024

hoangzinh commented Mar 15, 2024

melvin-bot bot commented Mar 15, 2024

FitseTLT commented Mar 15, 2024 •

edited

Loading

hoangzinh commented Mar 15, 2024

FitseTLT commented Mar 15, 2024

tgolen commented Mar 15, 2024 •

edited

Loading

strepanier03 commented Mar 21, 2024

davidcardoza commented Apr 2, 2024

melvin-bot bot commented Apr 8, 2024

melvin-bot bot commented Apr 8, 2024

This comment was marked as resolved.

strepanier03 commented Apr 16, 2024

hoangzinh commented Apr 17, 2024

hoangzinh commented Apr 17, 2024

tgolen commented Apr 17, 2024 via email

strepanier03 commented Apr 17, 2024

strepanier03 commented Apr 17, 2024

[PAID] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38355

[PAID] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38355

Comments

tgolen commented Mar 14, 2024 • edited Loading

Problem

Why this is important to fix

Solution

melvin-bot bot commented Mar 14, 2024

melvin-bot bot commented Mar 14, 2024

melvin-bot bot commented Mar 14, 2024

FitseTLT commented Mar 14, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allgandalf commented Mar 14, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Krishna2323 commented Mar 14, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

Alternative

allgandalf commented Mar 14, 2024

Updated Proposal

Krishna2323 commented Mar 14, 2024

Proposal Update

tgolen commented Mar 14, 2024

FitseTLT commented Mar 14, 2024

tgolen commented Mar 14, 2024

FitseTLT commented Mar 14, 2024

Krishna2323 commented Mar 14, 2024

nkdengineer commented Mar 15, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

hoangzinh commented Mar 15, 2024

hoangzinh commented Mar 15, 2024

melvin-bot bot commented Mar 15, 2024

FitseTLT commented Mar 15, 2024 • edited Loading

hoangzinh commented Mar 15, 2024

FitseTLT commented Mar 15, 2024

tgolen commented Mar 15, 2024 • edited Loading

strepanier03 commented Mar 21, 2024

davidcardoza commented Apr 2, 2024

melvin-bot bot commented Apr 8, 2024

melvin-bot bot commented Apr 8, 2024

This comment was marked as resolved.

strepanier03 commented Apr 16, 2024

hoangzinh commented Apr 17, 2024

hoangzinh commented Apr 17, 2024

tgolen commented Apr 17, 2024 via email

strepanier03 commented Apr 17, 2024

strepanier03 commented Apr 17, 2024

tgolen commented Mar 14, 2024 •

edited

Loading

FitseTLT commented Mar 14, 2024 •

edited

Loading

allgandalf commented Mar 14, 2024 •

edited

Loading

Krishna2323 commented Mar 14, 2024 •

edited

Loading

nkdengineer commented Mar 15, 2024 •

edited

Loading

FitseTLT commented Mar 15, 2024 •

edited

Loading

tgolen commented Mar 15, 2024 •

edited

Loading