[HOLD for payment 2024-04-09] [Simplified Collect][Members] Polish items for Transfer owner flow

[luacmartins]

cc @burczu Coming from this PR, there are a few polish items that need to be handled:

1. Wrong error flashes momentarily

error_flash.mov

2. We're showing an error screen on success after adding a debit card

error_page_on_success.mov

3. We're showing three decimals for USD currency

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[burczu]

Hey @luacmartins, please assign me to this issue as this is a follow up issue for my recently merged feature. Thank you!

[burczu]

1. Disable Transfer owner button if user is offline since we can only go through this flow while online.

@luacmartins I'm surprised because offline state is handled from the very beginning of working on this issue:

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 136 in 9d9757f

isDisabled={isOffline}

Could you provide your steps to reproduce it? Maybe you've found some edge case scenario?

[luacmartins]

Oh maybe, the App wasn't actually offline when I checked. Seems like this is already done, so let's move on to the other items in the list!

[burczu]

Oh maybe, the App wasn't actually offline when I checked. Seems like this is already done, so let's move on to the other items in the list!

Yeah - I've actually done all of it today (you can check on the draft PR). Tomorrow morning I'll fill the checklist, add videos and publish it.

[luacmartins]

PR merged

[luacmartins]

Found another bug on the API level, put up a PR with a fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• #39005 - Polish items for Transfer owner flow  #39035

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

No need for BZ checklist, this was a new feature in implementation.

[luacmartins]

I think we're good to close this one, since I reviewed and did the checklist for all PRs linked given that it involved mocking API responses and it was hard for external contributors to test it. Please reopen if I missed something.