Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark down - Position of text with header and line changes after collapsing the composer #39271

Closed
4 of 6 tasks
kbecciv opened this issue Mar 29, 2024 · 4 comments
Closed
4 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38152
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Type # header.
  4. Hit Enter to create a new line.
  5. Note the position of text in the composer.
  6. Expand the composer.
  7. Collapse the composer.

Expected Result:

The position of text in the composer after expanding and collapsing the composer should be the same as the position before expanding the composer.

Actual Result:

After expanding and collapsing the composer, the text in the composer becomes top-aligned.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431691_1711724537587.20240329_225653.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 29, 2024

We think that this bug might be related to #vip-vsb

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@hayata-suenaga
Copy link
Contributor

I don't believe this is a bug 😄 The added header is the first line of the text. It should remain so even when the composer is expanded.

@hayata-suenaga hayata-suenaga removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants