[HOLD for payment 2024-04-15] Return the approverAccountID and reimburserAccountID to Onyx

[luacmartins]

Problem

Coming from #37391 (review), we key personalDetails by accountID, but policy.approver and poliyc.reimburserEmail sends the approver email data back to Onyx, which leads to an inefficient lookup for personal details.

Why is this important

Affects performance

Solution

Send the approverAccountID and reimburserAccountID to Onyx so we can use that to lookup personal details instead of the approver email. Once that's done, we should remove getPersonalDetailByEmail

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01781c07caff758274
• Upwork Job ID: 1775199977020665856
• Last Price Increase: 2024-04-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01781c07caff758274

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[Christinadobrzyn]

I got this payment GH but I think it's for this job?

Should we just pay @s77rt in here?

[s77rt]

Yes. We should close the other one

[stephanieelliott]

PR is undergoing QA

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Replaces usage of reimburserEmail with achAccount.reimburser #39017

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Not a bug. Performance improvement. Checklist does not apply ^

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s77rt paid $500 via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1775199977020665856/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Hey @s77rt I extended the offer to you in Upwork, can you please accept when you get a chance? https://www.upwork.com/jobs/~01781c07caff758274

[s77rt]

@stephanieelliott Accepted! Thanks!

[stephanieelliott]

All paid! See summary here: #39423 (comment)