Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense - Report field is not removed when deleted #39919

Closed
6 tasks done
kbecciv opened this issue Apr 9, 2024 · 13 comments
Closed
6 tasks done

Expense - Report field is not removed when deleted #39919

kbecciv opened this issue Apr 9, 2024 · 13 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Apr 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #36039
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has some report fields.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual request.
  4. Go to expense report.
  5. Click on the report field > Add value > Save it.
  6. On Old Dot, as admin, delete the report field in Step 5.
  7. As employee, go to main chat and back to expense report (to receive update).
  8. Click on the deleted report field.
  9. Click 3-dot menu > Delete > Delete the field.

Expected Result:

The report field will be removed

Actual Result:

The report field is not removed. It is only removed after clearing cache and restart from Troubleshooting section.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6443123_1712642141246.36039_desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc85d44bb737c556
  • Upwork Job ID: 1777733234423984128
  • Last Price Increase: 2024-04-09
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 9, 2024

We think that this bug might be related to #wave-collect - Release 1

@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2024

cc @allroundexperts

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 9, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2024

This is not a deploy blocker as report fields are not really used in NewDot by customers yet its a new feature for Newdot

@allroundexperts @thienlnam could you help with this one?

@thienlnam thienlnam assigned thienlnam and unassigned rlinoz Apr 9, 2024
@thienlnam thienlnam added the Internal Requires API changes or must be handled by Expensify staff label Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01dc85d44bb737c556

Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

@thienlnam
Copy link
Contributor

I believe this has to do with the pusher updates from oldDot not getting prefixed with expensify_ . I can take this

Copy link

melvin-bot bot commented Apr 12, 2024

@allroundexperts, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@thienlnam
Copy link
Contributor

The fix PR should be live now - need to retest

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 12, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

@allroundexperts, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

1 similar comment
Copy link

melvin-bot bot commented Apr 16, 2024

@allroundexperts, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Apr 18, 2024

@allroundexperts, @thienlnam Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants