[HOLD for payment 2024-05-20] CRITICAL: [P2P Distance] [$500] Enable immediate slide scrolling without tap

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.62-6
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712975397589869

Action Performed:

1. Tap green FAB button
2. Select 'track expense'
3. Tap distance tab
4. Touch the screen and pause ever so briefly after touching the screen.
5. Touch the screen and immediately move

Expected Result:

Able to move the map with fingers when touching the screen

Actual Result:

I need to "tap and then slide" (where my finger needs to hold still for maybe 100ms before moving) rather than just "slide" (ie, where my finger can move immediately after touching the map, like in Google Maps).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

PXL_20240413_022530531.mp4

az_recorder_20240413_153727.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a0e30e9fd5243ce
• Upwork Job ID: 1780282719880835072
• Last Price Increase: 2024-05-02
• Automatic offers:
• ikevin127 | Contributor | 0
• suneox | Contributor | 0

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

reviewed, assigining external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a0e30e9fd5243ce

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

MapView conflict event with another component when scrolling on Android

What is the root cause of that problem?

The PanResponder on MapView sometimes has been terminated by DraggableFlatList and another places using PanResponderCapture event at ScreenWrapper and TabNavigator

What changes do you think we should make in order to solve the problem?

We will add onMoveShouldSetPanResponderCapture and onStartShouldSetPanResponderCapture to MapView to early prevent conflict event with another component, and separate MapView/index.android.tsx, DraggableList/index.android.tsx to specific platform to avoid regression then update ListFooterComponent to bellow DraggableFlatList

Tested branch

What alternative solutions did you explore? (Optional)

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[P2P Distance] Enable immediate slide scrolling without tap

What is the root cause of that problem?

Рere we are rendering the DistanceRequestFooter ( It contains MapView inside ) as a ListFooterComponent of the DraggableList, which causes the gestures of the MapView and the DraggableList to conflict.

What changes do you think we should make in order to solve the problem?

1. Add a dragHitSlop prop to the DraggableFlatList, where the bottom key equal to the height of MapView in ListFooterComponent, to disable drag gestures on the MapView area. For that we need to measure the height of MapView in DraggableFlatList component. To achieve this we should update DraggableFlatList component as below.

function DraggableList<T>({renderClone, shouldUsePortal, ListFooterComponent, ...viewProps}: DraggableListProps<T>, ref: React.ForwardedRef<FlatList<T>>) {
    const styles = useThemeStyles();
    const [mapViewHeight, setMapViewHeight] = useState(0)

    const EnhancedListFooterComponent = ListFooterComponent && React.cloneElement(ListFooterComponent, {
        onLayout: (event) => {
            const { height } = event.nativeEvent.layout;
            setMapViewHeight(height);
        },
    })

    return (
        <DraggableFlatList
            ref={ref}
            containerStyle={styles.flex1}
            contentContainerStyle={styles.flexGrow1}
            ListFooterComponentStyle={styles.flex1}
            dragHitSlop={{top:0,left:0,right:0, bottom:-mapViewHeight}}
            ListFooterComponent={EnhancedListFooterComponent}
            // eslint-disable-next-line react/jsx-props-no-spreading
            {...viewProps}
        />
    );
}

4. Step 3 also requires the following changes to work - Add ...props in props of DistanceRequestFooter component and {...props} on container of MapView

function DistanceRequestFooter({waypoints, transaction, mapboxAccessToken, navigateToWaypointEditPage, ...props}
...

<View {...props} style={styles.mapViewContainer} >

What alternative solutions did you explore? (Optional)

Or just use ListFooterComponent out of DraggableFlatList

[mollfpr]

@suneox @shahinyan11 Are you able to reproduce the issue in the emulator iOS and Android?

[shahinyan11]

@suneox @shahinyan11 Are you able to reproduce the issue in the emulator iOS and Android?

I tested on a real Android device and reproduced it. I think this is a case that is better tested on a real device.

[suneox]

@suneox @shahinyan11 Are you able to reproduce the issue in the emulator iOS and Android?

I just tested on real device

[zanyrenney]

@mollfpr please can you review the comments above and see if they work wiht the proposals?

[suneox]

Proposal updated

Add alternative solution and Tested branch

[quinthar]

What are the next steps? Are we waiting on @mollfpr to pick a proposal? What's the ETA on that?

[mollfpr]

Sorry for the delay. I just got my phone set up to test the issue.

@shahinyan11 Your solution doesn't look good on the web.

[shahinyan11]

@shahinyan11 Your solution doesn't look good on the web.

@mollfpr Are you about UI or functionality. Are you talking about the user interface or functionality? If you mean the UI, then there is a question of a slight change in styles

[mollfpr]

@suneox I'm testing your branch but the issue is still there.

Screen_Recording_20240422_175841_New.Expensify.Dev.mp4

@shahinyan11 Could you please update your proposal to make it work on all platforms?

[quinthar]

@shahinyan11 Can you please give an ETA? Thanks!

[suneox]

@suneox @ikevin127 There is no need to add a separate component for Android, just add dragHitSlop prop to the DraggableList component

I don't think config dragHitSlop is fit for all cases with parameters {top: number, left: number, bottom: number, right: number} due to user can add multiple waypoints.

My proposal doesn't break another platform and it's also ready to create PR

Screenshots/Videos

Android: Native

screen-20240503-080800.mp4

Android: mWeb Chrome

screen-20240503-100035.mp4

iOS: Native

Screen.Recording.2024-05-03.at.14.21.15.mov

iOS: mWeb Safari

Screen.Recording.2024-05-03.at.08.38.09.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-03.at.08.18.10.mov

MacOS: Desktop

Screen.Recording.2024-05-03.at.08.26.10.mov

[ikevin127]

@suneox @ikevin127 There is no need to add a separate component for Android, just add dragHitSlop prop to the DraggableList component

I think it's safe to split index.native.tsx DraggableList into index.ios.tsx and index.android.ts since on Android we're restructuring the component render by adding a View, which on iOS is not needed because the issue is not present.

This is the recommended way for platform specific changes to be safe and avoid breaking the same, working logic on other platforms.

See #34881 (comment) issue for reference.

[suneox]

I think it's safe to split index.native.tsx DraggableList into index.ios.tsx and index.android.ts since on Android we're restructuring the component render by adding a View, which on iOS is not needed because the issue is not present.

This is the recommended way for platform specific changes to be safe and avoid breaking the same, working logic on other platforms.

The PR is ready to create waiting for assignment

[neil-marcellini]

@suneox's proposal LGTM! The root cause was identified and the proposed solution targets and fixes the issue accordingly.

🎀👀🎀 C+ reviewed

I found the proposal to be a bit unclear and hard to follow, but I trust the thorough testing that was already done, so let's create a PR.

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[suneox]

The PR is ready for review

[shahinyan11]

Proposal

Updated. I updated proposal as I am sure that the changes in approved proposal does not make sense and not necessary to have that behavior

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 40211 handle conflict mapview event on android #41603

If no regressions arise, payment will be issued on 2024-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @ikevin127 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ikevin127]

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:

No PR causing this was identified, this was not caused by a recent regression.

• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need, as this was an edge case issue which happened only on Android: Native due to differences in touch handler.

• [@ikevin127] Determine if we should create a regression test for this bug.

No need for regression test here as as this was an edge case issue which happened only on Android: Native due to differences in touch handler.

• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[zanyrenney]

payment summary

paid $500 via upwork to @suneox
paid $500 via upwork to @ikevin127