Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-02] Split scan - Missing Split button in the split menu RHP #40709

Closed
6 tasks done
kbecciv opened this issue Apr 22, 2024 · 12 comments
Closed
6 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Apr 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a split scan expense.
  4. When the expense is still scanning, click on the split preview.
  5. Enter amount and merchant.

Expected Result:

There will be a Split button in the split menu RHP.

Actual Result:

There is no Split button in the split menu RHP.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457562_1713800759060.bandicam_2024-04-22_23-30-14-562.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 22, 2024

We think that this bug might be related to #vip-split

@shubham1206agra
Copy link
Contributor

I suspect this is coming from #40176.

cc @brunovjk @eh2077

@eh2077
Copy link
Contributor

eh2077 commented Apr 22, 2024

@shubham1206agra Thanks for the ping. Yeah, we already have a PR #40659 to fix this

@mountiny mountiny added Reviewing Has a PR in review and removed DeployBlockerCash This issue or pull request should block deployment labels Apr 22, 2024
@mountiny
Copy link
Contributor

Removing the label, the PR will be QAed on the checklist for confirmation

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Apr 25, 2024
@melvin-bot melvin-bot bot changed the title Split scan - Missing Split button in the split menu RHP [HOLD for payment 2024-05-02] Split scan - Missing Split button in the split menu RHP Apr 25, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. 🎊

@brunovjk
Copy link
Contributor

brunovjk commented Apr 25, 2024

Issue generated through refactoring PR, and fixed by PR mentioned above.
No payment will be necessary here.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 1, 2024
Copy link

melvin-bot bot commented May 2, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
Copy link

melvin-bot bot commented May 7, 2024

@iwiznia Huh... This is 4 days overdue. Who can take care of this?

@brunovjk
Copy link
Contributor

brunovjk commented May 7, 2024

Issue generated through refactoring PR, and fixed by PR mentioned above.
No payment will be necessary here.

I think we can close this one. It's been 7+ days since the PR has been in production

@iwiznia iwiznia closed this as completed May 7, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants