[$250][HOLD #37374] Track expense - Waypoints swap places when tap and hold

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.64-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #40176

Action Performed:

1. Open the App
2. Log in
3. Click on the Global Fab.
4. Press "Track Expense".
5. Click on "Distance" at the top.
6. Add two or more valid waypoints.
7. Swap them around
8. Try tap and hold each waypoint one by one
9. Repeat steps 7 and 8 (If needed)

Expected Result:

All waypoints must stay until moved by user. Behavior should be the same as in Web and mWeb

Actual Result:

Some waypoints swap places when tap and hold

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6459187_1713893255264.Screen_Recording_20240423_194241_New_Expensify__2_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0117efc9769c84fcf4
• Upwork Job ID: 1785733717315878912
• Last Price Increase: 2024-05-22

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

Production:

Record_2024-04-23-21-06-27_4f9154176b47c00da84e32064abf1c48.mp4

[blimpich]

Will look into this this afternoon, have a medical appointment in a bit, but commenting to say this is on my radar for today

[mountiny]

The distance is not yet fully supported in the track expense flow.

cc @neil-marcellini @koko57 for visibility

removing a block as this is a specific ui related issue

[blimpich]

Ah, I see this is related to this new feature #36985 (comment). @neil-marcellini @koko57 I'll defer to you on what you think is best here. Seems frontend specific, so happy to guide this through being marked as external and being solved by contributors if you think that is best here.

[melvin-bot]

@blimpich Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@blimpich Still overdue 6 days?! Let's take care of this!

[blimpich]

Gonna add external to put this one out for contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0117efc9769c84fcf4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[koko57]

@blimpich sorry, I didn't notice your earlier message. As Vit mentioned:

The distance is not yet fully supported in the track expense flow.

I think that should be hold until the track expense fully supports distance, then retested (the problem may not occur anymore after this is done).

cc @neil-marcellini

[blimpich]

I see, is there a tracking issue that we could reference for this issue then? If so I will update the issue title to wait until its resolved before retesting this.

[sakluger]

Moving to weekly. Based on the hold issue, we may not update for a week or two.

[sakluger]

Still waiting on #37374.

[sakluger]

Still waiting on #37374

[sakluger]

Still holding.

[sakluger]

Still holding for #37374

[sakluger]

Hey @roryabraham - this issue has been on hold for Upgrade to RN 0.74 #37374. Do you have any idea about how much longer that upgrade will take? If it's going to take a lot longer, I'd like to switch this to Monthly. Thanks!

[roryabraham]

It does seem like we're getting closer, so let's keep this weekly. It might've been merged this week if not for DBSEC (don't break shit, earnings call)

[sakluger]

#37374 is still in the works.

[sakluger]

Still in process

[koko57]

@sakluger as 0.75 upgrade is merged #45289 we can retest this one (and hopefully close it 😉)

[roryabraham]

Requested retest: https://expensify.enterprise.slack.com/archives/C9YU7BX5M/p1724794514765929

[izarutskaya]

Not reproduced anymore
Build v9.0.25-10

Screen_Recording_20240828_115322_New.Expensify.mp4

[blimpich]

Yay!!! Lets close this thing 🎊