[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room #40928

kbecciv · 2024-04-24T18:13:22Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: v1.4.65-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Testing

Action Performed:

Navigate to any room.
Type "#" and select the suggested room, then send the message.
Proceed to its thread.

Expected Result:

Upon entering the thread, the header enters an infinite loading state.

Actual Result:

The mentioned room should be displayed in the header as expected, without any endless loading.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6460103_1713955694030.Screen_Recording_2024-04-24_at_3.45.34_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0137b18b289d467863
Upwork Job ID: 1783902532804722688
Last Price Increase: 2024-05-17
Automatic offers:

tsa321 | Contributor | 0

Issue Owner

Current Issue Owner: @isabelastisser

melvin-bot · 2024-04-24T18:13:34Z

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

kbecciv · 2024-04-24T18:14:04Z

We think that this bug might be related to #vip-vsb

kbecciv · 2024-04-24T18:14:32Z

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

melvin-bot · 2024-04-26T16:54:44Z

Job added to Upwork: https://www.upwork.com/jobs/~0137b18b289d467863

melvin-bot · 2024-04-26T16:54:48Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

shahinyan11 · 2024-04-26T17:05:04Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Endless Loading of Header When Navigating to Thread of Mentioned Room

What is the root cause of that problem?

Here we set isLoading to true if the title is not exists. We get title using ReportUtils.getReportName here in which we return empty string here if the report is policyRoom and do not have participants

What changes do you think we should make in order to solve the problem?

Update this line like below. It is not specified exactly what should be displayed, so I suggested еру report?.reportName. We can update it to desired value

return getAdminRoomInvitedParticipants(parentReportAction, parentReportActionMessage) || report?.reportName;

What alternative solutions did you explore? (Optional)

mollfpr · 2024-04-29T05:35:48Z

@shahinyan11 I think the expected result should show the message in the header, but with your solution, it will show Chat Report which is the report name from the report.

We get title using ReportUtils.getReportName here in which we return empty string here if the report is policyRoom and do not have participants

Your root cause might not be correct, the issue is only reproduced if the message just contains the mention tag.

Screen.Recording.2024-04-29.at.12.24.51.mp4

mollfpr · 2024-04-29T05:46:29Z

If you try to edit the message with a message that only contains the report mentioned, it will display in the header. So to be consistent we should display the report mentioned in the header.

Screen.Recording.2024-04-29.at.12.35.55.mp4

We also show the mention tag in the header report.

isabelastisser · 2024-05-01T19:14:30Z

@mollfpr, any updates? Are we still waiting for proposals?

mollfpr · 2024-05-02T04:54:02Z

@isabelastisser Still waiting for @shahinyan11 and other proposals.

melvin-bot · 2024-05-03T16:00:16Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

tsa321 · 2024-05-06T10:05:11Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Header of thread report displayed as skeleton view if the parent report action message is report mention.

What is the root cause of that problem?

In HeaderView the skeleton view will be displayed if isLoading:

App/src/pages/home/HeaderView.tsx

Line 220 in 035adb8

const isLoading = !report.reportID || !title;

is true. It's value will be true in this issue because title variabletitle = ReportUtils.getReportName(reportHeaderData); is empty string.
This function will go to here and then in here and return empty string. This is because reportAction.message[0].text is empty string. The parent reportAction.message[0].text is empty but reportAction.message[0].html is something like <mention-report reportID=\"50451872397987297398\"/>

What changes do you think we should make in order to solve the problem?

In this line:

App/src/libs/ReportUtils.ts

Line 2949 in 035adb8

return Str.removeSMSDomain(reportAction?.message?.[0]?.text ?? '');

We could use reportAction?.message?.[0]?.html and detect all occurrence of pattern <mention-report reportID=\"xxxxx\"/> by using regex and replace it by it's report name, and add the report names in reportAction?.message?.[0]?.text in that line.

The code could be:

Code:

function embedMentionedReportName(reportAction){
    const {html, text} = reportAction?.message?.[0];
    if (!html) {
        return text;
    }

    const mentionReportRegex = /(\<mention-report reportID\=\"(\d+)\"\/>)/gm;
    if (!mentionReportRegex.test(html)) {
        return text;
    } 

    const splittedText = text.split(" ");    
  
    // Remove tags except for mention-report
    const filteredHtml = html.replace(/(\<(?!mention-report).*?\>)/gm, "");

    // Embed report name into html enclosed by tag, for exampple: <#announce>
    const htmlWithReportName = filteredHtml.replace(/(\<mention-report reportID\=\"(\d+?)\"\/\>)/gm, 
        (match, p1, p2) => `<${getReportName(getReport(p2))}>`
    );
    const splittedHtmlWithReportName = htmlWithReportName.split(" ");

    const taggedReportNameRegex = /\<(.+)\>/gm;
    splittedHtmlWithReportName.forEach((str, index) => {
        const match = taggedReportNameRegex.exec(str ?? "");        
        if (match) {
            const cSpliitedText = splittedText[index] ?? "";
            splittedText[index] = match.index > 0 ? cSpliitedText + match[1] : match[1] + cSpliitedText;  
        }  
        taggedReportNameRegex.lastIndex = 0;
    })

    return splittedText.join(" ");
}

Then in here:

App/src/libs/ReportUtils.ts

Line 2949 in 035adb8

return Str.removeSMSDomain(reportAction?.message?.[0]?.text ?? '');

call it with:

    const embeddedMentionedReportName = embedMentionedReportName(reportAction);
    return Str.removeSMSDomain( embeddedMentionedReportName ?? '');

What alternative solutions did you explore?

We could use ExpensiMark htmlToText to parse the html string.

isabelastisser · 2024-05-06T15:25:25Z

@mollfpr can you please review the proposal above? Thanks!

mollfpr · 2024-05-06T19:04:40Z

@tsa321 I'm incline with your approach, could you share the result of your proposal?

mvtglobally · 2024-05-06T19:55:29Z

Issue not reproducible during KI retests. (First week)

tsa321 · 2024-05-08T07:19:19Z

@mollfpr

The code could be:

Code:

function embedMentionedReportName(reportAction){
    const {html, text} = reportAction?.message?.[0];
    if (!html) {
        return text;
    }

    const mentionReportRegex = /(\<mention-report reportID\=\"(\d+)\"\/>)/gm;
    if (!mentionReportRegex.test(html)) {
        return text;
    } 

    const splittedText = text.split(" ");    
  
    // Remove tags except for mention-report
    const filteredHtml = html.replace(/(\<(?!mention-report).*?\>)/gm, "");

    // Embed report name into html enclosed by tag, for exampple: <#announce>
    const htmlWithReportName = filteredHtml.replace(/(\<mention-report reportID\=\"(\d+?)\"\/\>)/gm, 
        (match, p1, p2) => `<${getReportName(getReport(p2))}>`
    );
    const splittedHtmlWithReportName = htmlWithReportName.split(" ");

    const taggedReportNameRegex = /\<(.+)\>/gm;
    splittedHtmlWithReportName.forEach((str, index) => {
        const match = taggedReportNameRegex.exec(str ?? "");        
        if (match) {
            const cSpliitedText = splittedText[index] ?? "";
            splittedText[index] = match.index > 0 ? cSpliitedText + match[1] : match[1] + cSpliitedText;  
        }  
        taggedReportNameRegex.lastIndex = 0;
    })

    return splittedText.join(" ");
}

Then in here:

App/src/libs/ReportUtils.ts

Line 2949 in 035adb8

return Str.removeSMSDomain(reportAction?.message?.[0]?.text ?? '');

call it with:

    const embeddedMentionedReportName = embedMentionedReportName(reportAction);
    return Str.removeSMSDomain( embeddedMentionedReportName ?? '');

Result:

macos-web-d.mp4

melvin-bot · 2024-05-08T18:03:11Z

@mollfpr @isabelastisser this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

isabelastisser · 2024-05-23T18:54:20Z

It looks like the PR was submitted here: #42504

luacmartins · 2024-05-27T16:16:29Z

#40928 (comment) I could still reproduce the issue just now.

melvin-bot · 2024-06-11T23:33:02Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-06-11T23:33:06Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix endless loading thread report header #42504

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

@mollfpr requires payment through NewDot Manual Requests
@tsa321 requires payment automatic offer (Contributor)

melvin-bot · 2024-06-11T23:33:07Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2024-06-13T15:29:58Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix endless loading thread report header #42504

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

@mollfpr requires payment through NewDot Manual Requests
@tsa321 requires payment automatic offer (Contributor)

melvin-bot · 2024-06-13T15:29:59Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

isabelastisser · 2024-06-18T20:26:01Z

@mollfpr, please complete the BZ list. Thanks!

isabelastisser · 2024-06-20T18:59:03Z

Bump @mollfpr to complete the checklist.

isabelastisser · 2024-06-20T19:21:15Z

Payment summary:

@mollfpr requires payment through NewDot Manual Requests Role C+ $250 PENDING
@tsa321 requires payment automatic offer (Contributor) PAID!

isabelastisser · 2024-06-21T19:01:51Z

Bump @mollfpr. I DM'd you for visibility.

mollfpr · 2024-06-22T03:20:03Z

Sorry for the delay.

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. The issue seems a case that we missing to handle and how we should process the mentioned action message from BE.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Open admins or announce room
Send a message containing only the mentioned room name (for example #admins or #announce)
Select Reply in thread of that message
Wait for at least 5 seconds
Verify the thread report header looks like the common thread header and is not changed into endless loading
👍 or 👎

JmillsExpensify · 2024-06-22T16:12:15Z

$250 approved for @mollfpr

isabelastisser · 2024-06-23T01:04:54Z

All set!

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 24, 2024

melvin-bot bot assigned isabelastisser Apr 24, 2024

isabelastisser added this to [#whatsnext] #vip-vsb Apr 26, 2024

isabelastisser added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 26, 2024

melvin-bot bot changed the title ~~Room - Endless Loading of Header When Navigating to Thread of Mentioned Room~~ [$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room Apr 26, 2024

melvin-bot bot assigned mollfpr Apr 26, 2024

melvin-bot bot added the Overdue label May 1, 2024

melvin-bot bot removed the Overdue label May 1, 2024

melvin-bot bot added the Overdue label May 6, 2024

melvin-bot bot removed the Overdue label May 6, 2024

melvin-bot bot added the Overdue label May 9, 2024

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 23, 2024

tsa321 mentioned this issue May 28, 2024

Modify mention user and mention report extras field names in ExpensiMark htmlToText and htmlToMarkdown rules Expensify/expensify-common#708

Merged

This comment was marked as resolved.

Sign in to view

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024

melvin-bot bot changed the title ~~[$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room~~ [HOLD for payment 2024-06-18] [$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room Jun 11, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 18, 2024

isabelastisser closed this as completed Jun 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room #40928

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room #40928

kbecciv commented Apr 24, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Apr 24, 2024

kbecciv commented Apr 24, 2024

kbecciv commented Apr 24, 2024

melvin-bot bot commented Apr 26, 2024

melvin-bot bot commented Apr 26, 2024

shahinyan11 commented Apr 26, 2024 •

edited

Loading

mollfpr commented Apr 29, 2024 •

edited

Loading

mollfpr commented Apr 29, 2024 •

edited

Loading

isabelastisser commented May 1, 2024

mollfpr commented May 2, 2024

melvin-bot bot commented May 3, 2024

tsa321 commented May 6, 2024 •

edited

Loading

isabelastisser commented May 6, 2024

mollfpr commented May 6, 2024

mvtglobally commented May 6, 2024

tsa321 commented May 8, 2024

melvin-bot bot commented May 8, 2024

isabelastisser commented May 23, 2024

luacmartins commented May 27, 2024

This comment was marked as resolved.

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 13, 2024

melvin-bot bot commented Jun 13, 2024

isabelastisser commented Jun 18, 2024

isabelastisser commented Jun 20, 2024 •

edited

Loading

isabelastisser commented Jun 20, 2024

isabelastisser commented Jun 21, 2024 •

edited

Loading

mollfpr commented Jun 22, 2024

JmillsExpensify commented Jun 22, 2024

isabelastisser commented Jun 23, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room #40928

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Room - Endless Loading of Header When Navigating to Thread of Mentioned Room #40928

Comments

kbecciv commented Apr 24, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Apr 24, 2024

kbecciv commented Apr 24, 2024

kbecciv commented Apr 24, 2024

melvin-bot bot commented Apr 26, 2024

melvin-bot bot commented Apr 26, 2024

shahinyan11 commented Apr 26, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mollfpr commented Apr 29, 2024 • edited Loading

mollfpr commented Apr 29, 2024 • edited Loading

isabelastisser commented May 1, 2024

mollfpr commented May 2, 2024

melvin-bot bot commented May 3, 2024

tsa321 commented May 6, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore?

isabelastisser commented May 6, 2024

mollfpr commented May 6, 2024

mvtglobally commented May 6, 2024

tsa321 commented May 8, 2024

melvin-bot bot commented May 8, 2024

isabelastisser commented May 23, 2024

luacmartins commented May 27, 2024

This comment was marked as resolved.

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 13, 2024

melvin-bot bot commented Jun 13, 2024

isabelastisser commented Jun 18, 2024

isabelastisser commented Jun 20, 2024 • edited Loading

isabelastisser commented Jun 20, 2024

isabelastisser commented Jun 21, 2024 • edited Loading

mollfpr commented Jun 22, 2024

JmillsExpensify commented Jun 22, 2024

isabelastisser commented Jun 23, 2024

kbecciv commented Apr 24, 2024 •

edited by melvin-bot bot

Loading

shahinyan11 commented Apr 26, 2024 •

edited

Loading

mollfpr commented Apr 29, 2024 •

edited

Loading

mollfpr commented Apr 29, 2024 •

edited

Loading

tsa321 commented May 6, 2024 •

edited

Loading

isabelastisser commented Jun 20, 2024 •

edited

Loading

isabelastisser commented Jun 21, 2024 •

edited

Loading