[HOLD for payment 2024-12-03] [$1000] Make emojis larger in other contexts than just single character messages

[jboniface]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

This issue covers several related scenarios:

Scenario 1

Action Performed:

Add an emoji with other plain text characters in a message in the composer.

Expected Result:

The emoji should be larger (19pt) compared to the default size for text (15pt) in the composer. The emoji and text should appear vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of this example.

Actual Result:

The emoji is the same size as the rest of the text.

Scenario 2

Action Performed:

Send a message with emoji and text.

Expected Result:

The emoji should be larger (19pt) compared to the default size for text (15pt) in the chat history. The emoji and text should appear vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of this example

Actual Result:

The emoji is the same size as the rest of the text.

Scenario 3

Action Performed

Draft a message (of any length) with only emoji.

Expected Result

The emoji should appear very large (27pt) in the composer.

Actual Result

The emoji appear very small (15pt).

Scenario 4

Action Performed

Send a message (of any length) with only emoji.

Expected Result

The emoji should appear very large (27pt) in the report history.

Actual Result

The emoji only appear large in the report history if there is only one emoji in the message.

Scenario 5

Action Performed

Go to Settings -> Profile and add emoji(s) to your last name 😎

Expected Result

The emoji should appear larger (19pt) than the rest of the text (15pt) in the text input. The emoji and text should appear vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of this example

Actual Result

The emoji appear the same size as the text.

Scenario 6

Action Performed

1. Go to Settings -> Profile and add emoji(s) to your last name 😎.
2. Save your profile.
3. Open the Settings RHP and look at your name:

Expected Result

The emoji should appear larger (21pt) than the rest of the text (17pt) in the text input. The emoji and text should appear vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of this example

Actual Result

The emoji and text have the same height:

Scenario 7

Action Performed

1. Go to Settings -> Profile and add emoji(s) to your last name 😎.
2. Save your profile.
3. Open a chat with another user and send them a message. Take a look at your message in the report history.

Expected Result

The emoji should appear larger (19pt) than the rest of the test (15pt). The emoji and text should appear vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of this example

Actual Result

The emoji appears the same size as the rest of the text.

Workaround:

no

Platform:

all

View all open jobs on Upwork

Issue Owner

Current Issue Owner: @JmillsExpensify

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

@jboniface, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[VickyStash]

Updates: The PR with react-native-live-markdown upgrade was reverted. But the new one has already been opened: #50047, so waiting for it. It's not possible to bumb the lib version outside of that PR cause inline images functionality was added in version 0.1.145.

[roryabraham]

@francoisl choosing you at random to take this over while I'm on parental leave. Hope you don't mind 🙃

[VickyStash]

Updates: the PR is waiting for re-review.

[JmillsExpensify]

PRs in progress

[VickyStash]

Updates:

• Waiting on the confirmation if the last reported bug is truly a bug and should be fixed (see the comment)

[VickyStash]

Updates:

• Resolved conflicts and retested the PR, waiting for another round of review.

[VickyStash]

Updates:
The PR is waiting for the final review by @francoisl

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Enlarge emojis in other contexts than just single character messages #47547

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @parasharrajat requires payment through NewDot Manual Requests
• @kbieganowski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[JmillsExpensify]

Payment summary: $1,000 for @parasharrajat via NewDot. Please make sure that you suggest a regression test before requesting payment. Thanks!

[parasharrajat]

Regression Test Steps

Composer:

1. Draft a message (of any length) with text and emojis
2. Verify that emojis are larger (17px) compared to the default size for text (15px) in the composer (emojis + text input)

Report history:

1. Send a message with emojis and text
2. Verify that emojis are larger (17px) compared to the default size for text (15pt) in the chat history and vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji [HOLD for payment 2024-12-03] [$1000] Make emojis larger in other contexts than just single character messages #4114 (comment)

Settings:

1. Go to Settings -> Profile and add emoji to your last name
2. Verify that emoji appear larger (17px) than the rest of the text (15pt) in the text input
3. Save the changes
4. Open LHP
5. Verify that emoji in user's last name appear larger (25px) compared to the rest of the text (22px)

Do you agree 👍 or 👎 ?

[JmillsExpensify]

Regression test created

[parasharrajat]

Payment requested as per #4114 (comment)

[garrettmknight]

Payment summary: $1,000 for @parasharrajat via NewDot.