[hold for payment 2024-05-29][$250] Chat icons visible before input field renders #41397

Julesssss · 2024-05-01T08:37:39Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.67-4

Action Performed:

Kill the app
Open the app
Navigate to a chat

Expected Result:

Buttons and input field should become visible at the same time

Actual Result:

Icons are visible before the input field renders
They jump from left side to right which looks bad

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

InputButtons.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012097aedd79eaa599
Upwork Job ID: 1785589469415067648
Last Price Increase: 2024-05-01
Automatic offers:

ikevin127 | Reviewer | 0
bernhardoj | Contributor | 0

melvin-bot · 2024-05-01T08:37:47Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2024-05-01T08:38:00Z

Job added to Upwork: https://www.upwork.com/jobs/~012097aedd79eaa599

melvin-bot · 2024-05-01T08:38:05Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

ShridharGoel · 2024-05-01T10:00:16Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The emoji and send icons become visible before the input field and then jump when the input field is shown.

What is the root cause of that problem?

This happens because the + icon and composer are inside AttachmentModal. This leads to an unnecessary increase in component nesting, while the emoji icon and send icon are outside the AttachmentModal so they display earlier.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 398 to 478 in 573d989

    
           <AttachmentModal 
        
               headerTitle={translate('reportActionCompose.sendAttachment')} 
        
               onConfirm={addAttachment} 
        
               onModalShow={() => setIsAttachmentPreviewActive(true)} 
        
               onModalHide={onAttachmentPreviewClose} 
        
           > 
        
               {({displayFileInModal}) => ( 
        
                   <> 
        
                       <AttachmentPickerWithMenuItems 
        
                           displayFileInModal={displayFileInModal} 
        
                           reportID={reportID} 
        
                           report={report} 
        
                           reportParticipantIDs={reportParticipantIDs} 
        
                           isFullComposerAvailable={isFullComposerAvailable} 
        
                           isComposerFullSize={isComposerFullSize} 
        
                           isBlockedFromConcierge={isBlockedFromConcierge} 
        
                           disabled={!!disabled} 
        
                           setMenuVisibility={setMenuVisibility} 
        
                           isMenuVisible={isMenuVisible} 
        
                           onTriggerAttachmentPicker={onTriggerAttachmentPicker} 
        
                           raiseIsScrollLikelyLayoutTriggered={raiseIsScrollLikelyLayoutTriggered} 
        
                           onCanceledAttachmentPicker={() => { 
        
                               isNextModalWillOpenRef.current = false; 
        
                               restoreKeyboardState(); 
        
                           }} 
        
                           onMenuClosed={restoreKeyboardState} 
        
                           onAddActionPressed={onAddActionPressed} 
        
                           onItemSelected={onItemSelected} 
        
                           actionButtonRef={actionButtonRef} 
        
                       /> 
        
                       <ComposerWithSuggestions 
        
                           ref={composerRef} 
        
                           animatedRef={animatedRef} 
        
                           suggestionsRef={suggestionsRef} 
        
                           isNextModalWillOpenRef={isNextModalWillOpenRef} 
        
                           isScrollLikelyLayoutTriggered={isScrollLikelyLayoutTriggered} 
        
                           raiseIsScrollLikelyLayoutTriggered={raiseIsScrollLikelyLayoutTriggered} 
        
                           reportID={reportID} 
        
                           policyID={report?.policyID ?? ''} 
        
                           parentReportID={report?.parentReportID} 
        
                           parentReportActionID={report?.parentReportActionID} 
        
                           includeChronos={ReportUtils.chatIncludesChronos(report)} 
        
                           isGroupPolicyReport={isGroupPolicyReport} 
        
                           isEmptyChat={isEmptyChat} 
        
                           lastReportAction={lastReportAction} 
        
                           isMenuVisible={isMenuVisible} 
        
                           inputPlaceholder={inputPlaceholder} 
        
                           isComposerFullSize={isComposerFullSize} 
        
                           displayFileInModal={displayFileInModal} 
        
                           textInputShouldClear={textInputShouldClear} 
        
                           setTextInputShouldClear={setTextInputShouldClear} 
        
                           isBlockedFromConcierge={isBlockedFromConcierge} 
        
                           disabled={!!disabled} 
        
                           isFullComposerAvailable={isFullComposerAvailable} 
        
                           setIsFullComposerAvailable={setIsFullComposerAvailable} 
        
                           setIsCommentEmpty={setIsCommentEmpty} 
        
                           handleSendMessage={handleSendMessage} 
        
                           shouldShowComposeInput={shouldShowComposeInput} 
        
                           onFocus={onFocus} 
        
                           onBlur={onBlur} 
        
                           measureParentContainer={measureContainer} 
        
                           listHeight={listHeight} 
        
                           onValueChange={(value) => { 
        
                               if (value.length === 0 && isComposerFullSize) { 
        
                                   Report.setIsComposerFullSize(reportID, false); 
        
                               } 
        
                               validateCommentMaxLength(value, {reportID}); 
        
                           }} 
        
                       /> 
        
                       <ReportDropUI 
        
                           onDrop={(event: DragEvent) => { 
        
                               if (isAttachmentPreviewActive) { 
        
                                   return; 
        
                               } 
        
                               const data = event.dataTransfer?.items[0]; 
        
                               displayFileInModal(data as unknown as FileObject); 
        
                           }} 
        
                       /> 
        
                   </> 
        
               )} 
        
           </AttachmentModal>

What changes do you think we should make in order to solve the problem?

Move the below code inside AttachmentModal, so the emoji icon and send icon also work as children of AttachmentModal.

{DeviceCapabilities.canUseTouchScreen() && isMediumScreenWidth ? null : (
    <EmojiPickerButton
        isDisabled={isBlockedFromConcierge || disabled}
        onModalHide={focus}
        //  @ts-expect-error TODO: Remove this once EmojiPickerButton (https://github.com/Expensify/App/issues/25155) is migrated to TypeScript.
        onEmojiSelected={(...args) => composerRef.current?.replaceSelectionWithText(...args)}
        emojiPickerID={report?.reportID}
        shiftVertical={emojiShiftVertical}
    />
)}
<SendButton
    isDisabled={isSendDisabled}
    handleSendMessage={handleSendMessage}
/>

ikevin127 · 2024-05-01T23:40:16Z

♻️ Reviewing proposal.

ikevin127 · 2024-05-02T01:26:41Z

@ShridharGoel Thanks for your proposal !

Your RCA is correct in the sense that some elements are rendered as children of AttachmentModal therefore they become visible with delay. Regarding this being necessary or not: I think that it is since these components are using children props like displayFileInModal passed from AttachmentModal which are required for: AttachmentPickerWithMenuItems, ComposerWithSuggestions and ReportDropUI to work as expected (as children of AttachmentModal).

When it comes to the proposed solution, because AttachmentModal is a complex component used in other parts of the app, I am reserved when it comes to the addition of the attachment prop and additional logic mentioned since adding an additional state variable would increase the render count which we want to avoid, except when absolutely necessary.

Tip

Instead of moving the mentioned AttachmentModal children components outside of the AttachmentModal, I'd direct my attention towards the components that are outside of the AttachmentModal and try to find a solution that would make it such that all of the components become visible at the same time, as mentioned in the expected result.

c3024 · 2024-05-02T07:40:11Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat icons appear to jump from left to right because the attachment picker button and the composer are loaded with delay

What is the root cause of that problem?

Composer and AttachmentPicker are inside the AttachmentModal so the icons are loaded quicker than the composer and attachment picker.

What changes do you think we should make in order to solve the problem?

I think the jumping of icons from left to right is what causing the bad look. We can position them at the right from the beginning by adding styles.justifyContentEnd here

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Line 396 in 1c651a1

]}

Instead of the above, we can add the justifyContentEnd to chatItemComposeBox here

App/src/styles/index.ts

Line 2034 in 1c651a1

},

It does not break anything because this style is used only from composer and edit composer.

What alternative solutions did you explore? (Optional)

ShridharGoel · 2024-05-02T07:48:58Z

Proposal

Updated based on @ikevin127's comment.

bernhardoj · 2024-05-02T14:42:21Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The add action button and the input itself is missing when opening a chat for the first time after killing the app.

What is the root cause of that problem?

The add button and the input/composer are wrapped with an AttachmentModal component.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 398 to 466 in f851f57

    
           <AttachmentModal 
        
               headerTitle={translate('reportActionCompose.sendAttachment')} 
        
               onConfirm={addAttachment} 
        
               onModalShow={() => setIsAttachmentPreviewActive(true)} 
        
               onModalHide={onAttachmentPreviewClose} 
        
           > 
        
               {({displayFileInModal}) => ( 
        
                   <> 
        
                       <AttachmentPickerWithMenuItems 
        
                           displayFileInModal={displayFileInModal} 
        
                           reportID={reportID} 
        
                           report={report} 
        
                           reportParticipantIDs={reportParticipantIDs} 
        
                           isFullComposerAvailable={isFullComposerAvailable} 
        
                           isComposerFullSize={isComposerFullSize} 
        
                           isBlockedFromConcierge={isBlockedFromConcierge} 
        
                           disabled={!!disabled} 
        
                           setMenuVisibility={setMenuVisibility} 
        
                           isMenuVisible={isMenuVisible} 
        
                           onTriggerAttachmentPicker={onTriggerAttachmentPicker} 
        
                           raiseIsScrollLikelyLayoutTriggered={raiseIsScrollLikelyLayoutTriggered} 
        
                           onCanceledAttachmentPicker={() => { 
        
                               isNextModalWillOpenRef.current = false; 
        
                               restoreKeyboardState(); 
        
                           }} 
        
                           onMenuClosed={restoreKeyboardState} 
        
                           onAddActionPressed={onAddActionPressed} 
        
                           onItemSelected={onItemSelected} 
        
                           actionButtonRef={actionButtonRef} 
        
                       /> 
        
                       <ComposerWithSuggestions 
        
                           ref={composerRef} 
        
                           animatedRef={animatedRef} 
        
                           suggestionsRef={suggestionsRef} 
        
                           isNextModalWillOpenRef={isNextModalWillOpenRef} 
        
                           isScrollLikelyLayoutTriggered={isScrollLikelyLayoutTriggered} 
        
                           raiseIsScrollLikelyLayoutTriggered={raiseIsScrollLikelyLayoutTriggered} 
        
                           reportID={reportID} 
        
                           policyID={report?.policyID ?? ''} 
        
                           parentReportID={report?.parentReportID} 
        
                           parentReportActionID={report?.parentReportActionID} 
        
                           includeChronos={ReportUtils.chatIncludesChronos(report)} 
        
                           isGroupPolicyReport={isGroupPolicyReport} 
        
                           isEmptyChat={isEmptyChat} 
        
                           lastReportAction={lastReportAction} 
        
                           isMenuVisible={isMenuVisible} 
        
                           inputPlaceholder={inputPlaceholder} 
        
                           isComposerFullSize={isComposerFullSize} 
        
                           displayFileInModal={displayFileInModal} 
        
                           textInputShouldClear={textInputShouldClear} 
        
                           setTextInputShouldClear={setTextInputShouldClear} 
        
                           isBlockedFromConcierge={isBlockedFromConcierge} 
        
                           disabled={!!disabled} 
        
                           isFullComposerAvailable={isFullComposerAvailable} 
        
                           setIsFullComposerAvailable={setIsFullComposerAvailable} 
        
                           setIsCommentEmpty={setIsCommentEmpty} 
        
                           handleSendMessage={handleSendMessage} 
        
                           shouldShowComposeInput={shouldShowComposeInput} 
        
                           onFocus={onFocus} 
        
                           onBlur={onBlur} 
        
                           measureParentContainer={measureContainer} 
        
                           listHeight={listHeight} 
        
                           onValueChange={(value) => { 
        
                               if (value.length === 0 && isComposerFullSize) { 
        
                                   Report.setIsComposerFullSize(reportID, false); 
        
                               } 
        
                               validateCommentMaxLength(value, {reportID}); 
        
                           }} 
        
                       />

AttachmentModal connects to several onyx data,

App/src/components/AttachmentModal.tsx

Lines 615 to 634 in f851f57

    
           export default withOnyx<AttachmentModalProps, AttachmentModalOnyxProps>({ 
        
               transaction: { 
        
                   key: ({report}) => { 
        
                       const parentReportAction = ReportActionsUtils.getReportAction(report?.parentReportID ?? '', report?.parentReportActionID ?? ''); 
        
                       const transactionID = parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? parentReportAction?.originalMessage.IOUTransactionID ?? '0' : '0'; 
        
                       return `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`; 
        
                   }, 
        
                   initWithStoredValues: false, 
        
               }, 
        
               parentReport: { 
        
                   key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT}${report ? report.parentReportID : '0'}`, 
        
               }, 
        
               policy: { 
        
                   key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report ? report.policyID : '0'}`, 
        
               }, 
        
               parentReportActions: { 
        
                   key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '0'}`, 
        
                   canEvict: false, 
        
               }, 
        
           })(memo(AttachmentModal));

as we (probably) know, withOnyx will render null if the data is not all ready yet.

In our case, both parentReport and policy are not available yet.

Also, if we open a non-policy chat, the add (+) button is still shown in delay because in AttachmentPickerWithMenuItems, we connect to policy data.

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 330 to 334 in ee8f9c6

    
           export default withOnyx<AttachmentPickerWithMenuItemsProps, AttachmentPickerWithMenuItemsOnyxProps>({ 
        
               policy: { 
        
                   key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`, 
        
               }, 
        
           })(AttachmentPickerWithMenuItems);

What changes do you think we should make in order to solve the problem?

Reading through the code, both parentReport and policy actually in AttachmentModal aren't being used anymore.

App/src/components/AttachmentModal.tsx

Lines 415 to 418 in f851f57

    
           const threeDotsMenuItems = useMemo(() => { 
        
               if (!isReceiptAttachment || !parentReport || !parentReportActions) { 
        
                   return []; 
        
               }

App/src/components/AttachmentModal.tsx

Line 457 in f851f57

    
           }, [isReceiptAttachment, parentReport, parentReportActions, policy, transaction, file, sourceState, iouType]);

The above code shows the only usage of both data.

Both data are first added in #28373 to check whether the user can edit the receipt or not, but the condition (canEditReceipt) is now "transformed" into a prop, so it's now controlled by the parent component. So, it's best to remove both parentReport and policy.

For AttachmentPickerWithMenuItems, set the initial value of the policy to an empty object.
initialValue: {} as OnyxTypes.Policy

What alternative solutions did you explore? (Optional)

Set the initial value for both data in AttachmentModal as an empty object

OR

Replace useOnyx with withOnyx

ikevin127 · 2024-05-02T16:02:41Z

♻️ Reviewing proposals.

ikevin127 · 2024-05-02T18:43:37Z

@c3024 Thanks for your proposal.

RCA:

Composer and AttachmentPicker are inside the AttachmentModal so the icons are loaded quicker than the composer and attachment picker.

Your RCA is partially correct, except the other way around. The components inside the AttachmentModal appear slower to load then the ones outside it.

Regarding your solution: while it solves the positioning of the components outside of the AttachmentModal by keeping them at the right of the container instead of having them move from left to right, it still does not fix the issue as the icons inside the AttachmentModal are still appearing with delay (see attached video).

Android: Native (OnePlus 7T - Android 14)

proposal-2.mp4

Note

If you feel like I missed something from your proposal, please let me know and if the argument is solid I can reconsider assignment.

ikevin127 · 2024-05-02T18:43:41Z

@bernhardoj Thanks for your proposal.

Part of RCA:

as we (probably) know, withOnyx will render null if the data is not all ready yet.

In our case, both parentReport and policy are not available yet.

Your RCA is correct when it comes to the withOnyx rendering null if all imported keys data is not ready yet. I would accept this RCA as correct, if your proposed solution would actually fix the issue.

Regarding your solution: I tested it and there's still an issue with the + (attachment picker component) in the sense that it still appears with delay and there's a weird UI glitch (see video below), therefore your combination of RCA + solution does not fix our issue as per the expected result.

Android: Native (OnePlus 7T - Android 14)

proposal-3.mp4

Note

If you feel like I missed something from your proposal, please let me know and if the argument is solid I can reconsider assignment.

ikevin127 · 2024-05-02T18:43:53Z

Given @ShridharGoel's updated proposal, I'd say the root cause was identified and the updated solution fixes our issue (see video below) as per the expected result which states: "Buttons and input field should become visible at the same time".

Android: Native (OnePlus 7T - Android 14)

proposal-1.mp4

~~🎀👀🎀 C+ reviewed~~

melvin-bot · 2024-05-02T18:44:03Z

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

bernhardoj · 2024-05-03T06:00:38Z

Hmm, I don't see the + action button shown with delay.

Screen.Recording.2024-05-03.at.13.58.18.mov

The AttachmentPickerWithMenuItems is also connected with a policy data, but it's available when I log it,

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 330 to 334 in ee8f9c6

    
           export default withOnyx<AttachmentPickerWithMenuItemsProps, AttachmentPickerWithMenuItemsOnyxProps>({ 
        
               policy: { 
        
                   key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`, 
        
               }, 
        
           })(AttachmentPickerWithMenuItems);

Can you test adding an initial value ({}) to it?

@ikevin127

EDIT: Ah, I can reproduce it if I open a non-related policy chat, so the onyx key will be policy_undefined. The initial value solution will fix it. Updated my proposal to include that.

Julesssss · 2024-05-03T08:27:06Z

Thanks all, I'll let Kevin take another look at @bernhardoj's updated proposal before assigning.

bernhardoj · 2024-05-03T11:28:12Z

false alarm, just linking to a similar issue

ikevin127 · 2024-05-03T21:23:06Z

Thanks all, I'll let Kevin take another look at @bernhardoj's updated proposal before assigning.

Given @bernhardoj's updated proposal, the RCA is correct and makes sense now! The updated solution targets the root cause of the issue and fixes it more efficiently then the previously selected proposal (see videos below).

Android: Native

android.mp4

iOS: Native

ios.MP4

Reasoning:

The updated proposal completely removes the bottleneck which delayed the display of the child components within AttachmentModal and AttachmentPickerWithMenuItems component -> this renders all chat icons at the same time and a lot faster than the previously selected proposal.

Why ?
The previously selected proposal's solution worked in the sense that it would display all chat icons at the same time but it would do this by delaying all the icons display, instead of targeting the root cause which is that components wrapped with withOnyx don't render until all imported onyx keys data is ready.

🎀👀🎀 C+ reviewed

melvin-bot · 2024-05-03T21:23:15Z

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

joekaufmanexpensify · 2024-05-06T13:03:55Z

waiting for sign off on proposal

melvin-bot · 2024-05-07T08:12:25Z

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-05-07T08:12:35Z

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

bernhardoj · 2024-05-07T09:51:53Z

PR is ready

cc: @ikevin127

joekaufmanexpensify · 2024-05-13T14:17:22Z

PR merged today!

joekaufmanexpensify · 2024-05-20T14:23:51Z

On staging

ikevin127 · 2024-05-23T00:25:37Z

⚠️ Automation failed: This was deployed to production today here, therefore should be [HOLD for Payment 2024-05-29] and have Awaiting Payment label.

cc @joekaufmanexpensify @Julesssss

joekaufmanexpensify · 2024-05-28T15:18:04Z

Sounds good! We need to issue the following payments tomorrow:

@bernhardoj - $250 for PR via upwork.
@ikevin127 - $250 for C+ via upwork.

joekaufmanexpensify · 2024-05-29T13:51:23Z

All set to issue payment

joekaufmanexpensify · 2024-05-29T13:54:43Z

@bernhardoj $250 sent and contract ended!

joekaufmanexpensify · 2024-05-29T13:54:49Z

@ikevin127 $250 sent and contract ended!

joekaufmanexpensify · 2024-05-29T13:54:53Z

Upwork job closed.

joekaufmanexpensify · 2024-05-29T13:55:03Z

All set, thanks everyone!

Julesssss added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 1, 2024

Julesssss self-assigned this May 1, 2024

melvin-bot bot assigned joekaufmanexpensify May 1, 2024

Julesssss added the External Added to denote the issue can be worked on by a contributor label May 1, 2024

melvin-bot bot changed the title ~~Chat icons visible before input field renders~~ [$250] Chat icons visible before input field renders May 1, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 1, 2024

melvin-bot bot assigned ikevin127 May 1, 2024

bernhardoj mentioned this issue May 3, 2024

[HOLD for payment 2024-06-05] [$250] iOS - Expense - Chat header appears after delay when opening expense report #41523

Closed

6 tasks

Expensify deleted a comment from melvin-bot bot May 3, 2024

Julesssss assigned bernhardoj May 7, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 7, 2024

bernhardoj mentioned this issue May 7, 2024

Fix composer input rendering is delayed #41727

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 7, 2024

joekaufmanexpensify changed the title ~~[$250] Chat icons visible before input field renders~~ [hold for payment 2024-05-29][$250] Chat icons visible before input field renders May 28, 2024

joekaufmanexpensify closed this as completed May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hold for payment 2024-05-29][$250] Chat icons visible before input field renders #41397

[hold for payment 2024-05-29][$250] Chat icons visible before input field renders #41397

Julesssss commented May 1, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented May 1, 2024

melvin-bot bot commented May 1, 2024

melvin-bot bot commented May 1, 2024

ShridharGoel commented May 1, 2024 •

edited

Loading

ikevin127 commented May 1, 2024

ikevin127 commented May 2, 2024

c3024 commented May 2, 2024 •

edited

Loading

ShridharGoel commented May 2, 2024

bernhardoj commented May 2, 2024 •

edited

Loading

ikevin127 commented May 2, 2024

ikevin127 commented May 2, 2024

ikevin127 commented May 2, 2024

ikevin127 commented May 2, 2024 •

edited

Loading

melvin-bot bot commented May 2, 2024

bernhardoj commented May 3, 2024 •

edited

Loading

Julesssss commented May 3, 2024

bernhardoj commented May 3, 2024

ikevin127 commented May 3, 2024

melvin-bot bot commented May 3, 2024

joekaufmanexpensify commented May 6, 2024

melvin-bot bot commented May 7, 2024

melvin-bot bot commented May 7, 2024

bernhardoj commented May 7, 2024

joekaufmanexpensify commented May 13, 2024

joekaufmanexpensify commented May 20, 2024

ikevin127 commented May 23, 2024

joekaufmanexpensify commented May 28, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

[hold for payment 2024-05-29][$250] Chat icons visible before input field renders #41397

[hold for payment 2024-05-29][$250] Chat icons visible before input field renders #41397

Comments

Julesssss commented May 1, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Platforms:

Screenshots/Videos

melvin-bot bot commented May 1, 2024

melvin-bot bot commented May 1, 2024

melvin-bot bot commented May 1, 2024

ShridharGoel commented May 1, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

ikevin127 commented May 1, 2024

ikevin127 commented May 2, 2024

c3024 commented May 2, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ShridharGoel commented May 2, 2024

Proposal

bernhardoj commented May 2, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ikevin127 commented May 2, 2024

ikevin127 commented May 2, 2024

ikevin127 commented May 2, 2024

ikevin127 commented May 2, 2024 • edited Loading

melvin-bot bot commented May 2, 2024

bernhardoj commented May 3, 2024 • edited Loading

Julesssss commented May 3, 2024

bernhardoj commented May 3, 2024

ikevin127 commented May 3, 2024

melvin-bot bot commented May 3, 2024

joekaufmanexpensify commented May 6, 2024

melvin-bot bot commented May 7, 2024

melvin-bot bot commented May 7, 2024

bernhardoj commented May 7, 2024

joekaufmanexpensify commented May 13, 2024

joekaufmanexpensify commented May 20, 2024

ikevin127 commented May 23, 2024

joekaufmanexpensify commented May 28, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

joekaufmanexpensify commented May 29, 2024

Julesssss commented May 1, 2024 •

edited by melvin-bot bot

Loading

ShridharGoel commented May 1, 2024 •

edited

Loading

c3024 commented May 2, 2024 •

edited

Loading

bernhardoj commented May 2, 2024 •

edited

Loading

ikevin127 commented May 2, 2024 •

edited

Loading

bernhardoj commented May 3, 2024 •

edited

Loading