Deploy Checklist: New Expensify 2024-05-02

[github-actions]

Release Version: 1.4.70-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Make subscribeToState return a simple ID instead of a complex GUID #11
• [VIP-Travel] Workspace address page and section in workspace profile #38381
• feat: add hmmm log level to onyx #39076
• Update redirects.csv #39106
• Fix: grey line SpacerView same padding as green line UnreadActionIndicator #39297
• Update Change-member-workspace-roles.md #40117
• Update Invite-members-and-assign-roles.md #40119
• Xero Import main page and Xero Organization Page #40984
• Console error shows up when clicking Share button #40985
• chore: bump react-native-onyx to 2.0.35 #41056
• Fix account type name constants #41155
• fix: two errors appear in validate code page #41190
• Use new avatarURL key for workspace avatars #41193
• [NoQA] Add eslint-plugin-testing-library #41203
• Rename GPS points parameter #41214
• Fix missing video action bar on Safari #41218
• Fix recent report is missing from the assignee list #41232
• Fix duplicate react-pdf dependency #41238
• Update Scheduled-Submit.md #41253
• [CP Staging] Hide anonymous email in user details tooltip and profile page #41288
• fix: back arrow twice to return to LHN #41317
• Show valid menu options on selection to change access #41319
• fix: add new log when remove persisted requests #41334
• Fix iOS Privacy Manifest issues #41360
• Fix edited message reverted to previous message #41372
• Feat/xero import customer #41377
• [Access control]: Hide options visibility and room name for invoices #41380
• DOCS: Update and rename Coming-Soon.md to Join-your-company's-workspa… #41382
• DOCS: Create Create-a-company-workspace.md #41384
• DOCS: Update and rename Request-Money.md to Create-an-expense.md #41388
• DOCS: Create Split-an-expense.md #41391
• Xero import taxes page #41393
• DOCS: Create Manually-submit-reports-for-approval.md #41395
• DOCS: Update Send-and-format-chat-messages.md #41396
• Navigate to the workspace chat immediately after share a track expense #41409
• [Wave collect][Xero] - Show not imported as default. #41415
• [Wave Collect] [Xero] Fix UX inconsistencies for Organization page #41417
• Update redirects.csv #41420
• Fix dropdown button style on taxes page #41421
• Show an error on the More Features page if the admin tries to disconnect the Accounting feature while there is an active accounting connection while the device is offline #41446
• [No QA] Fix comment in PolicyJoinMember #41462
• [CP Staging] Fix regression #41504 #41526
• [CP Staging] Roll back react-native-onyx to version 2.0.32 #41612
• Fix getContinuousReportActionChain with optimistic actions #41644
• [CP Staging] Fix GetMissingOnyxMessages infinite loop when processing deferred updates #41702

Deploy Blockers:

• [$250] Send invoice - App crashes after creating invoice #41504
• [HOLD for payment 2024-05-22] [CRITICAL] [VIP-Travel] Workspace - Unable to select country in Company address #41505
• Workspace - "Company address" shows up for employee when it is not set up #41506
• [HOLD for payment 2024-06-05] [$250] Task – “Assign to me” missing in list of assignees in task creation flow for Gmail account #41510
• [HOLD for payment 2024-06-06] [$250] BNP - Delay in showing new currency when selecting a new currency #41515
• [HOLD for payment 2024-06-05] [$250] iOS - Expense - Chat header appears after delay when opening expense report #41523
• Profile - Address - Zip code verification does not work correctly #41531
• [$250] iOS - Thread - Chat is scrolled up when opening message in thread #41532
• iOS - App is slow and device heats up easily when performing basic functions #41534
• Workspace - App crashed when send attachment offline and delete workspace from other device #41573
• Wallet - "Debit card setup not allowed" error appears when adding a card #41601
• Processing deferred updates for push notifications causes an infinite loop #41704

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.70-0 🚀

[rlinoz]

Demoted #41505

[francoisl]

#41506: demoting, under a beta
#41504: fix tested on staging, checking off
#41532: demoted, can't reproduce consistently

[amyevans]

Demoted #41515

[kavimuru]

Regression is still 40% left.

#40984 pending validation in mweb desktop, android and ios
#41155 - pending validation in Desktop and Android
#41190 - pending validation in mweb desktop and iOS
#41193 failing with #41387 reproduced in production checking it off
#41214 commented #41214 (comment)
#41288 - pending validation in desktop android and iOS
#41377 failing in android with #40978 repro in production checking it off
#41380 failing with #41504
#41415 failing with #41512 repro in production checking it off

[kavimuru]

Regression is down to 6%
#38381 failing with #41505
#41190 - Desktop blocked with #25790 (comment)
#41288 - desktop blocked with #25790 (comment)
#41380 failing with #41504

[luacmartins]

Checking off #41523. It was demoted to NAB

[kavimuru]

Regression completed.

#38381 failing with #41505
#41190 - Desktop blocked with #25790 (comment)
#41288 - desktop blocked with #25790 (comment)
#41380 failing with #41504

[francoisl]

#41531: Fix tested on staging, checking off

[francoisl]

The last 2 Testflights failed building for iOS (other platforms are fine), looking into it in internal issue https://github.com/Expensify/Expensify/issues/379010.

Edit: internal discussion about failing Testflights here.

[roryabraham]

Checked off #41573, it's fixed on staging

[marcaaron]

Checking off #41534 as we seem unable to get a reproduction for it. Doesn't seem worth holding up the deploy over.

[marcaaron]