[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] App crashes after pressing R in metro bundler on iOS simulator

[adamgrzybowski]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.73-4
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @adamgrzybowski
Slack conversation:

Action Performed:

This crash only affects developers

• Run the app on the iOS with metro running
• Press R in the metro console to reload

Expected Result:

App reloads

Actual Result:

App crashes

Workaround:

Don't reload the app 🤷

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

crash.mov

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[adamgrzybowski]

@WoLewicki is going to fix that

[joekaufmanexpensify]

Discussing here. Please hold on starting this in the interim until we confirm from an internal engineer that we want to prioritize this.

[joekaufmanexpensify]

Is the next step here to raise a PR?

[joekaufmanexpensify]

@WoLewicki @adamgrzybowski mind confirming if there is an ETA for a PR here?

[WoLewicki]

I'll try to get it ready today 🚀

[mananjadhav]

@mountiny @joekaufmanexpensify Does this need C+ review?

[WoLewicki]

Here is the PR: #42343. Here is also a PR to markdown repository: Expensify/react-native-live-markdown#349.

[joekaufmanexpensify]

@mountiny @joekaufmanexpensify Does this need C+ review?

I am not sure. Going to defer to Vit on this. I would wait until he chimes in.

[joekaufmanexpensify]

PR is in review. @mountiny I assume this needs C+ review, but interested if you agree before Manan goes ahead?

[mountiny]

I am not sure if we need to merge the patch, but instead we can wait for the fix from the Expensify/react-native-live-markdown#349 imho

[mananjadhav]

Agreed makes sense. I am assuming it's not blocking anyone. It'll only slow done the dev and we can get the PR merged asap.

[joekaufmanexpensify]

PR still in review

[WoLewicki]

I think we can close this one since the changes are already on main and working (see #42343 (comment))

[mountiny]

Ok perfect, thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @WoLewicki does not require payment (Contractor)
• @adamgrzybowski does not require payment (Contractor)
• @adamgrzybowski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @WoLewicki does not require payment (Contractor)
• @adamgrzybowski does not require payment (Contractor)
• @adamgrzybowski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: