[CRITICAL] [$250] #announce room should default to 'Admins Only' for posting

[garrettmknight]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.73-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C05RECHFBEW/p1715886822520169

Action Performed:

1. Create a workspace
2. Navigate to the #announce room for your new workspace
3. Open the chat settings

Expected Result:

Who can post should be defaulted to Admin only as it was designed in this doc

Actual Result:

Who can post is set to All members

Workaround:

You can set it to admins only.

Platforms:

All

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d20a5670a3bdd03e
• Upwork Job ID: 1792954078450966528
• Last Price Increase: 2024-08-08
• Automatic offers:
• nkdengineer | Contributor | 102491174

Issue Owner

Current Issue Owner: @danieldoglas

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Who can post is set to All members

What is the root cause of that problem?

When we create a new workspace, the announce room has writeCapability as undefined in optimistic data and then BE returns it as all.

App/src/libs/ReportUtils.ts

Line 4710 in e8ae3c5

undefined,

What changes do you think we should make in order to solve the problem?

We should pass writeCapability as CONST.REPORT.WRITE_CAPABILITIES.ADMINS here to fix the offline case for announce room

App/src/libs/ReportUtils.ts

Line 4710 in e8ae3c5

undefined,

And BE also need to return writeCapability of announce room as admin in CreateWorkspace API

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d20a5670a3bdd03e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[eVoloshchak]

The fix is pretty straightforward, @nkdengineer's proposal looks good to me!
Changes to BE would also be needed

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@eVoloshchak, @lakchote, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[lakchote]

@nkdengineer's proposal LGTM.

I'll take care of the BE changes.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

We have a draft PR here
@lakchote please let me know when BE is done

[melvin-bot]

@eVoloshchak, @lakchote, @miljakljajic, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@eVoloshchak @lakchote @miljakljajic @nkdengineer this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@eVoloshchak, @lakchote, @miljakljajic, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[danieldoglas]

Sorry, there are some other competing priorities which are taking some time before this.

[danieldoglas]

All backend PRs were created. We need to wait for the reviews/deploys - probably done by the end of the week

[danieldoglas]

Last backend PR was merged, should be deployed Monday and we can close this.

[danieldoglas]

This is done in the backend. @nkdengineer all yours to finish the app pr

[nkdengineer]

@danieldoglas thank you, I'm working on this PR now

[nkdengineer]

@danieldoglas Currently, after creating a new workspace, I am unable to access the announce room.

bug-resize.mp4

[danieldoglas]

You need your workspace with at least 4 people to have an announce room. This was changed recently.

[nkdengineer]

@eVoloshchak this PR is ready for review

[garrettmknight]

Merged, awaiting delpoy - should be deployed to staging today.

[miljakljajic]

seems like this PR went out over 7 days ago, so I've paid @nkdengineer and providing a payment summary below for @eVoloshchak

@eVoloshchak is owed 250 for their work reviewing this issue.

[miljakljajic]

If there are any further actions to take, please assign another BZ team member - I am out on extended leave from the end of the day.

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: no PR that has caused this, this is an initial implementation on the back end
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed, it isn't a bug per se, rather a change in expected behavior
• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? No
  We don't need a regression test here, this will no break as long as back end fix is not reversed

[JmillsExpensify]

$250 approved for @eVoloshchak

[JmillsExpensify]

Opening back up for the regression test.

[JmillsExpensify]

Milja is out so I'll take this.